Dmitry,
It makes sense to consider a special exit code for transport init error.
Other than that it looks good.
No need to re-review.
Thanks,
Serguei
On 8/26/14 10:46 AM, Dmitry Samersoff wrote:
Serguei,
exit_code set to 1 at ll. 1288
I thought of refactoring this code for better readability
Serguei,
exit_code set to 1 at ll. 1288
I thought of refactoring this code for better readability but finally
decide to keep changes minimal.
-Dmitry
On 2014-08-26 21:35, serguei.spit...@oracle.com wrote:
> Dmitry,
>
> This looks good in general.
> But what error code will be returned in the
Dmitry,
This looks good in general.
But what error code will be returned in the case of
AGENT_ERROR_TRANSPORT_INIT ?
Is it Ok to return whatever exit_code we already have or we better
return some special error code?
Probably, it is Ok to keep the comment at the line 1315 as it is.
Thanks,
S
On 8/26/14 8:25 AM, Dmitry Samersoff wrote:
Serguei,
On 2014-08-26 14:58, serguei.spit...@oracle.com wrote:
Dmitry,
I doubt, this webrev fixes the issue.
At least, I can't see it yet.
It looks like the assert is because the imagePath_ID or symbolPath_ID
were not initialized properly.
If imag
On 8/26/2014 3:59 AM, Staffan Larsen wrote:
There are some differences in the AttachProvideImpl files. Most notably the
windows version is very different. Linux, Bsd and Aix are the same. The Solaris
version has a minor difference in the “public String type()” implementation.
The Linux, Bsd,
Serguei,
On 2014-08-26 14:58, serguei.spit...@oracle.com wrote:
> Dmitry,
>
> I doubt, this webrev fixes the issue.
> At least, I can't see it yet.
>
> It looks like the assert is because the imagePath_ID or symbolPath_ID
> were not initialized properly.
If imagePath_ID or symbolPath_ID is NULL
Staffan,
http://cr.openjdk.java.net/~dsamersoff/JDK-8049226/webrev.03/
After couple of experiments I end up with simple fix - don't coredump on
AGENT_ERROR_TRANSPORT_INIT
Current code don't propagate transport error to upper level, so if we
need fine grained control I'll rewrite transport initia
Looks good
Bengt Rutisson skrev 2014-08-26 10:50:
Hi all,
Staffan sent me an updated webrev based on Erik's comments. I uploaded
it here:
http://cr.openjdk.java.net/~brutisso/8055845/webrev.01/
Thanks,
Bengt
On 2014-08-25 19:32, Staffan Friberg wrote:
Hi Erik,
No issue with naming the f
On 08/26/2014 01:20 PM, Poonam Bajaj wrote:
Hi Jaroslav,
On 8/26/2014 4:06 PM, Jaroslav Bachorik wrote:
Hi Poonam,
On 08/26/2014 12:27 PM, Poonam Bajaj wrote:
Sending the review request to serviceability-dev list as well...
---
Could I have reviews for this change:
Bug: https://bugs
Looks good.
Thanks,
Serguei
On 8/11/14 7:57 AM, Dmitry Samersoff wrote:
Hi Everybody,
Please, review small fix that adds more exception handling code
http://cr.openjdk.java.net/~dsamersoff/JDK-8031583/webrev.01/
-Dmitry
On 8/26/14 3:58 AM, serguei.spit...@oracle.com wrote:
Dmitry,
I doubt, this webrev fixes the issue.
At least, I can't see it yet.
It looks like the assert is because the imagePath_ID or symbolPath_ID
were not initialized properly.
But there is clear explanation yet how this could happen.
Sor
On 8/26/14 12:59 PM, Staffan Larsen wrote:
There are some differences in the AttachProvideImpl files. Most notably the
windows version is very different. Linux, Bsd and Aix are the same. The Solaris
version has a minor difference in the “public String type()” implementation.
The Linux, Bsd, A
Hi Jaroslav,
On 8/26/2014 4:06 PM, Jaroslav Bachorik wrote:
Hi Poonam,
On 08/26/2014 12:27 PM, Poonam Bajaj wrote:
Sending the review request to serviceability-dev list as well...
---
Could I have reviews for this change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8049303
Webrev:
There are some differences in the AttachProvideImpl files. Most notably the
windows version is very different. Linux, Bsd and Aix are the same. The Solaris
version has a minor difference in the “public String type()” implementation.
The Linux, Bsd, Aix and Solaris versions could probably be uni
Dmitry,
I doubt, this webrev fixes the issue.
At least, I can't see it yet.
It looks like the assert is because the imagePath_ID or symbolPath_ID
were not initialized properly.
But there is clear explanation yet how this could happen.
Maybe, the conclusion above was wrong, but some prove is ne
Hi Mandy,
I'm seeing some small differences in the various VirtualMachineImpl.java
files, but if I'm not mistaken, all the new AttachProviderImpl.java look
all the same. I wonder if the patch could be further simplified by
moving AttachProviderImpl.java to jdk.attach/share/classes (unless
there's
Hi Poonam,
On 08/26/2014 12:27 PM, Poonam Bajaj wrote:
Sending the review request to serviceability-dev list as well...
---
Could I have reviews for this change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8049303
Webrev: http://cr.openjdk.java.net/~poonam/8049303/webrev.00/
L1499-
Sending the review request to serviceability-dev list as well...
---
Could I have reviews for this change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8049303
Webrev: http://cr.openjdk.java.net/~poonam/8049303/webrev.00/
Problem and fix:
By default the JMX client side notification fet
Hi all,
Staffan sent me an updated webrev based on Erik's comments. I uploaded
it here:
http://cr.openjdk.java.net/~brutisso/8055845/webrev.01/
Thanks,
Bengt
On 2014-08-25 19:32, Staffan Friberg wrote:
Hi Erik,
No issue with naming the field class, since the event is similar to
the Alloc
Looks good!
Thanks,
/Staffan
On 26 aug 2014, at 10:15, Jaroslav Bachorik
wrote:
> On 08/25/2014 08:37 PM, Staffan Larsen wrote:
>> Thanks for taking on this one!
>>
>> The code looks good. Just two small things below.
>>
>> Have you tested with -Xverify:all, just to see if there are any byte
Nice!
/Erik
On 2014-08-26 06:29, Mandy Chung wrote:
Webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/
This patch renames the class name of attach provider implementation class
to be the same for all platforms. This simplifies the build logic and
removes the need for generati
On 08/25/2014 08:37 PM, Staffan Larsen wrote:
Thanks for taking on this one!
The code looks good. Just two small things below.
Have you tested with -Xverify:all, just to see if there are any byte code
problems?
I've re-run the tests with -Xverify:all and fixed one problem in the
generated b
On 26 Aug 2014, at 08:26, Alan Bateman wrote:
> On 26/08/2014 05:29, Mandy Chung wrote:
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/
>>
>> This patch renames the class name of attach provider implementation class
>> to be the same for all platforms. This simplifies
On 26/08/2014 05:29, Mandy Chung wrote:
Webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/
This patch renames the class name of attach provider implementation class
to be the same for all platforms. This simplifies the build logic and
removes the need for generating the service
24 matches
Mail list logo
