Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

In case you are still waiting this all looks fine to me. Thanks, David On 13/11/2014 2:49 AM, Evgeniya Stepanova wrote: Forgotten copyrights were changed http://cr.openjdk.java.net/~eistepan/8062536/webrev.04/ On 12.11.2014 20:07, Evgeniya Stepanova wrote: Hi Bengt, Please see comments inlin

Re: [9] RFR (S) 6762191: Setting stack size to 16K causes segmentation fault

Adding core-libs-...@openjdk.java.net, since one of the changes is in java.c. Chris On 11/12/14 6:43 PM, David Holmes wrote: Hi Chris, Sorry for the delay. On 13/11/2014 5:44 AM, Chris Plummer wrote: Hi, I'm still looking for reviewers. As the change is to the launcher it needs to be rev

Re: RFR 8064694: Kitchensink: WaitForMultipleObjects failed in hotspot\src\os\windows\vm\os_windows.cpp: 3844

> http://cr.openjdk.java.net/~igerasim/8064694/2/webrev/ src/os/windows/vm/os_windows.cpp No commments. Thumbs up. Dan On 11/18/14 12:29 AM, Ivan Gerasimov wrote: Hi Markus! The priority of the exiting thread will be raised for quite a short period of time -- right before the thread fi

Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

Looks good! -JB- On 11/18/2014 03:57 PM, Yekaterina Kantserova wrote: Jaroslav, Erik, thanks! The new webrev can be found here http://cr.openjdk.java.net/~ykantser/6542634/webrev.01/ // Katja On 11/18/2014 03:36 PM, Jaroslav Bachorik wrote: On 11/18/2014 02:05 PM, Yekaterina Kantserova wro

Re: RFR(S): JDK-8065220: Include alternate sa.make file for MacOSX

Looks good! /Staffan > On 18 nov 2014, at 16:17, Erik Gahlin wrote: > > Looks good > > Erik > > Poonam Bajaj skrev 2014-11-18 15:33: >> Hello, >> >> Could I request reviews for this simple change to include alternate sa.make >> file in make/bsd/makefiles/sa.make: >> >> Bug: JDK-8065220:

Re: RFR(S): JDK-8065220: Include alternate sa.make file for MacOSX

Looks good Erik Poonam Bajaj skrev 2014-11-18 15:33: Hello, Could I request reviews for this simple change to include alternate sa.make file in make/bsd/makefiles/sa.make: Bug:JDK-8065220: Include alternate sa.make file for MacOSX Webrev:

Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

Jaroslav, Erik, thanks! The new webrev can be found here http://cr.openjdk.java.net/~ykantser/6542634/webrev.01/ // Katja On 11/18/2014 03:36 PM, Jaroslav Bachorik wrote: On 11/18/2014 02:05 PM, Yekaterina Kantserova wrote: Hi Jaroslav, Thanks for the quick review! test/sun/tools/jinfo/J

RE: RFR(S): JDK-8065220: Include alternate sa.make file for MacOSX

Hi Poonam,   Looks good.   Thanks Markus   From: Poonam Bajaj Sent: den 18 november 2014 15:34 To: serviceability-dev@openjdk.java.net Subject: RFR(S): JDK-8065220: Include alternate sa.make file for MacOSX   Hello, Could I request reviews for this simple change to include alternate sa.m

Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

On 11/18/2014 02:05 PM, Yekaterina Kantserova wrote: Hi Jaroslav, Thanks for the quick review! test/sun/tools/jinfo/JInfoRunningProcessFlagTest.java is added to the ProblemList because it contains this case: 90 private static void testInvalidFlag() throws Exception { 91 Outpu

RFR(S): JDK-8065220: Include alternate sa.make file for MacOSX

Hello, Could I request reviews for this simple change to include alternate sa.make file in make/bsd/makefiles/sa.make: Bug:JDK-8065220: Include alternate sa.make file for MacOSX Webrev: http://cr.openjdk.java.net/~poonam/8065220/webrev.00/ T

Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

Looks good! Erik Yekaterina Kantserova skrev 2014-11-18 12:07: Hi, Could I please have a review of this fix. In this fix I take an opportunity to refactor sun/tools/jinfo/Basic.sh and to add more tests for jinfo utility. sun/tools/jinfo/Basic.sh is a last unstable test among tests listed i

Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

Hi Jaroslav, Thanks for the quick review! test/sun/tools/jinfo/JInfoRunningProcessFlagTest.java is added to the ProblemList because it contains this case: 90 private static void testInvalidFlag() throws Exception { 91 OutputAnalyzer output = JInfoHelper.jinfo("-flag", "monkey"

RE: RFR 8064694: Kitchensink: WaitForMultipleObjects failed in hotspot\src\os\windows\vm\os_windows.cpp: 3844

Hi Ivan, I don't want to you block you from getting this in - I need to get the full story behind all these changes (backtracking now). If I find something that I think we should revisit, we can always do that later. So pls go ahead. Thanks Markus PS. I have some concerns (but will need to ge

Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

Hi Katja, test/ProblemList.txt - you are adding seemingly unrelated issue here test/sun/tools/jinfo/JInfoHelper.java L68 - processBuilder.command(...) could be moved to L67 and do new ProcessBuilder(launcher.getCommand()) - it communicates the purpose better Cheers, -JB- On 11/18/2014 12:0

RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

Hi, Could I please have a review of this fix. In this fix I take an opportunity to refactor sun/tools/jinfo/Basic.sh and to add more tests for jinfo utility. sun/tools/jinfo/Basic.sh is a last unstable test among tests listed inhttps://bugs.openjdk.java.net/browse/JDK-6542634 that's why I've