Re: RFR 8064441: java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

2014-12-04 Thread David Holmes
On 3/12/2014 1:51 AM, Jaroslav Bachorik wrote: On 12/02/2014 10:37 AM, David Holmes wrote: On 1/12/2014 7:16 PM, Jaroslav Bachorik wrote: On 11/27/2014 09:33 AM, Jaroslav Bachorik wrote: On 11/27/2014 01:43 AM, David Holmes wrote: On 26/11/2014 10:57 PM, Jaroslav Bachorik wrote: Please, revi

Re: [9] RFR (S) 6762191: Setting stack size to 16K causes segmentation fault

2014-12-04 Thread serguei.spit...@oracle.com
It still looks good to me too. :) Thanks, Serguei On 12/4/14 3:46 PM, David Holmes wrote: Looks good to me too Chris - sorry for the delay getting back to you. But at least Kumar spotted all the typos :) David On 4/12/2014 6:12 PM, Chris Plummer wrote: On 12/3/14 4:56 AM, Alan Bateman wrote

Re: [9] RFR (S) 6762191: Setting stack size to 16K causes segmentation fault

2014-12-04 Thread David Holmes
Looks good to me too Chris - sorry for the delay getting back to you. But at least Kumar spotted all the typos :) David On 4/12/2014 6:12 PM, Chris Plummer wrote: On 12/3/14 4:56 AM, Alan Bateman wrote: On 02/12/2014 02:39, Chris Plummer wrote: Sorry about the long delay in getting back to t

Re: RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

2014-12-04 Thread Maynard Johnson
On 12/04/2014 01:15 PM, Alexander Smundak wrote: > The changes for agent/src/os/linux/symtab.c > b/agent/src/os/linux/symtab.c in > http://cr.openjdk.java.net/~simonis/webrevs/8049716 will break > Linux/PPC64 little-endian: > it uses ABIv2, which dropped function descriptors. So the preprocessor >

A hotspot patch for stack profiling (frame pointer)

2014-12-04 Thread Brendan Gregg
G'Day, I've hacked hotspot to return the frame pointer, in part to see what this involves, and also to have a working prototype for analysis. Along with an agent to resolve symbols, this has allowed full stack profiling using Linux perf_events. The following flame graphs show the resulting profile

Re: [9] RFR (S) 6762191: Setting stack size to 16K causes segmentation fault

2014-12-04 Thread Chris Plummer
On 12/4/14 9:30 AM, Alan Bateman wrote: On 04/12/2014 08:12, Chris Plummer wrote: Hi Alan, While removing the java.io.File import, I also questioned why I had java.io.IOException being imported. There were a couple of methods that declared it thrown, and the main method therefore had to catch

RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

2014-12-04 Thread Volker Simonis
Hi, I'd like to submit this webrev which adds support for the SA agent on Linux/PPC64 on behalf of Maynard Johnson who is the main author of the change: http://cr.openjdk.java.net/~simonis/webrevs/8049716 https://bugs.openjdk.java.net/browse/JDK-8049716 I have already reviewed and tested the cha

Re: [9] RFR (S) 6762191: Setting stack size to 16K causes segmentation fault

2014-12-04 Thread Alan Bateman
On 04/12/2014 08:12, Chris Plummer wrote: Hi Alan, While removing the java.io.File import, I also questioned why I had java.io.IOException being imported. There were a couple of methods that declared it thrown, and the main method therefore had to catch it, but it turns out this was just copy

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

2014-12-04 Thread Maynard Johnson
On 12/04/2014 02:20 AM, Volker Simonis wrote: > On Wed, Dec 3, 2014 at 7:55 PM, Maynard Johnson wrote: >> On 12/03/2014 12:33 PM, Maynard Johnson wrote: >>> On 12/03/2014 02:40 AM, Volker Simonis wrote: On Tue, Dec 2, 2014 at 9:50 PM, Maynard Johnson wrote: > In the approximate 10

Re: RFR(XS): 8061785: [TEST_BUG] serviceability/sa/jmap-hashcode/Test8028623.java has utf8 character corrupted by earlier merge

2014-12-04 Thread KEVIN WALLS
Thanks both of you!

Re: RFR(XS): 8061785: [TEST_BUG] serviceability/sa/jmap-hashcode/Test8028623.java has utf8 character corrupted by earlier merge

2014-12-04 Thread Dmitry Samersoff
Looks good for me. -Dmitry On 2014-12-04 01:06, KEVIN WALLS wrote: > Hi, > > This is a review request for a changing a couple of characters in a > test. It's the same test I just changed with another review, I kept it > separate so as to complicate the review already in progress (it had gone >

Re: RFR(XS): 8061785: [TEST_BUG] serviceability/sa/jmap-hashcode/Test8028623.java has utf8 character corrupted by earlier merge

2014-12-04 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 3 dec 2014, at 23:06, KEVIN WALLS wrote: > > Hi, > > This is a review request for a changing a couple of characters in a test. > It's the same test I just changed with another review, I kept it separate so > as to complicate the review already in progress (

RFR 8034263: Test java/lang/management/MemoryMXBean/LowMemoryTest.java fails intermittently

2014-12-04 Thread Jaroslav Bachorik
Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8034263 Webrev: http://cr.openjdk.java.net/~jbachorik/8034263/webrev.00 The test fails intermittently only for CMS collector - "One thing about CMS is that it does concurrent work. So just a theory would

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

2014-12-04 Thread Volker Simonis
On Wed, Dec 3, 2014 at 7:55 PM, Maynard Johnson wrote: > On 12/03/2014 12:33 PM, Maynard Johnson wrote: >> On 12/03/2014 02:40 AM, Volker Simonis wrote: >>> On Tue, Dec 2, 2014 at 9:50 PM, Maynard Johnson wrote: In the approximate 10 times that I re-ran my test with the "-XX:-Inline" (

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

2014-12-04 Thread Volker Simonis
On Wed, Dec 3, 2014 at 7:50 PM, Andrew Haley wrote: > On 12/03/2014 06:20 PM, Maynard Johnson wrote: >>> If you're running on Debian/Ubuntu it is probably this issue: >>> > >>> > https://wiki.ubuntu.com/SecurityTeam/Roadmap/KernelHardening#ptrace_Protection >>> > >>> > which can be solved by doing

Re: [9] RFR (S) 6762191: Setting stack size to 16K causes segmentation fault

2014-12-04 Thread Chris Plummer
On 12/3/14 4:56 AM, Alan Bateman wrote: On 02/12/2014 02:39, Chris Plummer wrote: Sorry about the long delay in getting back to this. I ran into two separate JPRT issues that were preventing me from testing these changes, plus I was on vacation last week. Here's an updated webrev. I'm not sure