Re: RFR(S): 6755586: Test com/sun/jdi/NoLaunchOptionTest.java may erroneously fail

Staffan, Dmitry, thank you for the reviews! // Katja On 05/07/2015 10:40 PM, Dmitry Samersoff wrote: Looks good for me! -Dmitry On 2015-05-07 18:04, Yekaterina Kantserova wrote: Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-6755586 webre

Re: RFR(S): 6755586: Test com/sun/jdi/NoLaunchOptionTest.java may erroneously fail

Looks good for me! -Dmitry On 2015-05-07 18:04, Yekaterina Kantserova wrote: > Hi, > > Could I please have a review of this small fix. > > bug: https://bugs.openjdk.java.net/browse/JDK-6755586 > webrev: http://cr.openjdk.java.net/~ykantser/6755586/webrev.00/ > > This bug is actually already so

Re: RFR(S): 6755586: Test com/sun/jdi/NoLaunchOptionTest.java may erroneously fail

Nice and clean. Reviewed. /Staffan > On 7 maj 2015, at 17:04, Yekaterina Kantserova > wrote: > > Hi, > > Could I please have a review of this small fix. > > bug: https://bugs.openjdk.java.net/browse/JDK-6755586 > webrev: http://cr.openjdk.java.net/~ykantser/6755586/webrev.00/ > > This bug i

Re: PING Re: RFR: 8078521: AARCH64: Add AArch64 SA support

On 05/07/2015 05:32 PM, Dmitry Samersoff wrote: > Andrew, > > Looks good, except couple of minor nits. > > Please, take a look at LinuxAARCH64CFrame.java:70, > it might be a bug - probably, you should check against fp, > not rsp here. > > See also below. > > LinuxDebuggerLocal.c: > > 375: Plea

Re: PING Re: RFR: 8078521: AARCH64: Add AArch64 SA support

Andrew, Looks good, except couple of minor nits. Please, take a look at LinuxAARCH64CFrame.java:70, it might be a bug - probably, you should check against fp, not rsp here. See also below. LinuxDebuggerLocal.c: 375: Please, use NPRGREG from AARCH64ThreadContext.java, the same way as other plat

Re: 8079200: Fix heapdump tests to validate heapdump after jhat is removed

Katja, Looks good for me. -Dmitry On 2015-05-07 11:54, Yekaterina Kantserova wrote: > Hi, > > Could I please have a review of this fix. > > bug: https://bugs.openjdk.java.net/browse/JDK-8079200 > webrev: http://cr.openjdk.java.net/~ykantser/8079200/webrev.00 > > The fix makes sure the HprofPa

RFR(S): 6755586: Test com/sun/jdi/NoLaunchOptionTest.java may erroneously fail

Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-6755586 webrev: http://cr.openjdk.java.net/~ykantser/6755586/webrev.00/ This bug is actually already solved. But I'll use it as an opportunity to re-write the test using test library. There is no

RE: RFR(XS): 8079510: AIX: fix build after '8042901: Allow com.sun.management to be in a different module...'

Hi Volker, the change looks good. Thanks for fixing this. Best regards, Goetz. -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Volker Simonis Sent: Mittwoch, 6. Mai 2015 18:12 To: jdk9-...@openjdk.java.net; serviceability

Re: 8079200: Fix heapdump tests to validate heapdump after jhat is removed

Looks good! Thanks, /Staffan > On 7 maj 2015, at 10:54, Yekaterina Kantserova > wrote: > > Hi, > > Could I please have a review of this fix. > > bug: https://bugs.openjdk.java.net/browse/JDK-8079200 > webrev: http://cr.openjdk.java.net/~ykantser/8079200/webrev.00 > > The fix makes sure the

8079200: Fix heapdump tests to validate heapdump after jhat is removed

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8079200 webrev: http://cr.openjdk.java.net/~ykantser/8079200/webrev.00 The fix makes sure the HprofParser is available for all types of test frameworks, not only JTreg. It will be a part of test-lib.jar

Re: RFR: 8079559 Exclude demo/jvmti/hprof tests

On 07/05/2015 09:06, Staffan Larsen wrote: A couple of hprof demos fail because of lambdas (see JDK-8079273). Since we are soon removing hprof, there is no use updating the code or tests, so instead I want to exclude the tests. bug: https://bugs.openjdk.java.net/browse/JDK-8079559 Looks o

RFR: 8079559 Exclude demo/jvmti/hprof tests

A couple of hprof demos fail because of lambdas (see JDK-8079273). Since we are soon removing hprof, there is no use updating the code or tests, so instead I want to exclude the tests. bug: https://bugs.openjdk.java.net/browse/JDK-8079559 Than

Re: RFR: 8079360 AttachProviderImpl could not be instantiated

Looks good to me. /Erik On 2015-05-06 20:51, Staffan Larsen wrote: This is another library that needs to be compiled with -DPSAPI_VERSION=1 due to the recent Windows compiler upgrade. I have also fixed a better error message that prints the underlaying exception if something like this happen

Re: RFR: 8079360 AttachProviderImpl could not be instantiated

Build changes look good to me. /Magnus > 6 maj 2015 kl. 20:51 skrev Staffan Larsen : > > This is another library that needs to be compiled with -DPSAPI_VERSION=1 due > to the recent Windows compiler upgrade. > > I have also fixed a better error message that prints the underlaying > exception