Hi Dmitry,
I uploaded new webrev:
hotspot (not changed):
http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.02/hotspot/
jdk:
http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.02/jdk/
Could you review it again?
BTW, jmap test uses "compiler detected" as expect
On 3/3/16 12:56 PM, Andreas Eriksson wrote:
On 2016-03-03 18:29, Daniel D. Daugherty wrote:
> Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/
test/com/sun/jdi/RedefineAddPrivateMethod.sh
L38: System.out.println("@1 breakpoint");
L39: System.out.println("@2
On 2016-03-03 18:29, Daniel D. Daugherty wrote:
> Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/
test/com/sun/jdi/RedefineAddPrivateMethod.sh
L38: System.out.println("@1 breakpoint");
L39: System.out.println("@2 breakpoint");
With these tests, thi
> Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/
test/com/sun/jdi/RedefineAddPrivateMethod.sh
L38: System.out.println("@1 breakpoint");
L39: System.out.println("@2 breakpoint");
With these tests, this is usually done like this:
System.out.pr
Yasumasa,
91 s/perfromance/performance/
Test:
146 launch("compiler detected.", "jsnap");
Please, choose expectedMessage carefully, I'm not sure "compiler
detected." is an appropriate one.
-Dmitry
On 2016-03-03 18:45, Yasumasa Suenaga wrote:
> Hi Dmitry,
>
> Thank you for your comme
Thanks Serguei.
I'll go ahead and push this now, since I believe this change is small
enough.
- Andreas
On 2016-03-03 17:54, serguei.spit...@oracle.com wrote:
Hi Andreas,
Good++
Thanks,
Serguei
On 3/3/16 06:35, Dmitry Samersoff wrote:
Andreas,
Looks good for me.
-Dmitry
On 2016-03-03
Hi Andreas,
Good++
Thanks,
Serguei
On 3/3/16 06:35, Dmitry Samersoff wrote:
Andreas,
Looks good for me.
-Dmitry
On 2016-03-03 17:05, Andreas Eriksson wrote:
Hi,
Can I please have a review of this fix for
8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently
https://bugs.o
Hi,
Please review the new code changes for this bug. I have removed " fstat()"
call which seems not safe to read the "/proc/map/self" file and have made some
other changes too. Please find the latest code in below link
Webrev link: http://cr.openjdk.java.net/~csahu/8146683/webrev.01/
Regards
Hi Dmitry,
Thank you for your comment.
I uploaded new webrev:
hotspot: http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.01/hotspot/
jdk: http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.01/jdk/
Could you review again?
Thanks,
Yasumasa
On 2016/03/04 0:15, Dmitry Samers
Thanks.
- Andreas
On 2016-03-03 15:35, Dmitry Samersoff wrote:
Andreas,
Looks good for me.
-Dmitry
On 2016-03-03 17:05, Andreas Eriksson wrote:
Hi,
Can I please have a review of this fix for
8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently
https://bugs.openjdk.java.net
Yasumasa,
It's better (with upcoming changes for JDK-8148659 in mind) to create a
separate
private static boolean jsnapHelp() {
System.out.println(" \tdump perfromance counters");
return commonHelp();
}
and write:
System.out.println(" jsnap --help\tto get more information");
Please also
Hi Dmitry,
> Overall direction is to support jhsdb as the only entry point for SA and
> all coredump related staff.
I'm working on another issue (JDK-8151181) for it.
http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-March/019007.html
After that, I will work for this issue (JDK-8
Hi all,
JSnap is useful SA tool to check PerfCounter.
So I want to add it to jhsdb.
http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.00/
Could you review it?
Thanks,
Yasumasa
Andreas,
Looks good for me.
-Dmitry
On 2016-03-03 17:05, Andreas Eriksson wrote:
> Hi,
>
> Can I please have a review of this fix for
> 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently
> https://bugs.openjdk.java.net/browse/JDK-8151064
>
> Webrev: http://cr.openjdk.java.ne
Hi,
Can I please have a review of this fix for
8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently
https://bugs.openjdk.java.net/browse/JDK-8151064
Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/
Still not sure why it only fails sometimes, but after this change th
Yasumasa,
Overall direction is to support jhsdb as the only entry point for SA and
all coredump related staff.
Could you move JSnap "into jhsdb".
And this change requires CCC approval (I'll file it for you)
-Dmitry
On 2016-01-30 18:48, Yasumasa Suenaga wrote:
> I want to add -a (all) option to
Hi all,
I've uploaded PoC of PerfCounter for STW phase in concurrent GC:
hotspot: http://cr.openjdk.java.net/~ysuenaga/perfcounter-for-cgc/hotspot/
jdk: http://cr.openjdk.java.net/~ysuenaga/perfcounter-for-cgc/jdk/
These patches makes new jstat column CGC and CGCT as below:
Thanks Dmitry for noticing this - I am running slowdebug so I didn't see that.
Thanks again.
Markus
From: Dmitry Dmitriev
Sent: den 3 mars 2016 12:23
To: Markus Gronlund; serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8151100: Test
java/lang/instrument/NativeMethodPrefixA
Hello Markus,
CheckIntrinsics is a diagnostic flag. I think you need to add
-XX:+UnlockDiagnosticVMOptions before it because otherwise test will
fail on product build.
Thanks,
Dmitry
On 03.03.2016 3:15, Markus Gronlund wrote:
Greetings,
Could a please ask for reviews for the following sim
Thank you Serguei!
Markus
From: Serguei Spitsyn
Sent: den 3 mars 2016 10:18
To: Markus Gronlund; serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8151100: Test
java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do
CheckIntrinsics
Hi Markus,
The fix looks go
Hi Markus,
The fix looks good.
Thanks,
Serguei
On 3/2/16 16:15, Markus Gronlund wrote:
Greetings,
Could a please ask for reviews for the following simple fix to resolve
a test issue associated with
test/java/lang/instrument/NativeMethodPrefixAgent.java
Bug: https://bugs.openjdk.java.net
Thanks Bengt!
/Robbin
On 03/03/2016 09:35 AM, Bengt Rutisson wrote:
Hi Robbin,
On 2016-03-03 07:41, Robbin Ehn wrote:
Hi,
Could someone else also please review this?
On 02/29/2016 11:22 AM, Marcus Larsson wrote:
Hi Robbin,
On 02/18/2016 08:37 PM, Robbin Ehn wrote:
Hi, please review.
Th
Hi Robbin,
On 2016-03-03 07:41, Robbin Ehn wrote:
Hi,
Could someone else also please review this?
On 02/29/2016 11:22 AM, Marcus Larsson wrote:
Hi Robbin,
On 02/18/2016 08:37 PM, Robbin Ehn wrote:
Hi, please review.
This adds a write method to the UL log which takes the level as
parameter
23 matches
Mail list logo
