Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread serguei.spit...@oracle.com
Hi Christian, I understand that. Will do my best to achieve this. There are some corner cases however. Thanks, Serguei On 6/21/16 10:06, Christian Tornqvist wrote: Hi Serguei, >Will check if this works well in this case. >The unique error messages are already printed in the native code. Y

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-21 Thread Yasumasa Suenaga
2016/06/22 9:48 "David Holmes" : > > On 22/06/2016 9:37 AM, Yasumasa Suenaga wrote: >> >> PING: Could you review it? >> BTW, should I add jdk9-fc-request label to JBS? > > > Yes this enhancement will need approval. Please add the label and other information as outlined here: > > http://mail.openjd

Re: RFR: 8159959: Quarantine the test java/lang/management/MemoryMXBean/Pending.java

2016-06-21 Thread David Holmes
Alexander, This should also be used to quarantine java/lang/management/MemoryMXBean/PendingAllGC.sh See - https://bugs.openjdk.java.net/browse/JDK-8158760 David On 22/06/2016 10:59 AM, David Holmes wrote: Looks good. Thanks, David On 21/06/2016 8:59 PM, Alexander Kulyakhtin wrote: Hi, Co

Re: RFR: 8159959: Quarantine the test java/lang/management/MemoryMXBean/Pending.java

2016-06-21 Thread David Holmes
Looks good. Thanks, David On 21/06/2016 8:59 PM, Alexander Kulyakhtin wrote: Hi, Could I, please, have a review of this trivial change (quarantining 1 test): CR: https://bugs.openjdk.java.net/browse/JDK-8159959 "Quarantine java/lang/management/MemoryMXBean/Pending.java" Webrev: http://cr.op

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-21 Thread David Holmes
On 22/06/2016 9:37 AM, Yasumasa Suenaga wrote: PING: Could you review it? BTW, should I add jdk9-fc-request label to JBS? Yes this enhancement will need approval. Please add the label and other information as outlined here: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-June/004443.ht

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

2016-06-21 Thread David Holmes
On 22/06/2016 9:40 AM, Yasumasa Suenaga wrote: Hi all, Can I add jdk9-fc-request label to JBS? Bug fixes do not need approval only enhancements. David - This changes has not been reviewed yet. Thanks, Yasumasa 2016/03/22 21:24 "Yasumasa Suenaga" mailto:yasue...@gmail.com>>: PIN

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

2016-06-21 Thread Yasumasa Suenaga
Hi all, Can I add jdk9-fc-request label to JBS? This changes has not been reviewed yet. Thanks, Yasumasa 2016/03/22 21:24 "Yasumasa Suenaga" : > PING: Could you review it? > > Yasumasa > 2016/03/14 23:39 "Yasumasa Suenaga" : > >> Hi all, >> >> When I use `jhsdb jsnap` to get PerfCounter from co

PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-21 Thread Yasumasa Suenaga
PING: Could you review it? BTW, should I add jdk9-fc-request label to JBS? Thanks, Yasumasa 2016/06/13 13:24 "David Holmes" : > Hi Yasumasa, > > On 13/06/2016 1:45 PM, Yasumasa Suenaga wrote: > >> Hi David, >> >> Thank you for your comment. >> >> So options are a distinct property of outputs an

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread Andrew Dinn
On 21/06/16 10:54, serguei.spit...@oracle.com wrote: > > Please, review the Jigsaw fix for the enhancement: > https://bugs.openjdk.java.net/browse/JDK-8159145 > > > The Hotspot webrev: > http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.1/ > > > The

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-06-21 Thread Kevin Walls
Hi Vladimir - that's great, thanks for letting us know. I'll get it pushed. Kevin On 21/06/2016 17:36, Vladimir Kozlov wrote: This RFE is approved for push. Thanks, Vladimir On 5/24/16 9:46 AM, Kevin Walls wrote: ...although we consider this a fix, more than a feature, and hope it isn't

RE: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread Christian Tornqvist
Hi Serguei, >Will check if this works well in this case. >The unique error messages are already printed in the native code. Yes, they’re printed on stdout/stderr but the test will fail with a “Test failed” exception and our failure matching system wouldn’t be able to tell why it failed.

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-06-21 Thread Vladimir Kozlov
This RFE is approved for push. Thanks, Vladimir On 5/24/16 9:46 AM, Kevin Walls wrote: ...although we consider this a fix, more than a feature, and hope it isn't excluded from being pushed. --- Kevin On 24/05/2016 17:24, Gerard Ziemski wrote: hi Cheleswer, The change looks good. My und

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread serguei.spit...@oracle.com
Hi Alan, Thank you for the review! I'll implement all your suggestions. Thanks, Serguei On 6/21/16 04:56, Alan Bateman wrote: On 21/06/2016 11:48, serguei.spit...@oracle.com wrote: Sorry. My initial plan was to write an nsk.jvmti test and review it on a confidential mailing list. It is

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread serguei.spit...@oracle.com
Hi Christian, Thank you for looking at it! On 6/21/16 04:56, Christian Tornqvist wrote: Hi Serguei, I’ve only looked at the test code so far, here are some comments: * You’re not allowed to call System.exit in a jtreg test. If something fails, you need to throw an exception. Ok, an exc

Re: RFR:8153978:New test to verify the modules info as returned by the JVMTI

2016-06-21 Thread serguei.spit...@oracle.com
Hi Christian, Ok, thanks! Serguei On 6/21/16 05:11, Christian Tornqvist wrote: Hi Serguei, Yes, this is path is set in the make files/scripts that run jtreg. Thanks, Christian *From:*serguei.spit...@oracle.com [mailto:serguei.spit...@oracle.com] *Sent:* Tuesday, June 21, 2016 5:39 AM *To:

Re: [7u] RFR: JDK-6626412: jstack using SA prints some info messages into err stream

2016-06-21 Thread Seán Coffey
Do we really need to fix this in JDK 7u ? It's a P4 that brings behavioural change to a JDK release that well mature now. It could introduce issues for tooling that might be seperating out the stdout and stderr streams. 'java -version' also prints to the err stream :-D Regards, Sean. On 21/0

RE: RFR:8153978:New test to verify the modules info as returned by the JVMTI

2016-06-21 Thread Christian Tornqvist
Hi Serguei, Yes, this is path is set in the make files/scripts that run jtreg. Thanks, Christian From: serguei.spit...@oracle.com [mailto:serguei.spit...@oracle.com] Sent: Tuesday, June 21, 2016 5:39 AM To: Christian Tornqvist ; 'Alexander Kulyakhtin' Cc: serviceability-dev@openjdk

RE: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread Christian Tornqvist
Hi Serguei, I’ve only looked at the test code so far, here are some comments: * You’re not allowed to call System.exit in a jtreg test. If something fails, you need to throw an exception. * Instead of a run() method you could simply collapse all this into the main method like this: a

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread Alan Bateman
On 21/06/2016 11:48, serguei.spit...@oracle.com wrote: Sorry. My initial plan was to write an nsk.jvmti test and review it on a confidential mailing list. It is why I put the webrevs on the non-public server. Forgot to switch the server when the test was converted into the jtreg format. T

RFR: 8159959: Quarantine the test java/lang/management/MemoryMXBean/Pending.java

2016-06-21 Thread Alexander Kulyakhtin
Hi, Could I, please, have a review of this trivial change (quarantining 1 test): CR: https://bugs.openjdk.java.net/browse/JDK-8159959 "Quarantine java/lang/management/MemoryMXBean/Pending.java" Webrev: http://cr.openjdk.java.net/~akulyakh/8159959/test/ProblemList.txt.udiff.html Best regards, A

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread serguei.spit...@oracle.com
Hi Andrew, Please, find the public webrevs in my reply to Alan. Thanks, Serguei On 6/21/16 03:19, Andrew Dinn wrote: On 21/06/16 10:54, serguei.spit...@oracle.com wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159145 The Hotspot webre

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread serguei.spit...@oracle.com
On 6/21/16 03:23, Alan Bateman wrote: On 21/06/2016 10:54, serguei.spit...@oracle.com wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159145 The Hotspot webrev: http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2016/hotspot/8159145-ji

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread Alan Bateman
On 21/06/2016 10:54, serguei.spit...@oracle.com wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159145 The Hotspot webrev: http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.1/ The Jdk webrev: http:

Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

2016-06-21 Thread serguei.spit...@oracle.com
Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159145 The Hotspot webrev: http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.1/ The Jdk webrev: http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2016/ho

Re: RFR:8153978:New test to verify the modules info as returned by the JVMTI

2016-06-21 Thread serguei.spit...@oracle.com
On 6/21/16 01:54, serguei.spit...@oracle.com wrote: Ok, I've found how to work around my problem below. The flag -nativepath needs to be passed to the jtreg: -nativepath:/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/test/hotspot/jtreg/native Question: Is this flag

RE: [7u] RFR: JDK-6626412: jstack using SA prints some info messages into err stream

2016-06-21 Thread Fairoz Matte
PING Someone could please review this, It is back port to 7. Only modification is changing info messages from err string - PrintStream err = System.err; + PrintStream out = System.out; And respective err to out in single file Thanks, Fairoz > -Original Message- > From: F

Re: RFR:8153978:New test to verify the modules info as returned by the JVMTI

2016-06-21 Thread serguei.spit...@oracle.com
Ok, I've found how to work around my problem below. The flag -nativepath needs to be passed to the jtreg: -nativepath:/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/test/hotspot/jtreg/native Thanks, Serguei On 6/21/16 00:46, serguei.spit...@oracle.com wrote: Hi Chris

Re: RFR:8153978:New test to verify the modules info as returned by the JVMTI

2016-06-21 Thread serguei.spit...@oracle.com
Hi Christian and Alexander, Not sure if my code is correct but I can not pass through the following agent library load error: Error occurred during initialization of VM Could not find agent library GetModuleByPkgTest1 on the library path, with error: libGetModuleByPkgTest1.so: cannot