Hi,
> On Dec 18, 2017, at 9:11 PM, gary.ad...@oracle.com wrote:
>
> The only legitimate reason libinstrument would be missing is if
> java.instrument was not included.
> Any other speculation about why libinstrument was not found is hard to
> explain. e.g. until
> the vm is initialized we can n
On 12/14/17 9:42 PM, David Buck wrote:
Hi!
May I please get a review of the following very simple backport of
this serviceability improvement to JDK 8?
:
JDK 8 backport webrevs for review:
http://cr.openjdk.java.net/~dbuck/8059036.0_jdk8/
This patch looks okay to me.
Mandy
Hi!
Any love out there for my review request?
Cheers,
-Buck
On 2017/12/15 14:42, David Buck wrote:
Hi!
May I please get a review of the following very simple backport of this
serviceability improvement to JDK 8?
The two hotspot jtreg test cases needed to be modified slightly because
of th
On 12/18/17 1:22 PM, gary.ad...@oracle.com wrote:
On 12/18/17 2:26 PM, Chris Plummer wrote:
Hi Gary,
On 12/18/17 6:47 AM, Gary Adams wrote:
Here's a simple fix to correct the error message when the java_pid
socket
is not found. The code previously reported the attach_pid file name
rather than
Yes.
On 12/18/17 1:14 PM, gary.ad...@oracle.com wrote:
I can just the error message.
What would you like it to say?
"Module java.instrument may be missing"
On 12/18/17 4:09 PM, serguei.spit...@oracle.com wrote:
Hi Gary,
I have the same concern and like Chris's suggestion.
The JMX case must
On 12/18/17 2:26 PM, Chris Plummer wrote:
Hi Gary,
On 12/18/17 6:47 AM, Gary Adams wrote:
Here's a simple fix to correct the error message when the java_pid
socket
is not found. The code previously reported the attach_pid file name
rather than the socket file name that was not found.
Issue:
On 12/18/17 13:14, gary.ad...@oracle.com wrote:
I can just the error message.
What would you like it to say?
"Module java.instrument may be missing"
Looks good to me (assuming it is for the sub_msg2).
Thanks,
Serguei
On 12/18/17 4:09 PM, serguei.spit...@oracle.com wrote:
Hi Gary,
I have
I can just the error message.
What would you like it to say?
"Module java.instrument may be missing"
On 12/18/17 4:09 PM, serguei.spit...@oracle.com wrote:
Hi Gary,
I have the same concern and like Chris's suggestion.
The JMX case must be simpler as there is no need to load the agent
library
The only legitimate reason libinstrument would be missing is if
java.instrument was not included.
Any other speculation about why libinstrument was not found is hard to
explain. e.g. until
the vm is initialized we can not explicitly say whether java.instrument
module is present or not.
On 12/
Hi Gary,
I have the same concern and like Chris's suggestion.
The JMX case must be simpler as there is no need to load the agent
library early at startup.
So that it is possible to identify the module jdk.management.agent is
absent in the image.
I think, it happens in the java.lang.Module.Res
Hi Gary,
Overall looks good. There's one minor change you might wanted to
consider. It's possible the library failed to load for reasons other
than java.instrument not being included. I see the error output already
includes the error message from the failed dll_open() call, so why not
just su
Hi Gary,
On 12/18/17 6:47 AM, Gary Adams wrote:
Here's a simple fix to correct the error message when the java_pid socket
is not found. The code previously reported the attach_pid file name
rather than the socket file name that was not found.
Issue: https://bugs.openjdk.java.net/browse/JDK-81
Hi Gary,
It looks good to me.
Thanks,
Serguei
On 12/18/17 06:47, Gary Adams wrote:
Here's a simple fix to correct the error message when the java_pid socket
is not found. The code previously reported the attach_pid file name
rather than the socket file name that was not found.
Issue: https
Hi,
I had to update my webrev after the javah launcher had been removed:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.07/
I would appreciate a final decision to push this.
Best regards,
Goetz.
-Original Message-
From: serviceability-dev [mailto:serviceability-dev
On 18/12/2017 14:38, Gary Adams wrote:
Here's a simple fix to include additional information when the
instrument library is
missing from the jre and the command line requests -javaagent.
Issue: https://bugs.openjdk.java.net/browse/JDK-8180709
Webrev: http://cr.openjdk.java.net/~gadams/8180709
Here's a simple fix to correct the error message when the java_pid socket
is not found. The code previously reported the attach_pid file name
rather than the socket file name that was not found.
Issue: https://bugs.openjdk.java.net/browse/JDK-8188856
Webrev: http://cr.openjdk.java.net/~gadams
Here's a simple fix to include additional information when the
instrument library is
missing from the jre and the command line requests -javaagent.
Issue: https://bugs.openjdk.java.net/browse/JDK-8180709
Webrev: http://cr.openjdk.java.net/~gadams/8180709/webrev.00/
17 matches
Mail list logo
