Re: RFR(M): 8201375: Add the AllowArchivingWithJavaAgent diagnostic vm option to allow the use of the -javaagent option during CDS dumping

On 11/15/18 22:39, serguei.spit...@oracle.com wrote: Hi Calvin, It seems the option name AllowArchivingWithJavaAgent is not right. In fact, it is about JVMTI (native) agents: // Create agents for -agentlib: -agent

Re: RFR(M): 8201375: Add the AllowArchivingWithJavaAgent diagnostic vm option to allow the use of the -javaagent option during CDS dumping

Hi Calvin, It seems the option name AllowArchivingWithJavaAgent is not right. In fact, it is about JVMTI (native) agents: // Create agents for -agentlib: -agentpath: and converted -Xrun // Invokes Agent_OnLoad // Called very early -- before JavaThr

Re: RFR(XXS): 8213902: com/sun/jdi/SetLocalWhileThreadInNative.java times out

See https://bugs.openjdk.java.net/browse/JDK-8173304 and also https://bugs.openjdk.java.net/browse/JDK-4368399, which dates back to 2000. Chris On 11/15/18 8:40 PM, David Holmes wrote: Hi Jc, If I may put in my 2c ... On 16/11/2018 2:13 pm, JC Beyler wrote: Hi Richard, Is this not a test t

Re: RFR(XXS): 8213902: com/sun/jdi/SetLocalWhileThreadInNative.java times out

Hi Richard, I think your test is misusing @driver. If you want to pass -XX args you should be using "@run main/othervm" Otherwise turning off the Print* flags seems reasonable, but removing Xcomp as well seems unnecessary. Cheers, David On 16/11/2018 8:32 am, Reingruber, Richard wrote: Hi

Re: RFR(XXS): 8213902: com/sun/jdi/SetLocalWhileThreadInNative.java times out

Hi Jc, If I may put in my 2c ... On 16/11/2018 2:13 pm, JC Beyler wrote: Hi Richard, Is this not a test that's failing due to a real bug? Ie: if someone were to really be running the program in this configuration (with printcompilation and printinlining) and attaching a debugger, would they

Re: RFR (S) 8212931 HeapMonitorStatIntervalTest.java fails due average calculation

LGTM --alex On 11/15/2018 08:27, JC Beyler wrote: Thanks Serguei, I fixed that in my local version, could I get a second review from someone? Thanks, Jc On Sat, Nov 10, 2018 at 3:24 PM serguei.spit...@oracle.com > wrote:

Re: [8u] RFR: 8212110: Build of saproc.dll broken on Windows 32 bit after JDK-8210647

Hi Severin On 11/15/2018 07:39 PM, Erik Joelsson wrote: Looks good to me. /Erik On 2018-11-15 11:31, Severin Gehwolf wrote: Hi, When the SA optimization fix got backported to JDK 11 a build issue on Windows 32 bit was discovered by SAP. This would be the JDK 8 equivalent for the old build sy

Re: RFR(M): 8201375: Add the AllowArchivingWithJavaAgent diagnostic vm option to allow the use of the -javaagent option during CDS dumping

Thanks for the review, Ioi and Jiangli. Calvin On 11/15/18, 10:56 AM, Jiangli Zhou wrote: +1 Adding serviceability-dev mailing list. It would be good to have this reviewed by the JVMTI experts also to make sure all cases are covered. Thanks, Jiangli On 11/15/18 9:29 AM, Ioi Lam wrote: H

RFR(XXS): 8213902: com/sun/jdi/SetLocalWhileThreadInNative.java times out

Hi, could I please get reviews for the following small patch? It fixes a bug in the test com/sun/jdi/SetLocalWhileThreadInNative.java that causes a deadlock when executed with -vmoption:-Xcomp. Deadlock: Debuggee (SetLocalWhileThreadInNativeTarget): - running with -Xcomp - still in early s

Re: Proposal: Always-on Statistical History

This was true up until Oracle open sourced it (JDK 11). If JFR is the framework around which we decide to get these types of metrics from the JVM (in addition to JMX), then I think that we (the community) should continue to build out JFR adding in those metrics that are not already captured. K

Re: [8u] RFR: 8212110: Build of saproc.dll broken on Windows 32 bit after JDK-8210647

Looks good to me. /Erik On 2018-11-15 11:31, Severin Gehwolf wrote: Hi, When the SA optimization fix got backported to JDK 11 a build issue on Windows 32 bit was discovered by SAP. This would be the JDK 8 equivalent for the old build system. Note that the JDK 8 build still uses GZ which is dep

[8u] RFR: 8212110: Build of saproc.dll broken on Windows 32 bit after JDK-8210647

Hi, When the SA optimization fix got backported to JDK 11 a build issue on Windows 32 bit was discovered by SAP. This would be the JDK 8 equivalent for the old build system. Note that the JDK 8 build still uses GZ which is deprecated since at least Visual Studio 2012[1]. So I've replaced it with R

Re: RFR(M): 8201375: Add the AllowArchivingWithJavaAgent diagnostic vm option to allow the use of the -javaagent option during CDS dumping

+1 Adding serviceability-dev mailing list. It would be good to have this reviewed by the JVMTI experts also to make sure all cases are covered. Thanks, Jiangli On 11/15/18 9:29 AM, Ioi Lam wrote: Hi Calvin, The changes look good. Thanks - Ioi On 11/14/18 4:40 PM, Calvin Cheung wrote:

Re: Proposal: Always-on Statistical History

I agree with the others, and Flight Recorder is actually open sourced so the restrictions you mentioned don’t apply anymore since Java 11. That said, I want to study the proposal more, there may be something worth exploring that may be integrated in the current infrastructure. Cheers, Mario —

Re: Proposal: Always-on Statistical History

Hi all, I'm with Roger on this one. This is an aggregation mechanism. If we want such an aggregation mechanism, we should probably build one into one of the already available serviceability technologies (JMX and/or JFR). If we feel the need to introduce a generic one that can source data from m

Re: Proposal: Always-on Statistical History

JDK Flight Recorder is free, open sourced and part of OpenJDK 11+. Kind regards, Marcus From: serviceability-dev on behalf of Simon Roberts Date: Thursday, 15 November 2018 at 18:10 To: Cc: Subject: Re: Proposal: Always-on Statistical History I don't begin to claim to know the poli

Re: Proposal: Always-on Statistical History

I don't begin to claim to know the politics, legalities, boundaries of JFR license conditionsm and so forth" but: Java Flight Recorder requires a commercial license for use in production." Whereas, this as I understand is the *open* jdk list. So, I for one would feel hard done by if your view pre

Re: [8u] RFR: 8210647: libsaproc is being compiled without optimization

Looks ok to me. /Erik On 2018-11-15 06:57, Severin Gehwolf wrote: Hi, Could I please get reviews for this 8u backport of JDK-8210647. Since the build system is different in 8, the patch looks different. For the Windows build changes I've refactored the make file a bit so as to facilitate passi

Re: [8u] RFR: 8210647: libsaproc is being compiled without optimization

Hi JC, On Thu, 2018-11-15 at 08:37 -0800, JC Beyler wrote: > Hi Severin, > > That does look different ( > http://hg.openjdk.java.net/jdk/jdk/rev/c608b2190460) :) > > It looks good to me :), Thanks for the review! Cheers, Severin > Jc > > On Thu, Nov 15, 2018 at 6:58 AM Severin Gehwolf > wro

Re: Proposal: Always-on Statistical History

Hi, This looks like it has significant overlap with JFR. I don't think we want to start building in multiple mechanisms to keep tabs on a running VM. $.02, Roger On 11/14/2018 04:27 PM, Thomas Stüfe wrote: Hi Bernd, On Wed, Nov 14, 2018 at 10:07 PM Bernd Eckenfels wrote: Looks good Thoma

Re: [8u] RFR: 8210647: libsaproc is being compiled without optimization

Hi Severin, That does look different ( http://hg.openjdk.java.net/jdk/jdk/rev/c608b2190460) :) It looks good to me :), Jc On Thu, Nov 15, 2018 at 6:58 AM Severin Gehwolf wrote: > Hi, > > Could I please get reviews for this 8u backport of JDK-8210647. Since > the build system is different in 8,

Re: RFR: JDK-8213916: no copyright in signature.html

Hi Gary, +LGTM Thanks, Serguei On 11/15/18 08:01, Roger Riggs wrote: Looks fine,  Roger On 11/15/2018 09:41 AM, JC Beyler wrote: Hi Gary, Looks good to me (not a reviewer though), Jc On Thu, Nov 15, 2018 at 5:45 AM Gary Adams > wrote:     Here's a quick fix

Re: RFR (S) 8212931 HeapMonitorStatIntervalTest.java fails due average calculation

Thanks Serguei, I fixed that in my local version, could I get a second review from someone? Thanks, Jc On Sat, Nov 10, 2018 at 3:24 PM serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Hi Jc, > > Looks good. > > One minor comment. > > > http://cr.openjdk.java.net/%7Ejcbeyler/8212

Re: RFR: JDK-8213916: no copyright in signature.html

Looks fine,  Roger On 11/15/2018 09:41 AM, JC Beyler wrote: Hi Gary, Looks good to me (not a reviewer though), Jc On Thu, Nov 15, 2018 at 5:45 AM Gary Adams > wrote: Here's a quick fix to add a missing copyright to signature.html. diff --git a/src/

[8u] RFR: 8210647: libsaproc is being compiled without optimization

Hi, Could I please get reviews for this 8u backport of JDK-8210647. Since the build system is different in 8, the patch looks different. For the Windows build changes I've refactored the make file a bit so as to facilitate passing opt flags to the compiler. Bug: https://bugs.openjdk.java.net/brow

Re: RFR: JDK-8213916: no copyright in signature.html

Hi Gary, Looks good to me (not a reviewer though), Jc On Thu, Nov 15, 2018 at 5:45 AM Gary Adams wrote: > Here's a quick fix to add a missing copyright to signature.html. > > > diff --git > a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html > b/src/jdk.jdi/share/classes/com/sun/jd

RFR: JDK-8213916: no copyright in signature.html

Here's a quick fix to add a missing copyright to signature.html. diff --git a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html --- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html +++ b/src/jdk.jdi/