Hi all,
Anybody motivated to review this? :)
Jc
On Wed, Nov 7, 2018 at 9:53 PM JC Beyler wrote:
> Hi all,
>
> Could I have a review for the extension and usage of the
> ExceptionJniWrapper. This adds lines and filenames to the end of the
> wrapper JNI methods, adds tracing, and throws an error
Thanks, Serguei!
Calvin
On 11/16/18, 3:22 PM, serguei.spit...@oracle.com wrote:
Hi Calvin,
It looks good to me.
No need in new webrev if you update this comment as below.
Thanks,
Serguei
On 11/16/18 2:00 PM, Calvin Cheung wrote:
On 11/16/18, 1:04 PM, serguei.spit...@oracle.com wrote:
Hi Calvin,
It looks good to me.
No need in new webrev if you update this comment as below.
Thanks,
Serguei
On 11/16/18 2:00 PM, Calvin Cheung wrote:
On 11/16/18, 1:04 PM, serguei.spit...@oracle.com wrote:
Hi Calvin,
It looks good in general.
New comment does not help much:
1362 //
Hi Richard,
I'll sponsor this over the weekend.
Thanks,
David
On 17/11/2018 1:37 am, Reingruber, Richard wrote:
Hi Jc, David, Chris,
>> Is this not a test that's failing due to a real bug?
I would not consider this a bug, but rather a limitation. I don't see a way to
work around it in
On 17/11/2018 1:32 am, Reingruber, Richard wrote:
Hi David,
I would like to pass -XX args mainly to the debuggee which is launched by
SetLocalWhileThreadInNative. There's no need to run SetLocalWhileThreadInNative
in another vm.
Sorry Richard I misread the driver line and didn't notice that
On 11/16/18, 1:04 PM, serguei.spit...@oracle.com wrote:
Hi Calvin,
It looks good in general.
New comment does not help much:
1362 // Java agents are allowed during run time. Therefore, the following
condition is not
1363 // checked: !_allow_archiving_with_java_agent&&
Hi Calvin,
It looks good in general.
New comment does not help much:
1362 // Java agents are allowed during run time. Therefore, the
following condition is not
1363 // checked: !_allow_archiving_with_java_agent &&
AllowArchivingWithJavaAgent
1364 if (_allow_archiving_with_java_agent &&
Hi Serguei,
I've updated the webrev based on your suggestions:
http://cr.openjdk.java.net/~ccheung/8201375/webrev.01/
Files changed since last time:
thead.cpp - your suggestion below
filemap.cpp - added a comment
DumpWithJavaAgent.java - some @ tag cleanup
DumpWithJvmtiAgent.java - some @
On 11/16/18 10:41,
serguei.spit...@oracle.com wrote:
Hi Ioi,
Thank you for the clarifications!
But then I have one more question to the fix in webrev.
On 11/16/18 2:01 PM, Ioi Lam wrote:
On 11/16/18 10:52 AM, Daniel D. Daugherty wrote:
On 11/16/18 1:18 PM, Ioi Lam wrote:
On 11/16/18 9:45 AM, serguei.spit...@oracle.com wrote:
Hi Calvin,
On 11/16/18 09:26, Calvin Cheung wrote:
Serguei, Dan,
Thanks for taking a look.
I think the option
On 11/16/18 10:52 AM, Daniel D. Daugherty wrote:
On 11/16/18 1:18 PM, Ioi Lam wrote:
On 11/16/18 9:45 AM, serguei.spit...@oracle.com wrote:
Hi Calvin,
On 11/16/18 09:26, Calvin Cheung wrote:
Serguei, Dan,
Thanks for taking a look.
I think the option name is correct but the comment for
On 11/16/18 10:52, Daniel D. Daugherty
wrote:
On
11/16/18 1:18 PM, Ioi Lam wrote:
On 11/16/18 9:45 AM, serguei.spit...@oracle.com wrote:
Hi Calvin,
On 11/16/18 09:26, Calvin
On 11/16/18 1:18 PM, Ioi Lam wrote:
On 11/16/18 9:45 AM, serguei.spit...@oracle.com wrote:
Hi Calvin,
On 11/16/18 09:26, Calvin Cheung wrote:
Serguei, Dan,
Thanks for taking a look.
I think the option name is correct but the comment for
Threads::create_vm_init_agents() is incorrect as I
Hi Ioi,
Thank you for the clarifications!
But then I have one more question to the fix in webrev.
http://cr.openjdk.java.net/%7Eccheung/8201375/webrev.00/src/hotspot/share/runtime/thread.cpp.udiff.html
// Create agents for -agentlib: -agentpath:
On 11/16/18 9:45 AM, serguei.spit...@oracle.com wrote:
Hi Calvin,
On 11/16/18 09:26, Calvin Cheung wrote:
Serguei, Dan,
Thanks for taking a look.
I think the option name is correct but the comment for
Threads::create_vm_init_agents() is incorrect as I believe it will
start both Java
'AllowArchivingWithAgent' is also one of the earlier suggested naming (I
voted for it :)). I think it servers the purpose better. We mainly want
a diagnosis flag that allows us to use a JVMTI agent at CDS dump time
for testing purpose only. Even for the 'allowed' usage, it may not have
a
Hi Calvin,
On 11/16/18 09:26, Calvin Cheung wrote:
Serguei, Dan,
Thanks for taking a look.
I think the option name is correct but the comment for
Threads::create_vm_init_agents() is incorrect as I believe it will
start both Java native agents. Otherwise, my new tests won't work.
It works
Serguei, Dan,
Thanks for taking a look.
I think the option name is correct but the comment for
Threads::create_vm_init_agents() is incorrect as I believe it will start
both Java native agents. Otherwise, my new tests won't work.
Below is my understanding:
In thread.cpp:
3697 if
Hi Jc, David, Chris,
>> Is this not a test that's failing due to a real bug?
I would not consider this a bug, but rather a limitation. I don't see a way to
work around it in the TestScaffold, though (looking at [1]).
So an enhancement would have to happen in the jdi implementation. To me it
Hi David,
I would like to pass -XX args mainly to the debuggee which is launched by
SetLocalWhileThreadInNative. There's no need to run SetLocalWhileThreadInNative
in another vm.
Do you think this is a misuse?
Thanks for looking at the patch,
Richard.
-Original Message-
From: David
> The flags -agentlib and -agentpath are to run JVMTI (native) agents,
> and Agent_OnLoad is an entrypoint in native agent library.
The '-agentlib' and '-agentpath' options are used to load and execute
a native library via the Agent_OnLoad() entry point. However, the
agent does not have to use
On Fri, 2018-11-16 at 12:14 +, Alex Kashchenko wrote:
> > > In this line:
> > >
> > > SA_CFLAGS = $(SA_CFLAGS) -ZI
> > >
> > > "ZI" should be changed to "Zi", otherwise it fails on fastdebug and
> > > release (not compatible with O2).
> >
> > Nice catch! How about this?
> >
> >
On 11/16/2018 08:53 AM, Severin Gehwolf wrote:
Hi Alex,
Hi Alex,
On Fri, 2018-11-16 at 00:32 +, Alex Kashchenko wrote:
Hi Severin
On 11/15/2018 07:39 PM, Erik Joelsson wrote:
Looks good to me.
/Erik
On 2018-11-15 11:31, Severin Gehwolf wrote:
Hi,
When the SA optimization fix got
On Tue, 2018-11-13 at 09:28 +0100, Severin Gehwolf wrote:
> On Tue, 2018-11-13 at 10:46 +0530, Jini George wrote:
> > Looks good to me, Severin.
>
> Thanks for the review!
>
> I believe I still need a review from a JDK 8u Reviewer:
> http://openjdk.java.net/census#jdk8u
Any JDK 8u Reviewer
Hi Alex,
Hi Alex,
On Fri, 2018-11-16 at 00:32 +, Alex Kashchenko wrote:
> Hi Severin
>
> On 11/15/2018 07:39 PM, Erik Joelsson wrote:
> > Looks good to me.
> >
> > /Erik
> >
> > On 2018-11-15 11:31, Severin Gehwolf wrote:
> > > Hi,
> > >
> > > When the SA optimization fix got backported
25 matches
Mail list logo
