Re: RFR: 8170299: Debugger does not stop inside the low memory notifications code

2019-07-31 Thread David Holmes
Hi Daniil, On 25/07/2019 3:34 am, Daniil Titov wrote: Hi David, Hope you had a great vacation! I did thank you. Apologies again for taking so long to get back to this work. Please find below the latest version of the change . The only difference from the version 01 is the corrected order

RE: [11u] 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2019-07-31 Thread Langer, Christoph
Thank you, Daniil and Serguei. I'll look into backporting the 2 suggested items and will try to push them in one go. Best Christoph > -Original Message- > From: Daniil Titov > Sent: Mittwoch, 31. Juli 2019 11:55 > To: serguei.spit...@oracle.com; Langer, Christoph > ; jdk-updates-...@op

Re: RFR: [XS] 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms

2019-07-31 Thread David Holmes
On 1/08/2019 12:01 am, Baesken, Matthias wrote: Hi upload works again, now with webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8228658.2/ Could you please add, for diagnostic purposes: System.out.println("Total safepoint time (ms): " + value); after: 60 long value = execute

Re: [11u] 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2019-07-31 Thread serguei . spitsyn
On 7/31/19 11:55 AM, Daniil Titov wrote: I think either way is fine, but if backporting [1] and [2] separately, we need to ensure, that they will be also approved for 11u. Currently neither [1] nor [2] have jdk11u-fix-request and jdk11u-fix-yes labels. Agreed. Thanks, Serguei [1]: JDK-

Re: [11u] 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2019-07-31 Thread Daniil Titov
I think either way is fine, but if backporting [1] and [2] separately, we need to ensure, that they will be also approved for 11u. Currently neither [1] nor [2] have jdk11u-fix-request and jdk11u-fix-yes labels. [1]: JDK-8225543 - https://bugs.openjdk.java.net/browse/JDK-8225543 [2]: JDK-822

Re: [11u] 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2019-07-31 Thread serguei . spitsyn
On 7/31/19 10:32 AM, Daniil Titov wrote: Hi Christoph, There were several issues that the original change introduced. These issues were solved in [1] and [2] and they need to be included in the backport. You probably wanted to say, the 8225543 and 8221730 have to be backported as well

Re: [11u] 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2019-07-31 Thread Daniil Titov
Hi Christoph, There were several issues that the original change introduced. These issues were solved in [1] and [2] and they need to be included in the backport. [1]: JDK-8225543 - https://bugs.openjdk.java.net/browse/JDK-8225543 [2]: JDK-8221730 - https://bugs.openjdk.java.net/browse/JDK

Re: [11u] 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2019-07-31 Thread serguei.spit...@oracle.com
Hi Christoph, It looks good to me. It'd be nice if Daniil has time to look at it. Thanks, Serguei On 7/23/19 07:58, Langer, Christoph wrote: Hi, please review the backport of "8205654: serviceability/dcmd/framework/HelpTest.java timed out" to OpenJDK 11u. We're seeing the mentioned test is

Re: RFR: JDK-8227021: VM fails if any sun.boot.library.path paths are longer than JVM_MAXPATHLEN

2019-07-31 Thread serguei.spit...@oracle.com
Hi Adam, It looks Okay to me. A couple of minor comments. http://cr.openjdk.java.net/~afarley/8227021.2/webrev/src/hotspot/share/runtime/os.cpp.frames.html 1362 //release allocated storage before exiting the vm 1363 while (i > 0)

RE: RFR: [XS] 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms

2019-07-31 Thread Baesken, Matthias
Hi upload works again, now with webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8228658.2/ Best regards, Matthias > -Original Message- > From: Baesken, Matthias > Sent: Mittwoch, 31. Juli 2019 14:05 > To: 'David Holmes' ; Jean Christophe Beyler > > Cc: hotspot-...@openjdk.java.n

RE: [11u] 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2019-07-31 Thread Langer, Christoph
Ping... From: Langer, Christoph Sent: Dienstag, 23. Juli 2019 07:58 To: jdk-updates-...@openjdk.java.net Cc: OpenJDK Serviceability Subject: [11u] 8205654: serviceability/dcmd/framework/HelpTest.java timed out Hi, please review the backport of "8205654: serviceability/dcmd/framework/Help

RE: RFR: [XS] 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms

2019-07-31 Thread Baesken, Matthias
Hello, here is a version following the latest proposal of JC . Unfortunately attached as patch, sorry for that - the uploads / pushes currently do not work from here . Best regards, Matthias > -Original Message- > From: David Holmes > Sent: Mittwoch, 31. Juli 2019 05:04 > To: Jea

Re: RFR: JDK-8227021: VM fails if any sun.boot.library.path paths are longer than JVM_MAXPATHLEN

2019-07-31 Thread David Holmes
On 31/07/2019 7:01 pm, Adam Farley8 wrote: Hi All, Reviewers requested for the change below. @David - Agreed. Would you be prepared to sponsor the change? Sure I can sponsor once there is another reviewer. BTW could have dropped serviceability-dev as this no longer has any serviceability ch

Re: RFR: JDK-8227021: VM fails if any sun.boot.library.path paths are longer than JVM_MAXPATHLEN

2019-07-31 Thread Adam Farley8
Hi All, Reviewers requested for the change below. @David - Agreed. Would you be prepared to sponsor the change? Bug: https://bugs.openjdk.java.net/browse/JDK-8227021 Webrev: http://cr.openjdk.java.net/~afarley/8227021.2/webrev/ Best Regards Adam Farley IBM Runtimes P.S. Remembered to add the

Re: RFR: JDK-8227021: VM fails if any sun.boot.library.path paths are longer than JVM_MAXPATHLEN

2019-07-31 Thread Adam Farley8
Hi All, Reviewers requested for the change below. @David - Agreed. Would you be prepared to sponsor the change? Best Regards Adam Farley IBM Runtimes David Holmes wrote on 30/07/2019 03:37:53: > From: David Holmes > To: Adam Farley8 > Cc: hotspot-...@openjdk.java.net, serviceability-dev