On 03/10/2019 00:47, serguei.spit...@oracle.com wrote:
> Hi Severin,
>
> It looks good and applies cleanly.
> So, I'm not sure you really need a review for this.
>
> Thanks,
> Serguei
>
> On 10/1/19 06:01, Severin Gehwolf wrote:
>> Hi,
>>
>> Please review this OpenJDK 8u vs. Oracle JDK 8 parit
Dear All,
I want to re-activate the thread of discussion about the implementation of
parallel and incremental “Jmap -histo”.
The target of these changes is to solve the problems that “jmap -histo” may
“ timeout or killed by timer” when heap is large. And the result of “jmap
-histo” is “on
On 13/12/2019 10:56 am, Vladimir Kozlov wrote:
Yes, David
You are correct these changes touch all part of VM and may affect Graal
(which also has EA) too.
Changes should be tested in all our modes: tiered, C1 only, Graal,
Interpreter. And I realized that I only ran tier3-graal testing so I
su
Yes, David
You are correct these changes touch all part of VM and may affect Graal (which
also has EA) too.
Changes should be tested in all our modes: tiered, C1 only, Graal, Interpreter. And I realized that
I only ran tier3-graal testing so I submitted the rest of Graal's tiers now.
I had as
Hi Stefan,
It looks good to me.
Sorry, I was on the meeting, wrote this email and forgot to push 'send'
button.
Just now discovered that it has not been really sent. :(
Thanks,
Serguei
On 12/12/19 07:23, Stefan Karlsson wrote:
In the interest to get this integrated before the RDP cut-off I'
Hi Richard,
Some further queries/concerns:
src/hotspot/share/runtime/objectMonitor.cpp
Can you please explain the changes to ObjectMonitor::wait:
! _recursions = save // restore the old recursion count
! + jt->get_and_reset_relock_count_after_wait(); //
increased by the
On 13/12/2019 9:02 am, Reingruber, Richard wrote:
Hello Vladimir,
thanks for having a look.
> Use vm.compMode == "Xmixed" instead of vm.compMode != "Xcomp" to skip
> test from running in Interpreter mode too.
Done.
> You don't need vm.opt.TieredCompilation != true in @requires becaus
Hello Vladimir,
thanks for having a look.
> Use vm.compMode == "Xmixed" instead of vm.compMode != "Xcomp" to skip
> test from running in Interpreter mode too.
Done.
> You don't need vm.opt.TieredCompilation != true in @requires because you
> specified -XX:-TieredCompilation in @run comm
Hi David,
Tiered is disabled because we don't want to see compilations and outputs
from C1 compiler which does not have EA.
The test is specifically written for C2 only (not for C1 or Graal) to
verify its Escape Analysis optimization.
I did not look in great details into test's code but its a
Thanks, Dan.
StefanK
On 2019-12-12 17:06, Daniel D. Daugherty wrote:
src/hotspot/share/gc/shared/generationSpec.hpp
No comments.
test/hotspot/jtreg/serviceability/tmtools/jstat/utils/JstatGcCapacityResults.java
No comments.
Thumbs up.
Dan
On 12/12/19 10:23 AM, Stefan Karlsson
Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or
LOAD_ADDRESS_ERROR.
Chris
On 12/11/19 7:10 PM, Fairoz Matte wrote:
Hi,
Please review this small change,
Updating error handling, to make sure "lib_base_diff = 0" is still a valid
scenario even after calc_prelinked_load_address() call
src/hotspot/share/gc/shared/generationSpec.hpp
No comments.
test/hotspot/jtreg/serviceability/tmtools/jstat/utils/JstatGcCapacityResults.java
No comments.
Thumbs up.
Dan
On 12/12/19 10:23 AM, Stefan Karlsson wrote:
In the interest to get this integrated before the RDP cut-off I'm
goi
In the interest to get this integrated before the RDP cut-off I'm going
to push this ASAP. This has gone through tier1-tier3 testing.
StefanK
On 2019-12-12 13:01, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix a problem with unintialized values in
our generation counters.
h
Hi all,
Please review this patch to fix a problem with unintialized values in
our generation counters.
https://cr.openjdk.java.net/~stefank/8226797/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8226797
The jstat values NGCMN and OGCMN both return uninitialized values.
I stumbled upon t
On 12/12/2019 10:00, Langer, Christoph wrote:
Hi Matthias,
I think your current patch is good as it is – at least it wouldn’t
make things worse, AFAICS.
Further improvements can probably be done under another issue.
Yes, another issue is fine. If decodePath can't allocate during the
onl
Hi Matthias,
I think your current patch is good as it is – at least it wouldn’t make things
worse, AFAICS.
Further improvements can probably be done under another issue.
Cheers
Christoph
From: serviceability-dev On
Behalf Of Baesken, Matthias
Sent: Freitag, 29. November 2019 08:18
To: Thomas
Hi Yasumasa,
Thanks for the review.
Sure, I will get them on 8u and 11u.
Thanks,
Fairoz
> -Original Message-
> From: Yasumasa Suenaga
> Sent: Thursday, December 12, 2019 9:14 AM
> To: Fairoz Matte ; serviceability-
> d...@openjdk.java.net
> Subject: Re: RFR: 8235637: jhsdb jmap from Ope
17 matches
Mail list logo
