Re: PING: Re: RFR (XS): 8244571: assert(!_thread->is_pending_jni_exception_check()) failed: Pending JNI Exception Check during class loading

Hi David, Sorry for pushing it before your final approval. I thought you were okay with the update as it was implementation of your suggestion. Thanks, Serguei On 5/23/20 05:49, David Holmes wrote: Update looks fine - though I see you already pushed it. David On 22/05/2020 7:32 pm,

RFR(XS): 8234882: JVM TI StopThread should only allow ThreadDeath

Please, review a fix for:   https://bugs.openjdk.java.net/browse/JDK-8234882 CSR draft (one CSR reviewer is needed before finalizing it):   https://bugs.openjdk.java.net/browse/JDK-8245853 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-stop-thread.1/src/ Updated JVM TI

Re: RFR(S): 8244668: Remove SA's javascript support

Looks good to me. -Sundar On 27/05/20 5:01 am, Chris Plummer wrote: Hello, Please review the following changes to fully remove javascript support from SA. It's been non-functional since JDK 9 and there are no plans to support it anymore. https://bugs.openjdk.java.net/browse/JDK-8244668

Re: RFR: 8244993: Revert changes to OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings() that allow version strings

Hi Daniil, Looks good. thanks, Chris On 5/26/20 10:46 AM, Daniil Titov wrote: Hi Chris and David, Please review a new version of the fix [1] with the changes Chris suggested. [1] Webrev: http://cr.openjdk.java.net/~dtitov/8244993/webrev.02 [2] Jira issue:

RFR(S): 8244668: Remove SA's javascript support

Hello, Please review the following changes to fully remove javascript support from SA. It's been non-functional since JDK 9 and there are no plans to support it anymore. https://bugs.openjdk.java.net/browse/JDK-8244668 http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/index.html If

RFR(T): 8244622: Remove SA's memory/FreeChunk.java. It's no longer used.

Hello, Please review the following trivial change to remove FreeChunk.java: https://bugs.openjdk.java.net/browse/JDK-8244622 http://cr.openjdk.java.net/~cjplummer/8244622/webrev.00/index.html Tested with tier1 and also running all SA tests. thanks, Chris

Re: RFR: JDK-8244703: "platform encoding not initialized" exceptions with debugger, JNI

updated webrev (with fixing utf8 buffer size in transport.c): http://cr.openjdk.java.net/~amenkov/jdk15/jdwp_javalib_dep/webrev.2/ On 05/23/2020 01:54, Alan Bateman wrote: On 23/05/2020 01:15, Alex Menkov wrote: size of utf8 string does not depend on sizeof(int). Per RFC each symbol can be

Re: RFR: 8244993: Revert changes to OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings() that allow version strings

Hi Chris, I like the pattern and use it quite often. And the main reason not to avoid repetition of the object, but to avoid stupid copy-paste errors like MyObject obj1 = new MyObject(); obj1.method1(); obj1.method2(); MyObject obj2 = new MyObject(); obj2.method1(); obj1.method2(); <== I

Re: RFR(XS): 8245521: Remove STACK_BIAS

David/Matthias/Vladimir, thanks for the reviews! Change pushed. Cheers, Mikael > On May 26, 2020, at 12:01 PM, Vladimir Kozlov > wrote: > > On 5/21/20 9:11 PM, David Holmes wrote: >> Hi Mikael, >> Looks good. > > +1 > >> I assume the change to GraalHotSpotVMConfig.java is to allow it to

Re: RFR(XS): 8245521: Remove STACK_BIAS

On 5/21/20 9:11 PM, David Holmes wrote: Hi Mikael, Looks good. +1 I assume the change to GraalHotSpotVMConfig.java is to allow it to work with older VMs? Yes. stackBias will be set to 0 if STACK_BIAS is not present. Otherwise it will be set to STACK_BIAS value. Thanks, Vladimir

Re: RFR: 8244993: Revert changes to OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings() that allow version strings

Hi Chris and David, Please review a new version of the fix [1] with the changes Chris suggested. [1] Webrev: http://cr.openjdk.java.net/~dtitov/8244993/webrev.02 [2] Jira issue: https://bugs.openjdk.java.net/browse/JDK-8244993 Thank you, Daniil On 5/22/20, 11:50 AM, "Chris Plummer" wrote:

RE: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

Hi Vladimir, > > Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8238585/webrev.0/ > Not an expert in JVMTI code base, so can't comment on the actual changes. > From JIT-compilers perspective it looks good. I put out webrev.1 a while ago [1]: Webrev:

Re: RFR(XS): 8245126 Kitchensink fails with: assert(!method->is_old()) failed: Should not be installing old methods

On 5/25/20 23:39, serguei.spit...@oracle.com wrote: Please, review a fix for:   https://bugs.openjdk.java.net/browse/JDK-8245126 Webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/kitchensink-comp.1/ Summary:

RFR(XS): 8245126 Kitchensink fails with: assert(!method->is_old()) failed: Should not be installing old methods

Please, review a fix for:   https://bugs.openjdk.java.net/browse/JDK-8245126 Webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/kitchensink-comp.1/ Summary:   The Kitchensink stress test with the Instrumentation module