Re: RFR (xs) 8251209 [TESTBUG] CDS jvmti tests should use "@modules java.instrument"

2020-08-06 Thread Alan Bateman
On 07/08/2020 01:58, David Holmes wrote: It does in fact ensure that: "Otherwise, a test will not be run if the system being tested does not contain all of the specified modules." http://openjdk.java.net/jtreg/tag-spec.html But as I said the module could be present in a JRE but you are

Re: RFR (xs) 8251209 [TESTBUG] CDS jvmti tests should use "@modules java.instrument"

2020-08-06 Thread Ioi Lam
On 8/6/20 5:58 PM, David Holmes wrote: Correction ... On 7/08/2020 7:52 am, David Holmes wrote: Hi Ioi, On 7/08/2020 4:25 am, Ioi Lam wrote: https://bugs.openjdk.java.net/browse/JDK-8251209 http://cr.openjdk.java.net/~iklam/jdk16/8251209-cds-jvmti-tests-modules-tag.v01/ Summary --

Re: RFR (xs) 8251209 [TESTBUG] CDS jvmti tests should use "@modules java.instrument"

2020-08-06 Thread David Holmes
Correction ... On 7/08/2020 7:52 am, David Holmes wrote: Hi Ioi, On 7/08/2020 4:25 am, Ioi Lam wrote: https://bugs.openjdk.java.net/browse/JDK-8251209 http://cr.openjdk.java.net/~iklam/jdk16/8251209-cds-jvmti-tests-modules-tag.v01/ Summary -- changed the tests from (mis)using   *

Re: RFR: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits

2020-08-06 Thread 傅杰
FYI: This bug will lead to failures of the following tests on machines with hostname starting from digits. - test/jdk/sun/tools/jstatd/TestJstatdExternalRegistry.java - test/jdk/sun/tools/jstatd/TestJstatdPort.java - test/jdk/sun/tools/jstatd/TestJstatdPortAndServer.java -

Re: RFR(XS): 8251121: six SA tests leave core files behind on macOS

2020-08-06 Thread Chris Plummer
Thanks! On 8/6/20 3:10 PM, Daniel D. Daugherty wrote: +1 Dan On 8/6/20 5:58 PM, David Holmes wrote: Update looks good. Thanks, David On 7/08/2020 7:50 am, Chris Plummer wrote: Hi David and Dan, I went with just logging how long the copy takes. Here's all the code involved:    

Re: RFR(XS): 8251121: six SA tests leave core files behind on macOS

2020-08-06 Thread Daniel D. Daugherty
+1 Dan On 8/6/20 5:58 PM, David Holmes wrote: Update looks good. Thanks, David On 7/08/2020 7:50 am, Chris Plummer wrote: Hi David and Dan, I went with just logging how long the copy takes. Here's all the code involved: if (corePath.getParent() != null) {

Re: RFR(XS): 8251121: six SA tests leave core files behind on macOS

2020-08-06 Thread David Holmes
Update looks good. Thanks, David On 7/08/2020 7:50 am, Chris Plummer wrote: Hi David and Dan, I went with just logging how long the copy takes. Here's all the code involved:     if (corePath.getParent() != null) {     Path coreFileName = corePath.getFileName();   

Re: RFR (xs) 8251209 [TESTBUG] CDS jvmti tests should use "@modules java.instrument"

2020-08-06 Thread David Holmes
Hi Ioi, On 7/08/2020 4:25 am, Ioi Lam wrote: https://bugs.openjdk.java.net/browse/JDK-8251209 http://cr.openjdk.java.net/~iklam/jdk16/8251209-cds-jvmti-tests-modules-tag.v01/ Summary -- changed the tests from (mis)using  * @requires vm.flavor != "minimal" to  * @modules java.instrument

Re: RFR(XS): 8251121: six SA tests leave core files behind on macOS

2020-08-06 Thread Chris Plummer
Hi David and Dan, I went with just logging how long the copy takes. Here's all the code involved:     if (corePath.getParent() != null) {     Path coreFileName = corePath.getFileName();     System.out.println("Moving core file to cwd: " + coreFileName);   

Re: Fwd: Re: RFR(XS): 8248879: SA core file support on OSX has some bugs trying to locate the jvm libraries

2020-08-06 Thread Chris Plummer
Thanks! On 8/6/20 12:04 PM, Alex Menkov wrote: +1 --alex On 08/06/2020 08:21, serguei.spit...@oracle.com wrote: Hi Chris, Thank you for the update. LGTM Thanks, Serguei On 8/5/20 12:47, Chris Plummer wrote: Hi Alex and Serguei, Here's an update. I think I covered all recommendations:

Re: Fwd: Re: RFR(XS): 8248879: SA core file support on OSX has some bugs trying to locate the jvm libraries

2020-08-06 Thread Alex Menkov
+1 --alex On 08/06/2020 08:21, serguei.spit...@oracle.com wrote: Hi Chris, Thank you for the update. LGTM Thanks, Serguei On 8/5/20 12:47, Chris Plummer wrote: Hi Alex and Serguei, Here's an update. I think I covered all recommendations:

Re: RFR(XS): 8251121: six SA tests leave core files behind on macOS

2020-08-06 Thread Chris Plummer
Hi Dan, On 8/6/20 10:17 AM, Daniel D. Daugherty wrote: On 8/5/20 9:16 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8251121 http://cr.openjdk.java.net/~cjplummer/8251121/webrev.00/index.html test/lib/jdk/test/lib/util/CoreUtils.java   

Re: RFR(XS): 8251121: six SA tests leave core files behind on macOS

2020-08-06 Thread Daniel D. Daugherty
$ do_java_test -c fastdebug serviceability/sa 2>&1 | tee do_java_test.8251121.log INFO: GNUMAKE=make INFO: GNUMAKE version is: GNU Make 3.81 INFO: JTREG options: INFO:   JOBS=1 INFO:   TEST_MODE=othervm INFO:   VM_OPTIONS= INFO: test_val=serviceability/sa Test Config:

Re: RFR(XS): 8251121: six SA tests leave core files behind on macOS

2020-08-06 Thread Daniel D. Daugherty
On 8/5/20 9:16 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8251121 http://cr.openjdk.java.net/~cjplummer/8251121/webrev.00/index.html test/lib/jdk/test/lib/util/CoreUtils.java     You might consider two messages with timestamps: one

Re: 15: RFR(T): 8251214: ProblemList serviceability/sa/ClhsdbCDSCore.java on linux-x64

2020-08-06 Thread Chris Plummer
I'm withdrawing this RFR. Failures are due to a host config issue. Chris On 8/5/20 10:31 PM, David Holmes wrote: Problem listing this test seems fine to me. Thanks, David On 6/08/2020 2:11 pm, Chris Plummer wrote: Hello, Please review the following:

Re: Fwd: Re: RFR(XS): 8248879: SA core file support on OSX has some bugs trying to locate the jvm libraries

2020-08-06 Thread serguei.spit...@oracle.com
Hi Chris, Thank you for the update. LGTM Thanks, Serguei On 8/5/20 12:47, Chris Plummer wrote: Hi Alex and Serguei, Here's an update. I think I covered all recommendations:

Re: [OpenJDK 2D-Dev] RFR: 8240487 : Cleanup whitespace in .cc, .hh, .m, and .mm files

2020-08-06 Thread Kevin Rushforth
Looks good to me. I verified that the only changes are whitespace changes, and that after applying the patch there are no more whitespace errors. +1 -- Kevin On 8/5/2020 6:46 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8240487 Webrev:

Re: [OpenJDK 2D-Dev] RFR: 8240487 : Cleanup whitespace in .cc, .hh, .m, and .mm files

2020-08-06 Thread Sergey Bylokhov
Hi, Phil. Maybe we can enable jcheck for such files at the same time? On 05.08.2020 18:46, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8240487 Webrev: http://cr.openjdk.java.net/~prr/8240487/ In advance of the move to Project Skara/git it is desirable to clean up

Re: Ping: RFR: JDK-8249550: jdb should use loopback address when not using remote agent

2020-08-06 Thread serguei.spit...@oracle.com
Hi Alex, Thank you, for explanation. Serguei On 8/5/20 14:08, Alex Menkov wrote: Hi Serguei, Original issue is about jdb with CommandLineLaunch connector on non-Windows systems tries to resolve hostname and start to listening on it. This behavior can cause error (this is what the bug

Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

2020-08-06 Thread Hohensee, Paul
And a submit repo run succeeds. Serguei, would you be willing to review? Thanks, Paul On 8/5/20, 7:00 PM, "linzang(臧琳)" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content