Re: [Discussion] Expected behavior of combining "all" and "live" options of jmap

2020-08-18 Thread 臧琳
Dear All, May I get some suggestions? so that I can work out a patch base on that. Or may be it should not be treated as an issue? BRs, Lin On 17/08/2020 17:17, linzang(臧琳) wrote: > Dear all, > we found the jmap’s histo/dump command could accept "live" and > "all" o

Re: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits(Internet mail)

2020-08-18 Thread Claes Redestad
Hi, not sure I do, but a quick read of the relevant RFC suggests that since a URI scheme (protocol) must start with a letter[1] it seems safe to assume the string must be of the form hostname or hostname:port if the first character in the string is a digit. /Claes [1] https://tools.ietf.org/htm

RFR(T) : 8252005 : narrow disabling of allowSmartActionArgs in vmTestbase

2020-08-18 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/ > 0 lines changed: 0 ins; 0 del; 0 mod; Hi all, could you please review this trivial (and apparently empty) patch which sets allowSmartActionArgs to false only in subdirectories of vmTestbase which currently use PropertyResolvingWrapper?

Re: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits(Internet mail)

2020-08-18 Thread serguei.spit...@oracle.com
Hi Jie, I've added Claes to the list as he may have an expertise in this area. 83 * 84 * {@code } - transformed into "//localhost" 85 * localhost - transformed into "//localhost" 86 * hostname - transformed into "//hostname" 87 * ho

Re: RFR(s): 8248295: serviceability/jvmti/CompiledMethodLoad/Zombie.java failure with Graal

2020-08-18 Thread Vladimir Kozlov
I would suggest to run test with -XX:+PrintCodeCache flag which prints CodeCache usage on exit. Also add '-ea -esa' flags - some runs failed with them because they increase Graal's methods size. Running test with immediately caused OOM error on my local linux machine: '-server -ea -esa -XX:+T

Re: Protecting references from GC in JDI tests

2020-08-18 Thread Roger Riggs
Hi, You may also find useful java.lang.ref.Reference.reachabilityFence(obj [1] . It is designed to prevent the compiler from optimizing away a reference. It keeps the object referenced up to that point. [1] https://download.java.net/java/GA/jdk14/docs/api/java.base/java/lang/ref/Reference.html#

RE: RFR(s): 8248295: serviceability/jvmti/CompiledMethodLoad/Zombie.java failure with Graal

2020-08-18 Thread Fairoz Matte
Hi Vladimir, Thanks for looking into. This is intermittent crash, and is reproducible in windows debug build environment. Below is the testing performed. 1. Issues observed 7/100 runs, ReservedCodeCacheSize=20m with "-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+UseJVMCICompiler" 2. I

RE: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

2020-08-18 Thread Reingruber, Richard
Hi Goetz, I have collected the changes based on your feedback in a new webrev: Webrev.7: http://cr.openjdk.java.net/~rrich/webrevs/8227745/webrev.7/ Delta:http://cr.openjdk.java.net/~rrich/webrevs/8227745/webrev.7.inc/ Most of the changes are renamings, commenting, and reformatting. Besides