On Mon, 21 Sep 2020 22:57:55 GMT, Coleen Phillimore wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains five additional commi
On Tue, 22 Sep 2020 00:38:43 GMT, Serguei Spitsyn wrote:
>> Reviewed in the good old hg times :)
>> See also
>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041453.html
>
> Hi Richard,
>
> Could you consider to place the classes EscapeBarrier and
> JvmtiDeferredUpdate
On Thu, 17 Sep 2020 07:45:52 GMT, Goetz Lindenmaier wrote:
>> Marked as reviewed by goetz (Reviewer).
>
> Reviewed in the good old hg times :)
> See also
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041453.html
src/hotspot/share/opto/macro.cpp:
@@ -1091,11 +1091,11
On Wed, 16 Sep 2020 19:47:02 GMT, Alex Menkov wrote:
> Migrating this review from the mailing list into a pull request.
>
> Some background:
> when jdb launches debuggee process it passes java options from "options"
> value for CommandLineLaunch connector and
> forward options specified before
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the pu
On Mon, 21 Sep 2020 21:53:05 GMT, Joe Darcy wrote:
>> Please review the fix for [1]. The intention of this patch is to make
>> records final removing the need to
>> use --enable-preview in order to be able to include a record declaration in
>> a source or for the VM to execute code
>> compiled
On Mon, 21 Sep 2020 12:19:09 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
On Mon, 21 Sep 2020 11:02:10 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/handshake.cpp line 313:
>>
>>> 311: }
>>> 312:
>>> 313: int executed_by_driver = 0;
>>
>> Again why driver?? Isn't it either the current thread or the target that
>> will execute the op?
>
> The thread executi
On Mon, 21 Sep 2020 12:19:09 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
On Mon, 21 Sep 2020 21:19:32 GMT, Coleen Phillimore wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains five additional commi
On Fri, 11 Sep 2020 18:45:28 GMT, Daniel D. Daugherty
wrote:
> This RFE is to migrate the following field to OopStorage:
>
> class ObjectMonitor {
>
> void* volatile _object; // backward object pointer - strong root
>
> Unlike the previous patches in this series, there are a lot of collater
On Mon, 21 Sep 2020 21:36:39 GMT, Vicente Romero wrote:
>> Co-authored-by: Vicente Romero
>> Co-authored-by: Harold Seigel
>> Co-authored-by: Jonathan Gibbons
>> Co-authored-by: Brian Goetz
>> Co-authored-by: Maurizio Cimadamore
>> Co-authored-by: Joe Darcy
>> Co-authored-by: Chris Hegarty
Co-authored-by: Vicente Romero
Co-authored-by: Harold Seigel
Co-authored-by: Jonathan Gibbons
Co-authored-by: Brian Goetz
Co-authored-by: Maurizio Cimadamore
Co-authored-by: Joe Darcy
Co-authored-by: Chris Hegarty
Co-authored-by: Jan Lahoda
-
Commit messages:
- 8246774: Recor
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote:
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-a
On Tue, 15 Sep 2020 16:43:01 GMT, Daniil Titov wrote:
> The change fixes a 'deadlock' situation in VM_RedefineClasses::lock_classes()
> when the current thread is in the middle
> of redefining the same class. The change is based on the fix [1] suggested in
> the Jira issue [2] comment.
> [1] ht
On Mon, 21 Sep 2020 08:15:20 GMT, Bernhard Urban-Forster
wrote:
>> Hey @erikj79, thank you so much for giving it a try!
>>
>>> Our linux-aarch64 build fails with this:
>>> cc: error: unrecognized command line option '-std=c++14'
>>> when compiling
>>> build/linux-aarch64/buildjdk/hotspot/varia
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
> This patch implements asynchronous handshake, which changes how handshakes
> works by default. Asynchronous handshakes
> are target only executed, which they may never be executed. (target may block
> on socket for the rest of VM lifetime)
> Since we have several use-cases for them we can have
On Mon, 21 Sep 2020 05:42:29 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/thread.cpp
On Mon, 21 Sep 2020 05:31:59 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed double checks
>> Added NSV
>> ProcessResult to enum
>> Fixed logging
>> Moved _active_handshaker to private
On Mon, 21 Sep 2020 05:26:08 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/handshake.
On Mon, 21 Sep 2020 05:18:06 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/handshake.
On Mon, 21 Sep 2020 05:17:03 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed double checks
>> Added NSV
>> ProcessResult to enum
>> Fixed logging
>> Moved _active_handshaker to private
On Mon, 21 Sep 2020 05:01:29 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/prims/jvmtiEventCo
On Mon, 21 Sep 2020 06:13:55 GMT, David Holmes wrote:
> There is still a lack of motivation for this feature in the JBS issue. What
> kind of handshakes need to be asynchronous?
> Any async operation implies that the requester doesn't care about when or
> even if, the operation gets executed -
On Mon, 21 Sep 2020 05:27:00 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/handshake.hpp line 45:
>>
>>> 43: // a single target/direct handshake or not, by the JavaThread that
>>> requested the
>>> 44: // handshake or the VMThread respectively.
>>> 45: class HandshakeClosure : public Th
On Fri, 18 Sep 2020 20:52:49 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/prims/whit
On Mon, 21 Sep 2020 05:04:45 GMT, David Holmes wrote:
>> src/hotspot/share/prims/whitebox.cpp line 2032:
>>
>>> 2030: void do_thread(Thread* th) {
>>> 2031: assert(th->is_Java_thread(), "sanity");
>>> 2032: JavaThread* jt = (JavaThread*)th;
>>
>> Can whitebox.cpp code use the ne
On Fri, 18 Sep 2020 20:37:10 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/th
On Mon, 21 Sep 2020 05:32:54 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 157:
>>
>>> 155:
>>> 156: // Threads shouldn't block if they are in the middle of printing,
>>> but...
>>> 157: ttyLocker::break_tty_lock_for_safepoint(os::current_thread_
On Fri, 18 Sep 2020 20:21:09 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/ha
On 21/09/2020 09:18, Bernhard Urban-Forster wrote:
> Thank you Andrew. Is the goal to reduce the patch diff in
> `assembler_aarch64.cpp`? If so, we need to get rid of the
> retry in your patch to avoid additional calls to `random`, e.g. something
> like this (the diff for the generated part
> wou
On Fri, 18 Sep 2020 20:07:47 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/ha
On Fri, 18 Sep 2020 20:40:42 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/utilities/
On Fri, 18 Sep 2020 20:01:02 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed double checks
>> Added NSV
>> ProcessResult to enum
>> Fixed logging
>> Moved _active_handshaker to
On Fri, 18 Sep 2020 19:46:34 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/prims/jvmt
On Fri, 18 Sep 2020 18:38:34 GMT, Bernhard Urban-Forster
wrote:
>> Our linux-aarch64 build fails with this:
>> cc: error: unrecognized command line option '-std=c++14'
>> when compiling
>> build/linux-aarch64/buildjdk/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.gch
>>
>> I'm
On Tue, 8 Sep 2020 03:15:10 GMT, Lin Zang wrote:
> - enable parallel heap inspecton for ShenandoahHeap
> - preliminary evaluation:
> Time of jmap histo on (8GB heap with 4GB objects)
> * before: 5.186s
> * after : 1.698s
This pull request has now been integrated.
Changeset: 34ec1b
On Mon, 21 Sep 2020 07:14:43 GMT, Lin Zang wrote:
>> Thanks, this looks very good. I have only a few minor stylistic leftovers.
>> Other than that, it seems ready to integrate.
>
> Dear @shipilev,
>I just updated the patch. may I ask your help to review and merge it if
> there is no proble
> - enable parallel heap inspecton for ShenandoahHeap
> - preliminary evaluation:
> Time of jmap histo on (8GB heap with 4GB objects)
> * before: 5.186s
> * after : 1.698s
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The increment
On Mon, 21 Sep 2020 05:52:32 GMT, Aleksey Shipilev wrote:
>> Lin Zang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views
>> will show differences compared to the previous content of the PR. The pull
>> request contains one new commi
On Fri, 18 Sep 2020 20:34:55 GMT, Erik Joelsson wrote:
> I assume you need the rest of the PATH on Windows.
Doesn't look like it actually. I've reverted it, thanks for catching it.
-
PR: https://git.openjdk.java.net/jdk/pull/212
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
43 matches
Mail list logo
