On Mon, 28 Sep 2020 14:09:59 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which removes `PropertyResolvingWrapper`
> from `vmTestbase/nsk/jdi`? other than the
> removal of `PropertyResolvingWrapper` from jtreg actions, the patch also
> - `s/"-debugee.vmkeys=/-debug
On Thu, 24 Sep 2020 23:55:15 GMT, Igor Ignatyev wrote:
> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
> - updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
> - reformats code
>
> testing:
> ✅ `vmTestbase/nsk/jdb` on {macosx,linux,windows}-x64
On Wed, 30 Sep 2020 00:24:40 GMT, Serguei Spitsyn wrote:
>> Marked as reviewed by sspitsyn (Reviewer).
>
> Igor, this update looks good to me.
Chris, Serguei, thanks for your reviews. I've added the comment[[*]] explaining
the accompanying changes, so should
someone need to dig up why these cha
On Wed, 30 Sep 2020 01:06:50 GMT, Serguei Spitsyn wrote:
>>> Looks good. In the future I would like to see something like this broken up
>>> so as to not mix the smaller changes in
>>> with the massive repetitive changes.
>>
>> thanks, Chris. unfortunately, most of the changes here weren't
>>
On Fri, 25 Sep 2020 03:02:21 GMT, Igor Ignatyev wrote:
> the patch removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdwp` tests
> and cleans up/reformats the touched files.
>
> testing: ✅ `vmTestbase/nsk/jdwp` on `{linux,windows,macos}-x64`
This pull request has now been integrated.
C
On Wed, 30 Sep 2020 00:37:58 GMT, Serguei Spitsyn wrote:
>> the patch removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdwp`
>> tests and cleans up/reformats the touched files.
>>
>> testing: ✅ `vmTestbase/nsk/jdwp` on `{linux,windows,macos}-x64`
>
> Marked as reviewed by sspitsyn (Revi
On Tue, 29 Sep 2020 20:44:19 GMT, Igor Ignatyev wrote:
>> Looks good. In the future I would like to see something like this broken up
>> so as to not mix the smaller changes in
>> with the massive repetitive changes.
>
>> Looks good. In the future I would like to see something like this broken u
On Tue, 29 Sep 2020 14:08:49 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18
On Fri, 25 Sep 2020 03:02:21 GMT, Igor Ignatyev wrote:
> the patch removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdwp` tests
> and cleans up/reformats the touched files.
>
> testing: ✅ `vmTestbase/nsk/jdwp` on `{linux,windows,macos}-x64`
Marked as reviewed by sspitsyn (Reviewer).
-
On Tue, 29 Sep 2020 18:34:07 GMT, Vicente Romero wrote:
>> Co-authored-by: Vicente Romero
>> Co-authored-by: Harold Seigel
>> Co-authored-by: Jonathan Gibbons
>> Co-authored-by: Brian Goetz
>> Co-authored-by: Maurizio Cimadamore
>> Co-authored-by: Joe Darcy
>> Co-authored-by: Chris Hegarty
On Wed, 30 Sep 2020 00:20:33 GMT, Serguei Spitsyn wrote:
>> Igor Ignatyev has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update copyright years
>> - Revert "realign table in locals002"
>>Revert "updated copyright year"
>>Reve
On Wed, 30 Sep 2020 00:18:17 GMT, Vicente Romero wrote:
>> The instrument tests update looks good to me.
>
> @sspitsyn thanks for the review. Please add yourself as a reviewer
@plevart interesting, but I think that I prefer to update those benchmarks in a
follow-up patch in order to keep this
p
On Tue, 29 Sep 2020 21:52:18 GMT, Igor Ignatyev wrote:
>> the patch
>> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
>> - updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
>> - reformats code
>>
>> testing:
>> ✅ `vmTestbase/nsk/jdb` on {macosx,linux,windo
On Wed, 30 Sep 2020 00:06:19 GMT, Serguei Spitsyn wrote:
>> Marked as reviewed by jlahoda (Reviewer).
>
> The instrument tests update looks good to me.
@sspitsyn thanks for the review. Please add yourself as a reviewer
-
PR: https://git.openjdk.java.net/jdk/pull/290
On Tue, 29 Sep 2020 20:57:02 GMT, Chris Plummer wrote:
>> the patch removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdwp`
>> tests and cleans up/reformats the touched files.
>>
>> testing: ✅ `vmTestbase/nsk/jdwp` on `{linux,windows,macos}-x64`
>
> The changes look good, although I woul
On Tue, 29 Sep 2020 14:05:27 GMT, Jan Lahoda wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding missing changes to some tests
>
> Marked as reviewed by jlahoda (Reviewer).
The instrument tests update looks g
On Tue, 29 Sep 2020 21:52:18 GMT, Igor Ignatyev wrote:
>> the patch
>> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
>> - updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
>> - reformats code
>>
>> testing:
>> ✅ `vmTestbase/nsk/jdb` on {macosx,linux,windo
> On Sep 29, 2020, at 11:03 AM, Erik Österlund
> wrote:
>
> Changes: https://git.openjdk.java.net/jdk/pull/296/files
> Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=296&range=07
> Stats: 2705 lines in 129 files changed: 2137 ins; 310 del; 258 mod
> Patch: https://git.openjdk.java.net/j
> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
> - updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
> - reformats code
>
> testing:
> ✅ `vmTestbase/nsk/jdb` on {macosx,linux,windows}-x64
Igor Ignatyev has updated the pull request incrementall
On Tue, 29 Sep 2020 21:30:16 GMT, Chris Plummer wrote:
> > what do you see as a 3rd change here?
>
> PropertyResolvingWrapper, format changes, var declaration changes. I think
> large format changes should be kept separate
> from other changes, and would preferably be done first.
ok, given we
On Tue, 29 Sep 2020 21:28:07 GMT, Stefan Johansson wrote:
>> src/hotspot/share/gc/g1/vmStructs_g1.hpp line 56:
>>
>>> 54:
>>> \
>>> 55: nonstatic_field(HeapRegionManager, _regions,
>>> G1HeapRegionTable)
On Tue, 29 Sep 2020 18:29:57 GMT, Stefan Johansson wrote:
> While doing some refactoring I wanted to move
> HeapRegionManager::_num_committed and realized that I needed to update
> the SA. After some looking around it turns out that it is unused and I can
> remove the numCommittedField from the
On Tue, 29 Sep 2020 21:32:07 GMT, Chris Plummer wrote:
>> The field will remain for now, but the plan is to refactor it into a new
>> class. The new class is not needed by the SA
>> and I would really like to avoid having to add unused and untested code to
>> the SA. To simplify this coming cha
On Tue, 29 Sep 2020 19:43:45 GMT, Chris Plummer wrote:
>> While doing some refactoring I wanted to move
>> HeapRegionManager::_num_committed and realized that I needed to update
>> the SA. After some looking around it turns out that it is unused and I can
>> remove the numCommittedField from th
On Tue, 29 Sep 2020 21:26:46 GMT, Igor Ignatyev wrote:
> what do you see as a 3rd change here?
PropertyResolvingWrapper, format changes, var declaration changes. I think
large format changes should be kept separate
from other changes, and would preferably be done first.
-
PR: http
On Tue, 29 Sep 2020 21:06:58 GMT, Chris Plummer wrote:
> I have to push back on this. Needs to be broken up. You have 3 large changes
> that are completely unrelated. Seems you
> can push any of those 3 independent of the others.
Hi Chris,
what do you see as a 3rd change here?
`removes Proper
On Tue, 29 Sep 2020 14:43:30 GMT, Igor Ignatyev wrote:
>> The changes look good, but I think the practice of doing a massive cleanup
>> in "remove usage of PropertyResolvingWrapper
>> in vmTestbase/nsk/jdb" PR is misleading. Better to split this in two issues
>> (at least next time)?
>
> @shipi
On Tue, 29 Sep 2020 20:03:06 GMT, Chris Plummer wrote:
>> TestInstanceKlassSize was failing because, for PowerPC, the following code
>> (instanceKlass.cpp) always compiles to
>> `return false;` bool InstanceKlass::has_stored_fingerprint() const {
>> #if INCLUDE_AOT
>> return should_store_finge
On Fri, 25 Sep 2020 03:02:21 GMT, Igor Ignatyev wrote:
> the patch removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdwp` tests
> and cleans up/reformats the touched files.
>
> testing: ✅ `vmTestbase/nsk/jdwp` on `{linux,windows,macos}-x64`
The changes look good, although I wouldn't ha
On Tue, 29 Sep 2020 20:34:40 GMT, Chris Plummer wrote:
> Looks good. In the future I would like to see something like this broken up
> so as to not mix the smaller changes in
> with the massive repetitive changes.
thanks, Chris. unfortunately, most of the changes here weren't self-sufficient
o
On Mon, 28 Sep 2020 14:09:59 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which removes `PropertyResolvingWrapper`
> from `vmTestbase/nsk/jdi`? other than the
> removal of `PropertyResolvingWrapper` from jtreg actions, the patch also
> - `s/"-debugee.vmkeys=/-debug
On Tue, 29 Sep 2020 14:08:49 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18
On Tue, 29 Sep 2020 14:03:57 GMT, Bernhard Urban-Forster
wrote:
>> Marked as reviewed by aph (Reviewer).
>
> @theRealAph okay, I've changed the string representation of `r18` to
> `"r18_tls"` on every platform.
> @plummercj thank you for your feedback. I've updated the copyright in
> mentione
On Fri, 25 Sep 2020 13:13:44 GMT, Ziviani
wrote:
> TestInstanceKlassSize was failing because, for PowerPC, the following code
> (instanceKlass.cpp) always compiles to
> `return false;` bool InstanceKlass::has_stored_fingerprint() const {
> #if INCLUDE_AOT
> return should_store_fingerprint() |
On Tue, 22 Sep 2020 15:52:43 GMT, Harold Seigel wrote:
> Please review this small change to remove "--memory 200m" option from
> TestUseContainerSupport.java. This can cause
> test failures on systems where swap accounting is disabled.
This pull request has now been integrated.
Changeset: 2fe
On Tue, 29 Sep 2020 19:57:14 GMT, Coleen Phillimore wrote:
>> Please review this small change to remove "--memory 200m" option from
>> TestUseContainerSupport.java. This can cause
>> test failures on systems where swap accounting is disabled.
>
> Marked as reviewed by coleenp (Reviewer).
Setti
On Tue, 22 Sep 2020 15:52:43 GMT, Harold Seigel wrote:
> Please review this small change to remove "--memory 200m" option from
> TestUseContainerSupport.java. This can cause
> test failures on systems where swap accounting is disabled.
Marked as reviewed by coleenp (Reviewer).
-
On Tue, 22 Sep 2020 15:52:43 GMT, Harold Seigel wrote:
> Please review this small change to remove "--memory 200m" option from
> TestUseContainerSupport.java. This can cause
> test failures on systems where swap accounting is disabled.
Marked as reviewed by bobv (Committer).
-
PR
On Tue, 22 Sep 2020 15:52:43 GMT, Harold Seigel wrote:
> Please review this small change to remove "--memory 200m" option from
> TestUseContainerSupport.java. This can cause
> test failures on systems where swap accounting is disabled.
Marked as reviewed by bobv (Committer).
-
PR
On Tue, 29 Sep 2020 18:29:57 GMT, Stefan Johansson wrote:
> While doing some refactoring I wanted to move
> HeapRegionManager::_num_committed and realized that I needed to update
> the SA. After some looking around it turns out that it is unused and I can
> remove the numCommittedField from the
On Tue, 29 Sep 2020 18:29:57 GMT, Stefan Johansson wrote:
> While doing some refactoring I wanted to move
> HeapRegionManager::_num_committed and realized that I needed to update
> the SA. After some looking around it turns out that it is unused and I can
> remove the numCommittedField from the
While doing some refactoring I wanted to move HeapRegionManager::_num_committed
and realized that I needed to update
the SA. After some looking around it turns out that it is unused and I can
remove the numCommittedField from the
HeapRegionManager class in the SA.
Local build and test looks good
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has refreshed the
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the pu
On Tue, 29 Sep 2020 15:03:26 GMT, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interprete
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter frames, c1, c2,
> and native wrapper frames), to compare the
On Tue, 29 Sep 2020 14:39:23 GMT, Zhengyu Gu wrote:
>>> Hi Erik,
>>>
>>> I have been playing with this patch for past a few days. Great work!
>>>
>>> I found that this patch seems to break an early assumption.
>>> We have a comment in JavaThread::exit() says:
>>>
>>> // We need to cache the
On Fri, 25 Sep 2020 05:38:08 GMT, Aleksey Shipilev wrote:
>> Igor Ignatyev has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - realign table in locals002
>> - updated copyright year
>> - move var declarations closer to the 1st use
>>
On Fri, 25 Sep 2020 23:48:30 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which removes `PropertyResolvingWrapper`
> from `vmTestbase/nsk/jvmti` tests? as
> `jtreg` doesn't support spaces in the arguments and doesn't handle `"` in any
> special ways, the patch also
On Fri, 25 Sep 2020 03:02:21 GMT, Igor Ignatyev wrote:
> the patch removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdwp` tests
> and cleans up/reformats the touched files.
>
> testing: ✅ `vmTestbase/nsk/jdwp` on `{linux,windows,macos}-x64`
ping?
-
PR: https://git.openjdk
On Tue, 29 Sep 2020 14:12:26 GMT, Erik Österlund wrote:
> > Hi Erik,
> > I have been playing with this patch for past a few days. Great work!
> > I found that this patch seems to break an early assumption.
> > We have a comment in JavaThread::exit() says:
> > // We need to cache the thread name f
On Tue, 29 Sep 2020 13:13:55 GMT, Zhengyu Gu wrote:
>> I see; thank you for the explanation.
>
> Hi Erik,
>
> I have been playing with this patch for past a few days. Great work!
>
> I found that this patch seems to break an early assumption.
> We have a comment in JavaThread::exit() says:
>
On Fri, 25 Sep 2020 12:44:37 GMT, Andrew Haley wrote:
>> Monica Beckwith has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - os_windows: remove duplicated UMA handling
>> - test_safefetch{32,N} works fine on win+aarch64
>
> Marked as revi
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
On Fri, 25 Sep 2020 00:41:47 GMT, Vicente Romero wrote:
>> Co-authored-by: Vicente Romero
>> Co-authored-by: Harold Seigel
>> Co-authored-by: Jonathan Gibbons
>> Co-authored-by: Brian Goetz
>> Co-authored-by: Maurizio Cimadamore
>> Co-authored-by: Joe Darcy
>> Co-authored-by: Chris Hegarty
On Fri, 25 Sep 2020 15:47:30 GMT, Peter Levart wrote:
>> [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605)
>
> Hi @vicente-romero-oracle , note that besides tests, there is also a JMH
> benchmark that measures the performance of
> records deserialization (org.openjdk.bench.
On Fri, 25 Sep 2020 12:28:13 GMT, Richard Reingruber wrote:
>> The minor updates in response to my comments are fine.
>>
>> The more major updates ... I can't really comment on.
>
>>
>>
>> The minor updates in response to my comments are fine.
>>
>> The more major updates ... I can't really c
> Hi,
>
> this is the continuation of the review of the implementation for:
>
> https://bugs.openjdk.java.net/browse/JDK-8227745
> https://bugs.openjdk.java.net/browse/JDK-8233915
>
> It allows for JIT optimizations based on escape analysis even if JVMTI agents
> acquire capabilities to access
On Mon, 28 Sep 2020 12:00:40 GMT, Albert Mingkun Yang wrote:
>>> Thank you for the comments and diagrams; they make the code much more
>>> digestible. From that diagram, I get the
>>> impression that the watermark is associated with stack pointer, so it
>>> should be 1:1 relation, but `class Th
On Tue, 29 Sep 2020 10:02:16 GMT, Erik Österlund wrote:
>> IMO it's ok to remove it.
>> However, it can be argued that is_in() should not check for 'in committed
>> memory' but 'in reserved space for heap', IOW
>> 'is this a pointer into our heap memory region?'. Or maybe this would be
>> CH::
TestInstanceKlassSize was failing because, for PowerPC, the following code
(instanceKlass.cpp) always compiles to
`return false;` bool InstanceKlass::has_stored_fingerprint() const {
#if INCLUDE_AOT
return should_store_fingerprint() || is_shared();
#else
return false;
#endif
}
However, in `has
On Mon, 28 Sep 2020 19:53:37 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18
On Tue, 29 Sep 2020 09:22:18 GMT, Roman Kennke wrote:
>> I've also has problems with this assert in the past, and I think that the
>> underlying assumption of the assert is wrong.
>> I would not miss it.
>
> IMO it's ok to remove it.
> However, it can be argued that is_in() should not check for
On 28/09/2020 20:12, Bernhard Urban-Forster wrote:
> The idea is that the naming should suggest that `r18` shouldn't be used on
> that particular platform. Same is true for
> macOS, but the ABI docs suggest a different usage, hence we have something
> like that in our internal branch for macOS:
>
On 28/09/2020 20:12, Bernhard Urban-Forster wrote:
> The idea is that the naming should suggest that `r18` shouldn't be used on
> that particular platform. Same is true for
> macOS, but the ABI docs suggest a different usage, hence we have something
> like that in our internal branch for macOS:
>
On Tue, 29 Sep 2020 07:28:20 GMT, Per Liden wrote:
>> FTR, this is the RFE to remove the oop verification from the oop_iterate
>> framework:
>> https://bugs.openjdk.java.net/browse/JDK-8237363
>>
>> I really would like to get rid of it, but got push back because it made GCs
>> have to duplicat
On Tue, 29 Sep 2020 06:25:40 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 11 additional commits sinc
On Mon, 14 Sep 2020 13:00:59 GMT, Robbin Ehn wrote:
> This patch implements asynchronous handshake, which changes how handshakes
> works by default. Asynchronous handshakes
> are target only executed, which they may never be executed. (target may block
> on socket for the rest of VM lifetime)
>
On Tue, 29 Sep 2020 07:24:16 GMT, Stefan Karlsson wrote:
>> It was checking is_in_or_null before and after. Our is_in checks that it is
>> in committed memory, and that the pointer
>> is not stale w.r.t. color, as that is very likely to be a bug. We
>> reluctantly made it relaxed for our safepo
On Tue, 29 Sep 2020 06:42:54 GMT, Erik Österlund wrote:
>> I think the previous assert was intentionally weaker: `is_in` checks that
>> argument points to a committed area in the
>> heap, which can include the oops not yet fixed. It does not check if oop is
>> valid as far as GC is concerned. S
70 matches
Mail list logo
