On Fri, 5 Mar 2021 07:03:28 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update error message in CLHSDB
>
> test/hotspot/jtreg/serviceability/sa/sadebugd/ClhsdbAttachToDebugServer.java
>
> `attach` command on CLHSDB supports to attach live process (PID) and
> coredump, but it cannot connect to debug server. CLHSDB does not have a
> command to connect to debug server.
>
> Other jhsdb commands (jstack, jmap, etc...) can connect debug server via
> `--connect` option, so CLHSDB sho
On Thu, 4 Mar 2021 00:02:04 GMT, Yasumasa Suenaga wrote:
>> `attach` command on CLHSDB supports to attach live process (PID) and
>> coredump, but it cannot connect to debug server. CLHSDB does not have a
>> command to connect to debug server.
>>
>> Other jhsdb commands (jstack, jmap, etc...) c
On Sun, 28 Feb 2021 13:18:21 GMT, Yasumasa Suenaga wrote:
> `pmap` and `pstack` CLHSDB command do not work on remote debugger, we can see
> following error message:
>
> hsdb> pmap
> not yet implemented (debugger does not support CDebugger)!
>
> However, SA has different message for this purpos
Could I please get a Thumbs up from serviceability on the two JVMTI
changes, and from compiler folk on the JVMCI and Graal change.
Thanks,
David
On 5/03/2021 2:59 pm, David Holmes wrote:
ObjectMonitors can only be used by JavaThreads (modulo some interactions with hashcodes
and deflation) but
> ObjectMonitors can only be used by JavaThreads (modulo some interactions with
> hashcodes and deflation) but we use "Thread*" almost everywhere mainly due to
> use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685 is done).
> Also some uses of TRAPS in the API's are wrong as, for
Hi again Dan,
(I've given up trying to figure out how PR review emails get split up. :) )
Trimming ...
On 5/03/2021 9:46 am, Daniel D.Daugherty wrote:
src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 261:
259: volatile_nonstatic_field(ObjectMonitor, _cxq,
Hi Dan,
Thanks for taking a look at this.
Trimming ...
On 5/03/2021 9:46 am, Daniel D.Daugherty wrote:
src/hotspot/share/runtime/synchronizer.hpp line 200:
198: BasicLock _lock;
199: public:
200: ObjectLocker(Handle obj, JavaThread* current);
So no more non-JavaThread uses of Object
On 5/03/2021 8:54 am, Ioi Lam wrote:
On Thu, 4 Mar 2021 22:25:39 GMT, Coleen Phillimore wrote:
A suggestion (perhaps as a future RFE), if a function never throws:
void foo(Class* c, Method*m, Thread* current);
maybe we should move the last `thread` argument to first:
void foo(Thread* curren
On Wed, 3 Mar 2021 16:25:37 GMT, Coleen Phillimore wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More pointer declaration style fixups
>
> src/hotspot/share/runtime/synchronizer.hpp line 146:
>
>> 144:
>> 145:
On Wed, 3 Mar 2021 23:08:06 GMT, David Holmes wrote:
>> ObjectMonitors can only be used by JavaThreads (modulo some interactions
>> with hashcodes and deflation) but we use "Thread*" almost everywhere mainly
>> due to use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685
>> is do
On Wed, 3 Mar 2021 23:03:01 GMT, David Holmes wrote:
>> ObjectMonitors can only be used by JavaThreads (modulo some interactions
>> with hashcodes and deflation) but we use "Thread*" almost everywhere mainly
>> due to use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685
>> is do
On Thu, 4 Mar 2021 22:25:39 GMT, Coleen Phillimore wrote:
>> A suggestion (perhaps as a future RFE), if a function never throws:
>>
>> void foo(Class* c, Method*m, Thread* current);
>>
>> maybe we should move the last `thread` argument to first:
>>
>> void foo(Thread* current, Class* c, Method
On Thu, 4 Mar 2021 19:07:29 GMT, Ioi Lam wrote:
>> src/hotspot/share/runtime/synchronizer.hpp line 92:
>>
>>> 90: // This is the "slow path" version of monitor enter and exit.
>>> 91: static void enter(Handle obj, BasicLock* lock, JavaThread* current);
>>> 92: static void exit(oop obj, Bas
On Thu, 4 Mar 2021 19:47:00 GMT, Kevin Walls wrote:
>> Hi,
>> This is a pull request for 8259577, which points out that
>> Java_sun_tools_attach_VirtualMachineImpl_getTempDir
>> caches a local variable from a previous call, so could return garbage.
>> However as noted in the bug, we have been sa
> Hi,
> This is a pull request for 8259577, which points out that
> Java_sun_tools_attach_VirtualMachineImpl_getTempDir
> caches a local variable from a previous call, so could return garbage.
> However as noted in the bug, we have been safe so far because this method is
> only called once, so th
On Thu, 4 Mar 2021 19:15:26 GMT, Chris Plummer wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Copyright update.
>
> Looks good, except you need to update the copyright.
Oops, updated copyright... Thanks.
On Thu, 4 Mar 2021 18:27:48 GMT, Kevin Walls wrote:
> Hi,
> This is a pull request for 8259577, which points out that
> Java_sun_tools_attach_VirtualMachineImpl_getTempDir
> caches a local variable from a previous call, so could return garbage.
> However as noted in the bug, we have been safe so
On Wed, 3 Mar 2021 16:24:52 GMT, Coleen Phillimore wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More pointer declaration style fixups
>
> src/hotspot/share/runtime/synchronizer.hpp line 92:
>
>> 90: // This i
Hi,
This is a pull request for 8259577, which points out that
Java_sun_tools_attach_VirtualMachineImpl_getTempDir
caches a local variable from a previous call, so could return garbage.
However as noted in the bug, we have been safe so far because this method is
only called once, so the caching is
On Thu, 4 Mar 2021 17:36:22 GMT, Alan Hayward
wrote:
> I was building this PR on a new machine, and I now get the following error:
>
> > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:258:31:
> > error: cast to smaller integer type 'MID
On Thu, 4 Mar 2021 15:27:25 GMT, Gerard Ziemski wrote:
>>> A list of the bugs that our internal testing revealed so far:
>>
>> Are any of these blockers for integration? Some of them are to do with
>> things like features that aren't yet supported, and we can't fix what we
>> can't see.
>
>> >
On Wed, 3 Mar 2021 17:46:41 GMT, Andrew Haley wrote:
> > A list of the bugs that our internal testing revealed so far:
>
> Are any of these blockers for integration? Some of them are to do with things
> like features that aren't yet supported, and we can't fix what we can't see.
I don't person
On Wed, 3 Mar 2021 19:24:17 GMT, Patricio Chilano Mateo
wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More pointer declaration style fixups
>
> Hi David,
>
> Changes look good to me.
>
> Thanks,
> Patricio
>
On Thu, 4 Mar 2021 07:37:01 GMT, Chris Plummer wrote:
>> Hi Chris,
>>
>> Thanks for your review, I found there is a potential risk for huge object
>> dumping with this PR, I would work out an update and then add the
>> explaination in the CR.
>> Thanks!
>>
>> BRs,
>> Lin
>
> Thanks for the ex
On Thu, 4 Mar 2021 07:26:21 GMT, Chris Plummer wrote:
>> If I understanding correctly, we have two users of Tools.java. One is
>> `SALauncher` and the other is `CommandProcessor`. When we use `SALauncher`,
>> we determine the `debugeeType` based on the command line arguments used.
>> When usin
On Thu, 4 Mar 2021 07:32:26 GMT, Chris Plummer wrote:
>> BTW, referring back to the change to have attach handle pids and debug
>> servernames, and the concern about a host having a numeric name, we already
>> have code that assumes we don't have to deal with this in Tools.java. I just
>> stum
27 matches
Mail list logo
