On Wed, 3 Mar 2021 19:24:17 GMT, Patricio Chilano Mateo <[email protected]> wrote:
>> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More pointer declaration style fixups > > Hi David, > > Changes look good to me. > > Thanks, > Patricio > _Mailing list message from [David Holmes](mailto:[email protected]) on > [hotspot-compiler-dev](mailto:[email protected]):_ > > Hi Patricio, > > Thanks for looking at this. > > On 4/03/2021 5:26 am, Patricio Chilano Mateo wrote: > > > Hi David, > > Changes look good to me. > > Thanks, > > Patricio > > src/hotspot/share/runtime/objectMonitor.hpp line 306: > > > 304: > > > 305: bool enter(JavaThread* current); > > > 306: void exit(bool not_suspended, TRAPS); > > > > > > Shouldn't we also remove use of TRAPS for exit()? In case of unbalanced > > locking we don't throw IMSE, only just assert. > > Good catch! (no pun intended). Yes I overlooked that was don't actually > throw the IMSE in plain exit (in contrast to jni_exit). > > Fixed. Looks good! Thanks, Patricio ------------- PR: https://git.openjdk.java.net/jdk/pull/2802
