On Wed, 14 Apr 2021 16:05:39 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed flag undef dep + spelling error
>
> src/hotspot/share/runtime/handshake.hpp line 99:
>
>> 97: // but we
On Fri, 9 Apr 2021 15:39:08 GMT, Daniel D. Daugherty wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - White space fixes
>> - Merge branch 'master' into SuspendInHandshake
>> - Review fix
On Sat, 27 Feb 2021 18:20:52 GMT, Ioi Lam wrote:
>> Hi Yumin,
>>
>> This is a very useful addition.
>>
>> My biggest concern with this patch though is the use of
>> `os::fork_and_exec()` in regular, non-fatal situations. I had a look at that
>> function and I think that is very unsafe.
>>
>>
On Fri, 26 Feb 2021 00:03:40 GMT, Yumin Qi wrote:
> Hi, Please review
>
> Added jcmd option for dumping CDS archive during application runtime.
> Before this change, user has to dump shared archive in two steps: first run
> application with
> `java -XX:DumpLoadedClassList= `
> to c
On Wed, 14 Apr 2021 07:13:50 GMT, Per Liden wrote:
> JDK-8240679 introduced a change where the information exposed via the
> GarbageCollectorMXBean went from being related to the GC pauses to instead be
> related to the GC cycles. This helped provide more accurate heap usage
> information. How
On Sat, 10 Apr 2021 01:10:37 GMT, Alex Menkov wrote:
> The test actually failed starting from jdk13, but the error is masked by
> JDK-8264667 (and shell part of the test didn't verify result of the java
> execution)
> The fix:
> - updates JvmtiClassFileReconstituter to add attributes in the sam
On Sat, 10 Apr 2021 01:10:37 GMT, Alex Menkov wrote:
> The test actually failed starting from jdk13, but the error is masked by
> JDK-8264667 (and shell part of the test didn't verify result of the java
> execution)
> The fix:
> - updates JvmtiClassFileReconstituter to add attributes in the sam
On Sat, 10 Apr 2021 01:10:37 GMT, Alex Menkov wrote:
> The test actually failed starting from jdk13, but the error is masked by
> JDK-8264667 (and shell part of the test didn't verify result of the java
> execution)
> The fix:
> - updates JvmtiClassFileReconstituter to add attributes in the sam
On Wed, 14 Apr 2021 19:08:25 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On 15/04/2021 2:22 am, Daniel D.Daugherty wrote:
On Wed, 7 Apr 2021 07:23:26 GMT, Robbin Ehn wrote:
src/hotspot/share/runtime/handshake.cpp line 415:
413: // Adds are done lock free and so is arming.
414: // Calling this method with lock held is considered an error.
415: assert(!_lock.
On Mon, 12 Apr 2021 20:29:56 GMT, Chris Plummer wrote:
> Improved thread lookup speeds in the debug agent, especially when there is a
> large number of threads. See CR for details.
Looks good.
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/
On Wed, 14 Apr 2021 16:41:01 GMT, Tom Rodriguez wrote:
>> 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of
>> nmethods
>
> Tom Rodriguez has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
On Wed, 14 Apr 2021 06:48:40 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check
On Wed, 14 Apr 2021 06:48:40 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check
> Hi, Please review
>
> Added jcmd option for dumping CDS archive during application runtime.
> Before this change, user has to dump shared archive in two steps: first run
> application with
> `java -XX:DumpLoadedClassList= `
> to collect shareable class names and saved in file `` ,
Thank you for your consideration.
I would like to send a pull request soon.
Thanks
On 2021-04-06 06:17, Chris Plummer wrote:
[moving to serviceability-dev]
Hi,
I'm not sure if Address hashcodes are even used by SA, and if they
are, I doubt this slightly improved hash would make a noticeable
d
> 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of
> nmethods
Tom Rodriguez has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request c
On Wed, 14 Apr 2021 06:48:40 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check
On Wed, 14 Apr 2021 07:51:13 GMT, Stefan Karlsson wrote:
>> 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of
>> nmethods
>
> src/hotspot/share/prims/jvmtiExport.cpp line :
>
>> 1109: : JvmtiMethodEventMark(thread,methodHandle(thread,
>> nm->method())) {
>>
On Mon, 12 Apr 2021 07:48:10 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/objectMonitor.cpp line 970:
>>
>>> 968:
>>> 969: current->frame_anchor()->make_walkable(current);
>>> 970: OrderAccess::storestore();
>>
>> Needs a comment explaining what the memory sync is for.
>
> F
On Wed, 7 Apr 2021 07:23:26 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/handshake.cpp line 415:
>>
>>> 413: // Adds are done lock free and so is arming.
>>> 414: // Calling this method with lock held is considered an error.
>>> 415: assert(!_lock.owned_by_self(), "Lock should not b
On Wed, 14 Apr 2021 06:48:40 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check
On Tue, 13 Apr 2021 23:04:24 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Tue, 13 Apr 2021 23:04:24 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Wed, 14 Apr 2021 15:31:21 GMT, Daniel D. Daugherty
wrote:
> Reviewed v07 incremental. Still looks good.
Thank you!
-
PR: https://git.openjdk.java.net/jdk/pull/3191
On Wed, 14 Apr 2021 06:48:40 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check
On Mon, 29 Mar 2021 11:27:49 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 24 commits:
>
> - Merge branch 'master' into par-dump
> - Typo f
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 25 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- Typo fix
- remove parallel opt
> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
> out
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains ten addit
On Fri, 2 Apr 2021 19:43:31 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains eight additional commits
>> si
On Wed, 14 Apr 2021 00:35:55 GMT, Tom Rodriguez wrote:
> 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of
> nmethods
src/hotspot/share/prims/jvmtiExport.cpp line :
> 1109: : JvmtiMethodEventMark(thread,methodHandle(thread,
> nm->method())) {
> 1110: _
On Tue, 13 Apr 2021 02:00:24 GMT, Yasumasa Suenaga wrote:
> I got -1.0 from both CpuLoad and SystemCpuLoad in OperatingSystem MXBean when
> I run the application on Fedora 33 x64 which is installed cgroups V2.
>
> 