On 15/04/2021 2:22 am, Daniel D.Daugherty wrote:
On Wed, 7 Apr 2021 07:23:26 GMT, Robbin Ehn <r...@openjdk.org> wrote:
src/hotspot/share/runtime/handshake.cpp line 415:
413: // Adds are done lock free and so is arming.
414: // Calling this method with lock held is considered an error.
415: assert(!_lock.owned_by_self(), "Lock should not be held");
If adds are still lock-free then why was this assertion removed?
Because we add the async handshake inside the sync handshake and thus we
already hold the _lock.
@robehn - You still haven't addressed this one...
Assuming your comment is attributed to the correct comments, this is
addressed. The assert has to be removed because we can own the lock.
Cheers,
David
-------------
PR: https://git.openjdk.java.net/jdk/pull/3191
