On Wed, 27 Oct 2021 23:09:09 GMT, Chris Plummer wrote:
> Actually revoking my review for the moment. Do we have any tests that
> currently test the default PerfMaxStringConstLength, and this change could be
> subverting the test by making it so the length is never exceeded?
We don't have any t
On Tue, 5 Oct 2021 22:34:38 GMT, Alex Menkov wrote:
> The change fixes ProcessTools.startProcess "warmup predicate" synchronization
> issue.
> Initially the predicate was called only for STDOUT;
> From jdk8 it's called for STDERR too (but ProcessTools javadoc was not
> updated).
> The fix keeps
I think it is safe to assume that
jvmstat no longer needs to support querying 1.4.2 JVMs. The issue
was fixed in Java 5.
Chris
On 10/28/21 12:48 AM, Magnus Ihse Bursie wrote:
I noticed the following piece of code in
src/jdk.intern
On Thu, 28 Oct 2021 13:03:56 GMT, Severin Gehwolf wrote:
> Please review this change to remove some API which no longer works as
> expected as recent OCI runtimes start to drop support for `--kernel-memory`
> switch. See the bug for references. This part of the API is not present in
> hotspot
On Mon, 25 Oct 2021 19:50:54 GMT, Chris Plummer wrote:
>> Based on my local testing it appears the localization system falls back to
>> the English values when entries are missing, so it appears the current
>> behavior does already match what you've suggested. However, I don't
>> understand t
On Thu, 28 Oct 2021 14:04:15 GMT, Harold Seigel wrote:
> The changes look good. Thanks for doing this. Harold
Thanks for the review!
-
PR: https://git.openjdk.java.net/jdk/pull/6156
On Thu, 28 Oct 2021 13:03:56 GMT, Severin Gehwolf wrote:
> Please review this change to remove some API which no longer works as
> expected as recent OCI runtimes start to drop support for `--kernel-memory`
> switch. See the bug for references. This part of the API is not present in
> hotspot
Please review this change to remove some API which no longer works as expected
as recent OCI runtimes start to drop support for `--kernel-memory` switch. See
the bug for references. This part of the API is not present in hotspot code.
Testing: Container tests (cgroup v1) on Linux x86_64 (all pas
I noticed the following piece of code in
src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/v1_0/PerfDataBuffer.java:
if(jvm_name.stringValue().indexOf("HotSpot") >= 0) {
if(jvm_version.stringValue().startsWith("1.4.2")) {
kludgeMantis(map, args);
}
}
It looks like there's some
