Modified change based on feedback. New webrev at
http://cr.openjdk.java.net/~bpittore/8027914/webrev.01/
thanks,
bill
On 11/10/2013 1:57 PM, Bill Pittore wrote:
I think that's a good idea since we now have the distinct possibility
of the class not being available in certain profiles. I&
I think that's a good idea since we now have the distinct possibility of
the class not being available in certain profiles. I'll re-do the change
and send out a new webrev.
thanks,
bill
On 11/8/2013 9:45 PM, Mandy Chung wrote:
On 11/8/2013 8:08 AM, bill.pitt...@oracle.com wrote:
If you are r
If you are running a non-minimal VM build with compact 1 or 2 JRE and
you pass in -Dcom.sun.management argument, VM will exit silently with
exit code 1. Fix adds an error check when attempting to load the class
sun.management.Agent (missing from compact 1 and 2) and will print a
message before
8004051 and 8005722
Date: Thu, 22 Aug 2013 11:38:28 -0700
From: Vladimir Kozlov
To: hotspot compiler
Looks good.
Redirected to compiler alias since it is C1 compiler test.
Vladimir
On 8/22/13 11:06 AM, BILL PITTORE wrote:
Would like a review of the following test being added to
hotspot/test
Added serviceability.
bill
On 8/22/2013 2:06 PM, BILL PITTORE wrote:
Would like a review of the following test being added to
hotspot/test/compiler that tests an assertion failure for both 8004051
and 8005722.
http://cr.openjdk.java.net/~bpittore/8023580/webrev.00/
thanks,
bill
te wrote:
Serguei,
Are you ok with the webrev at this point or are you waiting for any
changes from Bill?
I've asked Coleen to review the code since she's an official
Reviewer but she'd like to make
sure the serviceability team is ok with the changes.
Bob.
On Aug 3, 2013, at 12
On 8/2/2013 9:12 PM, serguei.spit...@oracle.com wrote:
Hi Bill,
A couple of more questions.
webrev.01/jvmti.html
An agent L whose image has been combined with the VM *is defined* as
/statically linked/
if and only if the agent exports a function called Agent_OnLoad_L.
A question to the abov
Thanks Serguei for the comments. Some comments inline. I updated the
webrevs at
http://cr.openjdk.java.net/~bpittore/8014135/jdk/webrev.02/
http://cr.openjdk.java.net/~bpittore/8014135/hotspot/webrev.01/
http://cr.openjdk.java.net/~bpittore/8014135/javadoc/index.html
http://cr.openjdk.java.net/~
Still need an official reviewer for the hotspot changes for statically
linked agents.
thanks,
bill
These changes address bug 8014135 which adds support for statically
linked agents in the VM. This is a followup to the recent JNI spec
changes that addressed statically linked JNI libraries( 800
,
bill
On 7/4/2013 12:41 PM, Alan Bateman wrote:
On 03/07/2013 22:17, BILL PITTORE wrote:
These changes address bug 8014135 which adds support for statically
linked agents in the VM. This is a followup to the recent JNI spec
changes that addressed statically linked JNI libraries( 8005716).
The
p when he's back.
bill
On Wed, Jul 3, 2013 at 2:17 PM, BILL PITTORE <mailto:bill.pitt...@oracle.com>> wrote:
These changes address bug 8014135 which adds support for
statically linked agents in the VM. This is a followup to the
recent JNI spec changes that addressed
On 7/4/2013 12:41 PM, Alan Bateman wrote:
On 03/07/2013 22:17, BILL PITTORE wrote:
These changes address bug 8014135 which adds support for statically
linked agents in the VM. This is a followup to the recent JNI spec
changes that addressed statically linked JNI libraries( 8005716).
The JEP
These changes address bug 8014135 which adds support for statically
linked agents in the VM. This is a followup to the recent JNI spec
changes that addressed statically linked JNI libraries( 8005716).
The JEP for this change is the same JEP as the JNI changes:
http://openjdk.java.net/jeps/178
W
I'm fine with these changes. I can commit if someone can do the push if
you think we need to get this in tonight.
bill
On 5/15/2013 8:43 PM, David Holmes wrote:
Hi Bill,
On 16/05/2013 10:05 AM, David Holmes wrote:
Hi Bill,
(re-fixed the build-dev alias)
On 16/05/2013 6:48 AM, BILL PI
On 5/15/2013 8:05 PM, David Holmes wrote:
Hi Bill,
(re-fixed the build-dev alias)
On 16/05/2013 6:48 AM, BILL PITTORE wrote:
Some architecture dependent flags do not make it through to the
libjsig.so and libsaproc.so makefiles. As a result, the libs are not
compiled/linked with the correct
emo/jvmti/hprof/hprof_md.c
Fixed.
---
src/windows/back/linker_md.c
123 return;
Ditto previous comments.
Fixed.
Updated webrev http://cr.openjdk.java.net/~bpittore/7200297/webrev.04/
Running nsk tests.
bill
---
On 27/11/2012 3:45 AM, BILL PITTORE wrote:
Have a couple of reviews
Have a couple of reviews but still need official reviewer to pass muster.
thanks,
bill
On 11/22/2012 7:51 AM, Dmitry Samersoff wrote:
Bill,
Looks good for me.
-Dmitry
On 2012-11-21 23:31, BILL PITTORE wrote:
Hi Dmitry,
On 11/21/2012 4:56 AM, Dmitry Samersoff wrote:
Bill,
Few nits:
1
I think in terms of code readability I
like the 'else' since it makes it clear to the reader that there are two
different cases. C compiler will 'do the right thing'.
Updated the webrev at
http://cr.openjdk.java.net/~bpittore/7200297/webrev.03/
thanks,
bill
Otherwise looks good
Have gotten reviews from Serguei Spitsyn for the changes, made some
improvements and need an official reviewer to check it out.
http://cr.openjdk.java.net/~bpittore/7200297/webrev.02
thanks,
bill
On 11/14/2012 5:27 PM, bill.pitt...@oracle.com wrote:
This bug has to do with the jdwp and hprof
Thank you for fixing it!
Ok, will do.
thanks,
bill
Thanks,
Serguei
On 11/15/12 11:27 AM, BILL PITTORE wrote:
Hi Serguei,
Thanks for the review and your excellent suggestion at some
simplification in dll_build_name. Applied the changes, built, test
and all is still working. New webrev
Hi Serguei,
Thanks for the review and your excellent suggestion at some
simplification in dll_build_name. Applied the changes, built, test and
all is still working. New webrev at:
http://cr.openjdk.java.net/~bpittore/7200297/webrev.01/
Are you an official reviewer?
thanks,
bill
On 11/15/20
This bug has to do with the jdwp and hprof agents not parsing the
sun.boot.library.path (dll_dir) correctly since the fix for 6819213 went
in some years ago. This bug popped up while working on a particular
platform that does not have the ability to set LD_LIBRARY_PATH before
running the VM. As
only affect the
linux defs.make.
Thanks,
David
On 2/11/2012 12:39 PM, David Holmes wrote:
On 2/11/2012 12:03 PM, BILL PITTORE wrote:
On 11/1/2012 7:47 PM, David Holmes wrote:
On 2/11/2012 8:49 AM, Dmitry Samersoff wrote:
David,
Sorry, (my eyes) I misread if
As far as I understand,
On 11/1/2012 7:47 PM, David Holmes wrote:
On 2/11/2012 8:49 AM, Dmitry Samersoff wrote:
David,
Sorry, (my eyes) I misread if
As far as I understand, cross compilation require explicit ALT_OBJCOPY.
Yes.
Is there any defaults?
No. The makefiles know nothing about the toolsets for cross-c
weird indentation
Fixed.
bill
Thanks,
/Staffan
On 21 aug 2012, at 23:47, BILL PITTORE wrote:
These changes allow for the (easier) addition of new processor types to SA
other than the standard x86, amd64 and sparc. By using reflection, it is not
necessary to instantiate the new class dire
These changes allow for the (easier) addition of new processor types to
SA other than the standard x86, amd64 and sparc. By using reflection, it
is not necessary to instantiate the new class directly in the existing
code. Rather the class name is derived from the cpu/os name and is
loaded and t
nt? I
remember it should not be there.
--Yumin
On 1/12/2012 12:24 PM, Bill Pittore wrote:
Hi David,
Thanks for forwarding this to the SA list. I did run the nsk/jvmti
tests from the UTE area on sqenfs-1.us.oracle.com. There were no new
failures with this change.
bill
On 1/12/2012 2:54 AM,
David
On 11/01/2012 8:40 AM, Bill Pittore wrote:
Webrev for fix for 6972759 is at
http://cr.openjdk.java.net/~bpittore/6972759/webrev.00/
This bug has to do with single stepping after hitting an exception
breakpoint. The short story is that JVMTI maintains some thread state
information that wa
28 matches
Mail list logo
