Re: JVMTI retransformation and addition of private methods

2018-04-16 Thread David Holmes
On 17/04/2018 4:36 AM, Robert Field wrote: Rather than reverse engineer the spec from the hotspot implementation... Capabilities are the mechanism by which the level of functionality is defined.  Capabilities say what can be done, not what can't. The wording "The redefinition must not add, re

Re: JVMTI retransformation and addition of private methods

2018-04-16 Thread serguei.spit...@oracle.com
Added to the JDK-8192936. Thanks, Serguei On 4/16/18 11:36, Robert Field wrote: Rather than reverse engineer the spec from the hotspot implementation... Capabilities are the mechanism by which the level of functionality is defined.  Capabilities say what can be done, not what can't. The wo

Re: JVMTI retransformation and addition of private methods

2018-04-16 Thread serguei.spit...@oracle.com
Added this and prev. suggestion to the JDK-8192936. Thansk, Serguei On 4/16/18 11:36, Robert Field wrote: Rather than reverse engineer the spec from the hotspot implementation... Capabilities are the mechanism by which the level of functionality is defined.  Capabilities say what can be done

Re: JVMTI retransformation and addition of private methods

2018-04-16 Thread Robert Field
Rather than reverse engineer the spec from the hotspot implementation... Capabilities are the mechanism by which the level of functionality is defined.  Capabilities say what can be done, not what can't. The wording "The redefinition must not add, remove or rename fields or methods, change th

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread serguei.spit...@oracle.com
On 2/21/18 16:59, David Holmes wrote: On 22/02/2018 7:44 AM, serguei.spit...@oracle.com wrote: Hi Karen, Thank you for sorting this out! On 2/21/18 09:55, Karen Kinnear wrote: Dan, Thank you for all the background digging. This is really helpful. Serguei - do you know what tests exist for

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread David Holmes
Correction ... On 22/02/2018 10:59 AM, David Holmes wrote: On 22/02/2018 7:44 AM, serguei.spit...@oracle.com wrote: Hi Karen, Thank you for sorting this out! On 2/21/18 09:55, Karen Kinnear wrote: Dan, Thank you for all the background digging. This is really helpful. Serguei - do you know

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread serguei.spit...@oracle.com
Karen, On 2/21/18 16:46, Karen Kinnear wrote: Sergeui, You were right - I read the sources incorrectly. This code is easy to misunderstand - I read it incorrectly multiple times. :) This parts causes mos

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread David Holmes
On 22/02/2018 7:44 AM, serguei.spit...@oracle.com wrote: Hi Karen, Thank you for sorting this out! On 2/21/18 09:55, Karen Kinnear wrote: Dan, Thank you for all the background digging. This is really helpful. Serguei - do you know what tests exist for this behavior? Dan already replied (t

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread Karen Kinnear
Sergeui, You were right - I read the sources incorrectly. Would still help to understand both the motivation and the reason to not add to the spec. Robert - do you remember why we didn’t add this to the specification? (6404550) > On Feb 21, 2018, at 4:44 PM, serguei.spit...@oracle.com wrote: >

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread serguei.spit...@oracle.com
Hi Karen, Thank you for sorting this out! On 2/21/18 09:55, Karen Kinnear wrote: Dan, Thank you for all the background digging. This is really helpful. Serguei - do you know what tests

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread serguei.spit...@oracle.com
Hi Dan, On 2/21/18 10:02, Daniel D. Daugherty wrote: On 2/21/18 12:55 PM, Karen Kinnear wrote: Dan, Thank you for all the background digging. This is really helpful. Serguei - do you

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread Daniel D. Daugherty
On 2/21/18 12:55 PM, Karen Kinnear wrote: Dan, Thank you for all the background digging. This is really helpful. Serguei - do you know what tests exist for this behavior? I mentioned a test that I found in the email that I attached to my previous reply: Subject: Re: adding/deleting methods

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread Karen Kinnear
Dan, Thank you for all the background digging. This is really helpful. Serguei - do you know what tests exist for this behavior? The way I read the source code - we currently allow ADD and DELETE for PRIVATE OR STATIC OR FINAL methods. Did I read that correctly? With the current implementation,

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread Daniel D. Daugherty
On 2/21/18 2:45 AM, serguei.spit...@oracle.com wrote: On 2/20/18 23:01, David Holmes wrote: On 21/02/2018 4:50 PM, serguei.spit...@oracle.com wrote: Hi Karen and David, On 2/20/18 19:52, David Holmes wrote: Hi Karen, On 21/02/2018 1:54 AM, Karen Kinnear wrote: Folks, As part of the Valhal

Re: JVMTI retransformation and addition of private methods

2018-02-21 Thread serguei.spit...@oracle.com
On 2/20/18 23:01, David Holmes wrote: On 21/02/2018 4:50 PM, serguei.spit...@oracle.com wrote: Hi Karen and David, On 2/20/18 19:52, David Holmes wrote: Hi Karen, On 21/02/2018 1:54 AM, Karen Kinnear wrote: Folks, As part of the Valhalla EG discussions for JVMTI changes for nestmates (tha

Re: JVMTI retransformation and addition of private methods

2018-02-20 Thread David Holmes
On 21/02/2018 4:50 PM, serguei.spit...@oracle.com wrote: Hi Karen and David, On 2/20/18 19:52, David Holmes wrote: Hi Karen, On 21/02/2018 1:54 AM, Karen Kinnear wrote: Folks, As part of the Valhalla EG discussions for JVMTI changes for nestmates (thank you Serguei and David), IBM brought

Re: JVMTI retransformation and addition of private methods

2018-02-20 Thread serguei.spit...@oracle.com
Hi Karen and David, On 2/20/18 19:52, David Holmes wrote: Hi Karen, On 21/02/2018 1:54 AM, Karen Kinnear wrote: Folks, As part of the Valhalla EG discussions for JVMTI changes for nestma

Re: JVMTI retransformation and addition of private methods

2018-02-20 Thread David Holmes
Hi Karen, On 21/02/2018 1:54 AM, Karen Kinnear wrote: Folks, As part of the Valhalla EG discussions for JVMTI changes for nestmates (thank you Serguei and David), IBM brought up a request that we update the JVMTI documentation to reflect that we allow addition of private methods. Is there a

JVMTI retransformation and addition of private methods

2018-02-20 Thread Karen Kinnear
Folks, As part of the Valhalla EG discussions for JVMTI changes for nestmates (thank you Serguei and David), IBM brought up a request that we update the JVMTI documentation to reflect that we allow addition of private methods. Is there a reason we do not document this? I’m inviting those who we