Here is the webrev: http://cr.openjdk.java.net/~lzang/8251374/webrev01/
BRs,
Lin
On 2020/8/11, 10:52 AM, "linzang(臧琳)" wrote:
Hi All,
May I ask your help to review this tiny patch? It fix an issue that
jmap -dump could wrongly accept invalid optioins.
Bugs: https://bugs
Looks good, but for readability, please add a space before the trailing single
quote string, vis
System.err.println("Fail: invalid option: '" + subopt +"'");
should be
System.err.println("Fail: invalid option: '" + subopt + "'");
No need for a new webrev.
Thanks,
Paul
On 8/10/20, 8:00 PM, "
Hi Lin,
It looks good.
Just one comment.
+ System.err.println("Fail: invalid option: '" + subopt +"'");
+ System.exit(1);
Exit needs to be replaced wit usage for consistency.
Thanks,
Serguei
On 8/10/20 19:57, linzang(臧琳) wrote:
Here is the webrev: http://
Hi Paul and Serguei,
Thanks for your comments, here is the updated patch:
http://cr.openjdk.java.net/~lzang/8251374/webrev02/
BRs,
Lin
On 2020/8/13, 12:55 AM, "serguei.spit...@oracle.com"
wrote:
Hi Lin,
It looks good.
Just one comment.
+ System.er
Hi Lin.
Thank you for the update.
It looks good.
Thanks,
Serguei
On 8/12/20 17:08, linzang(臧琳) wrote:
Hi Paul and Serguei,
Thanks for your comments, here is the updated patch:
http://cr.openjdk.java.net/~lzang/8251374/webrev02/
BRs,
Lin
On 2020/8/13, 12:55 AM, "serguei.spit...@ora
+1, except that the indentation for the final 'else' clause needs to be 4
spaces instead of 3. :)
Thanks,
Paul
On 8/12/20, 6:21 PM, "serguei.spit...@oracle.com"
wrote:
Hi Lin.
Thank you for the update.
It looks good.
Thanks,
Serguei
On 8/12/20 17:08, linzang(臧琳) w
Thanks Paul！
May I ask your help to push it?
BRs,
Lin
> On Aug 13, 2020, at 10:06 PM, Hohensee, Paul wrote:
>
> +1, except that the indentation for the final 'else' clause needs to be 4
> spaces instead of 3. :)
>
> Thanks,
> Paul
>
> On 8/12/20, 6:21 PM, "serguei.spit...@oracle.com"
>
Will do.
On 8/13/20, 7:08 AM, "linzang(臧琳)" wrote:
Thanks Paul！
May I ask your help to push it?
BRs,
Lin
> On Aug 13, 2020, at 10:06 PM, Hohensee, Paul wrote:
>
> +1, except that the indentation for the final 'else' clause needs to be 4
spaces instead of 3. :)
I mistakenly committed and pushed Lin's patch with myself as author. Would
someone with repo access please change the author to 'lzang'? Or tell me how to
do it myself?
https://hg.openjdk.java.net/jdk/jdk/rev/5036ca733469
Thanks,
Paul
On 8/13/20, 9:48 AM, "serviceability-dev on behalf of Hohe
That's something that's very hard to do. It would involve black listing
the existing changeset and repushing a new changeset. Black listing a
changeset is very, very rarely done and in the past Ops has declined to
do that for something like an authorship error.
Two options:
1) Manually remember
On 8/13/20 12:01, Daniel D. Daugherty wrote:
That's something that's very hard to do. It would involve black listing
the existing changeset and repushing a new changeset. Black listing a
changeset is very, very rarely done and in the past Ops has declined to
do that for something like an authorsh
Paul,
Hold up on trying to fix this.
I'm discussing another idea with Stefan K.
Dan
On 8/13/20 3:01 PM, Daniel D. Daugherty wrote:
That's something that's very hard to do. It would involve black listing
the existing changeset and repushing a new changeset. Black listing a
changeset is very,
s/like a change/like a charm/
Typing too fast today...
Dan
On 8/13/20 3:51 PM, Daniel D. Daugherty wrote:
Stefan K's idea worked like a change. A corrected changeset has
been created, merged and pushed.
Dan
On 8/13/20 3:34 PM, Daniel D. Daugherty wrote:
Paul,
Hold up on trying to fix thi
Stefan K's idea worked like a change. A corrected changeset has
been created, merged and pushed.
Dan
On 8/13/20 3:34 PM, Daniel D. Daugherty wrote:
Paul,
Hold up on trying to fix this.
I'm discussing another idea with Stefan K.
Dan
On 8/13/20 3:01 PM, Daniel D. Daugherty wrote:
That's so
Thanks, Dan and Stefan!
Paul
On 8/13/20, 12:55 PM, "Daniel D. Daugherty"
wrote:
s/like a change/like a charm/
Typing too fast today...
Dan
On 8/13/20 3:51 PM, Daniel D. Daugherty wrote:
> Stefan K's idea worked like a change. A corrected changeset has
> been create
Dear Paul, Dan, Stefan and Serguei,
Please accept my best thanks for your help!
BRs,
Lin
On 2020/8/14, 4:48 AM, "Hohensee, Paul" wrote:
Thanks, Dan and Stefan!
Paul
On 8/13/20, 12:55 PM, "Daniel D. Daugherty"
wrote:
s/like a change/like a charm/
Typin
So am I right in thinking that what you did was forge a Merge changeset
that actually did a backout, and then recreated the changeset correctly
and pushed under the same bug number?
I don't think that is a process we want to endorse. A "Merge" changeset
should be exactly that.
Also the bug n
First, Paul sent his request on the wrong email thread and I didn't
notice until just now that we should have been using this one:
Subject: RFR(L): 8215624: add parallel heap inspection support for
jmap histo(G1)(Internet mail)
Fortunately, the correction was applied to the proper changese
Hi Dan,
On 15/08/2020 11:57 pm, Daniel D. Daugherty wrote:
First, Paul sent his request on the wrong email thread and I didn't
notice until just now that we should have been using this one:
Yes this has all been very confusing.
Subject: RFR(L): 8215624: add parallel heap inspection suppo
19 matches
Mail list logo
