Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

2013-05-07 Thread serguei.spit...@oracle.com
Looks good. I've overlooked it too. :( Thanks, Serguei On 5/6/13 10:58 PM, Staffan Larsen wrote: On 6 maj 2013, at 23:58, John Rose john.r.r...@oracle.com mailto:john.r.r...@oracle.com wrote: On May 2, 2013, at 1:50 AM, Staffan Larsen staffan.lar...@oracle.com

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

2013-05-06 Thread John Rose
On May 2, 2013, at 1:50 AM, Staffan Larsen staffan.lar...@oracle.com wrote: JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

2013-05-06 Thread Staffan Larsen
On 6 maj 2013, at 23:58, John Rose john.r.r...@oracle.com wrote: On May 2, 2013, at 1:50 AM, Staffan Larsen staffan.lar...@oracle.com wrote: JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in

RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

2013-05-02 Thread Staffan Larsen
JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ bug:

RE: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

2013-05-02 Thread Markus Grönlund
does not create BootstrapMethod attributes JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. webrev: http

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

2013-05-02 Thread serguei.spit...@oracle.com
This looks good. Thank you for discovering and fixing it! A couple of cosmetic comments: 352 //} Indent for } is needed 376 u2 bootstrap_arguments = cpool()-operand_argument_index_at(n, arg); It is about one argument. Should the variable name be: bootstrap_argument ?

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

2013-05-02 Thread Staffan Larsen
Thanks Serguei! I'll fix both of these before pushing. /Staffan On 2 maj 2013, at 12:24, serguei.spit...@oracle.com wrote: This looks good. Thank you for discovering and fixing it! A couple of cosmetic comments: 352 //} Indent for } is needed 376 u2 bootstrap_arguments =