Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-29 Thread Rickard Bäckman
Looks good! /R On Aug 29, 2013, at 10:26 AM, Staffan Larsen wrote: > Can I have a second review for the Hotspot part of this change? > > Thanks, > /Staffan > > On 27 aug 2013, at 10:48, Staffan Larsen wrote: > >> I have also made a fix for hotspot. I messed up the link in the last email >>

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-29 Thread Staffan Larsen
Can I have a second review for the Hotspot part of this change? Thanks, /Staffan On 27 aug 2013, at 10:48, Staffan Larsen wrote: > I have also made a fix for hotspot. I messed up the link in the last email so > here are both webrevs. > > jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread Staffan Larsen
On 27 aug 2013, at 13:38, David Holmes wrote: > On 27/08/2013 6:48 PM, Staffan Larsen wrote: >> I have also made a fix for hotspot. I messed up the link in the last email >> so here are both webrevs. >> >> jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/ > > Seems okay. > >> hotspot:

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread Staffan Larsen
Thanks! On 27 aug 2013, at 13:45, David Holmes wrote: > On 27/08/2013 9:41 PM, Staffan Larsen wrote: >> >> On 27 aug 2013, at 13:38, David Holmes wrote: >> >>> On 27/08/2013 6:48 PM, Staffan Larsen wrote: I have also made a fix for hotspot. I messed up the link in the last email so

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread David Holmes
On 27/08/2013 9:41 PM, Staffan Larsen wrote: On 27 aug 2013, at 13:38, David Holmes wrote: On 27/08/2013 6:48 PM, Staffan Larsen wrote: I have also made a fix for hotspot. I messed up the link in the last email so here are both webrevs. jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.0

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread David Holmes
On 27/08/2013 6:48 PM, Staffan Larsen wrote: I have also made a fix for hotspot. I messed up the link in the last email so here are both webrevs. jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/ Seems okay. hotspot: http://cr.openjdk.java.net/~sla/8023720/webrev.00/ ??? You didn't

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread Staffan Larsen
I have also made a fix for hotspot. I messed up the link in the last email so here are both webrevs. jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/ hotspot: http://cr.openjdk.java.net/~sla/8023720/webrev.00/ Thanks, /Staffan On 27 aug 2013, at 10:41, Staffan Larsen wrote: > The orig

RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread Staffan Larsen
The original conversation about this problem is here: http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-August/011318.html In short, setjmp/longjmp on OS X messes up the signal mask and we should use _setjmp/_longjmp instead. This change fixes two occurences in the jdk. There ar