On Mon, 21 Sep 2020 21:59:40 GMT, Coleen Phillimore wrote:
>> The thread executing this handshake operation, what the current thread is
>> doesn't matter.
>> You can't use current threads resources or be dependent otherwise on it.
>>
>> Exception being locking issues in JVM TI, where we are dep
On Mon, 21 Sep 2020 11:07:14 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/handshake.hpp line 44:
>>
>>> 42: // by the target JavaThread itself or, depending on whether the
>>> operation is
>>> 43: // a single target/direct handshake or not, by the JavaThread that
>>> requested the
>>> 4
On Mon, 21 Sep 2020 11:02:10 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/handshake.cpp line 313:
>>
>>> 311: }
>>> 312:
>>> 313: int executed_by_driver = 0;
>>
>> Again why driver?? Isn't it either the current thread or the target that
>> will execute the op?
>
> The thread executi
On Mon, 21 Sep 2020 05:42:29 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/thread.cpp
On Mon, 21 Sep 2020 05:26:08 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/handshake.
On Mon, 21 Sep 2020 05:18:06 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/handshake.
On Mon, 21 Sep 2020 05:01:29 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/prims/jvmtiEventCo
On Mon, 21 Sep 2020 06:13:55 GMT, David Holmes wrote:
> There is still a lack of motivation for this feature in the JBS issue. What
> kind of handshakes need to be asynchronous?
> Any async operation implies that the requester doesn't care about when or
> even if, the operation gets executed -
On Mon, 21 Sep 2020 05:27:00 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/handshake.hpp line 45:
>>
>>> 43: // a single target/direct handshake or not, by the JavaThread that
>>> requested the
>>> 44: // handshake or the VMThread respectively.
>>> 45: class HandshakeClosure : public Th
On Fri, 18 Sep 2020 20:52:49 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/prims/whit
On Mon, 21 Sep 2020 05:04:45 GMT, David Holmes wrote:
>> src/hotspot/share/prims/whitebox.cpp line 2032:
>>
>>> 2030: void do_thread(Thread* th) {
>>> 2031: assert(th->is_Java_thread(), "sanity");
>>> 2032: JavaThread* jt = (JavaThread*)th;
>>
>> Can whitebox.cpp code use the ne
On Fri, 18 Sep 2020 20:37:10 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/th
On Mon, 21 Sep 2020 05:32:54 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 157:
>>
>>> 155:
>>> 156: // Threads shouldn't block if they are in the middle of printing,
>>> but...
>>> 157: ttyLocker::break_tty_lock_for_safepoint(os::current_thread_
On Fri, 18 Sep 2020 20:21:09 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/ha
On Fri, 18 Sep 2020 20:07:47 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/runtime/ha
On Fri, 18 Sep 2020 20:40:42 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/utilities/
On Fri, 18 Sep 2020 19:46:34 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/prims/jvmt
On Fri, 18 Sep 2020 20:51:17 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed double check, fix comment, removed not needed function, updated
>> logs
>
> src/hotspot/share/prims/whit
On Thu, 17 Sep 2020 19:51:24 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
On Thu, 17 Sep 2020 19:51:24 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
On Thu, 17 Sep 2020 19:51:24 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
> This patch implements asynchronous handshake, which changes how handshakes
> works by default. Asynchronous handshakes
> are target only executed, which they may never be executed. (target may block
> on socket for the rest of VM lifetime)
> Since we have several use-cases for them we can have
22 matches
Mail list logo