Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-23 Thread Igor Veresov
On Fri, 22 Jan 2021 17:32:09 GMT, Igor Veresov wrote: >> src/hotspot/share/compiler/compileBroker.cpp line 972: >> >>> 970: >>> 971: // Initialize the compilation queue >>> 972: if (_c2_count > 0) { >> >> Is ZERO treated as `is_interpreter_only()` ? How this change works with ZERO? > > I f

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-22 Thread Igor Veresov
On Fri, 22 Jan 2021 01:11:33 GMT, Vladimir Kozlov wrote: >> Igor Veresov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another s390 compilation failure > > src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 229: > >> 227: JVMTI_ON

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-22 Thread Vladimir Kozlov
On Fri, 22 Jan 2021 17:14:15 GMT, Igor Veresov wrote: >> src/hotspot/share/aot/aotCodeHeap.cpp line 194: >> >>> 192: // AOT libs are loaded before heap initialized so shift values are >>> not set. >>> 193: // It is okay since ObjectAlignmentInBytes flag which defines shifts >>> value is se

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-22 Thread Igor Veresov
On Fri, 22 Jan 2021 00:56:16 GMT, Vladimir Kozlov wrote: >> Igor Veresov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another s390 compilation failure > > src/hotspot/share/runtime/vmStructs.cpp line 296: > >> 294: JVMTI_ONLY(n

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-22 Thread Igor Veresov
On Fri, 22 Jan 2021 00:24:34 GMT, Vladimir Kozlov wrote: >> Igor Veresov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another s390 compilation failure > > src/hotspot/share/compiler/compileBroker.cpp line 972: > >> 970: >> 971:

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-22 Thread Igor Veresov
On Wed, 20 Jan 2021 20:36:35 GMT, Vladimir Kozlov wrote: >> Igor Veresov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another s390 compilation failure > > src/hotspot/share/aot/aotCodeHeap.cpp line 194: > >> 192: // AOT libs ar

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-21 Thread Vladimir Kozlov
On Thu, 7 Jan 2021 23:06:19 GMT, Igor Veresov wrote: >> This change removes the legacy compilation policy and an emulation mode to >> the tiered policy to simulate the old behavior with >> ```-XX:-TieredCompilation```. The change removed a bunch of interpreter >> code, devirtualizes the compil

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-11 Thread Igor Veresov
On Mon, 11 Jan 2021 09:06:36 GMT, Boris Ulasevich wrote: >> Igor Veresov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another s390 compilation failure > > src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp line 376: > >> 3

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-11 Thread Boris Ulasevich
On Thu, 7 Jan 2021 23:06:19 GMT, Igor Veresov wrote: >> This change removes the legacy compilation policy and an emulation mode to >> the tiered policy to simulate the old behavior with >> ```-XX:-TieredCompilation```. The change removed a bunch of interpreter >> code, devirtualizes the compil

Re: RFR: 8251462: Remove legacy compilation policy [v3]

2021-01-07 Thread Igor Veresov
> This change removes the legacy compilation policy and an emulation mode to > the tiered policy to simulate the old behavior with > ```-XX:-TieredCompilation```. The change removed a bunch of interpreter code, > devirtualizes the compilation policy API, adds a consistent way to query > compile