On Thu, 7 Jan 2021 23:06:19 GMT, Igor Veresov <ivere...@openjdk.org> wrote:

>> This change removes the legacy compilation policy and an emulation mode to 
>> the tiered policy to simulate the old behavior with 
>> ```-XX:-TieredCompilation```. The change removed a bunch of interpreter 
>> code, devirtualizes the compilation policy API, adds a consistent way to 
>> query compiler configuration with the new ```CompilerConfig``` API.
>> 
>> I've tested this with hs-tier{1,2,3,4,5}. And also made sure it builds and 
>> works with C1/C2-Graal/AOT being enabled/disabled.
>> 
>> Since there are platform-specific changes I would greatly appreciate some 
>> help from the maintainers of the specific ports to verify the build and run 
>> basic smoke tests. I've already tested x64 and aarch64. Thanks!
>
> Igor Veresov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix another s390 compilation failure

src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp line 376:

> 374:   // Note: In tiered we increment either counters in MethodCounters* or
> 375:   // in MDO depending if we're profiling or not.
> 376:   int increment = InvocationCounter::count_increment;

The small code below seems not to be equivalent replacement for the above code. 
I would appreciate some explanation on why we change the things. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1985

Reply via email to