On Tue, 29 Sep 2020 21:26:46 GMT, Igor Ignatyev wrote:
> what do you see as a 3rd change here?
PropertyResolvingWrapper, format changes, var declaration changes. I think
large format changes should be kept separate
from other changes, and would preferably be done first.
-
PR: http
On Tue, 29 Sep 2020 21:06:58 GMT, Chris Plummer wrote:
> I have to push back on this. Needs to be broken up. You have 3 large changes
> that are completely unrelated. Seems you
> can push any of those 3 independent of the others.
Hi Chris,
what do you see as a 3rd change here?
`removes Proper
On Tue, 29 Sep 2020 14:43:30 GMT, Igor Ignatyev wrote:
>> The changes look good, but I think the practice of doing a massive cleanup
>> in "remove usage of PropertyResolvingWrapper
>> in vmTestbase/nsk/jdb" PR is misleading. Better to split this in two issues
>> (at least next time)?
>
> @shipi
On Fri, 25 Sep 2020 05:38:08 GMT, Aleksey Shipilev wrote:
>> Igor Ignatyev has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - realign table in locals002
>> - updated copyright year
>> - move var declarations closer to the 1st use
>>
> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
> - updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
> - reformats code
>
> testing:
> ✅ `vmTestbase/nsk/jdb` on {macosx,linux,windows}-x64
Igor Ignatyev has updated the pull request incrementall
On Fri, 25 Sep 2020 05:38:08 GMT, Aleksey Shipilev wrote:
>> Igor Ignatyev has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - realign table in locals002
>> - updated copyright year
>> - move var declarations closer to the 1st use
>>
