On Thu, 23 Sep 2021 13:07:46 GMT, David Holmes wrote:
>> Thanks @schmelter-sap and @plummercj for your help review and approve this
>> PR!
>> Since this is a non-trivial change, I would like to wait for 2 days before
>> integrate it in case more comments from others.
>
> @linzang this change
On Tue, 21 Sep 2021 02:07:39 GMT, Lin Zang wrote:
>> I will start reviewing this today.
>
> Thanks @schmelter-sap and @plummercj for your help review and approve this PR!
> Since this is a non-trivial change, I would like to wait for 2 days before
> integrate it in case more comments from
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Thanks @schmelter-sap and @plummercj for your help review and
On Thu, 16 Sep 2021 09:35:20 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Hi Ralf @schmelter-sap,
I have updated the PR, would you
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous content of the PR. The pull request contains one new commit since the
last
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix build issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
code refine
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 49 commits:
- fix parallel issue
- Merge branch 'master' into pd-fix
- Merge branch 'master' of
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
rebased with latest master, and made some change to fix
On Mon, 13 Sep 2021 16:12:48 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> src/hotspot/share/services/heapDumper.cpp line 1797:
>
>> 1795: if (o->is_instance()) {
>> 1796:
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Hi Ralf @schmelter-sap ,
Thanks for your review and
On Wed, 8 Sep 2021 13:39:08 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> src/hotspot/share/services/attachListener.cpp line 255:
>
>> 253: HeapDumper
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
The change seems OK so far, but I've found a few issues.
On Fri, 10 Sep 2021 03:03:01 GMT, Lin Zang wrote:
> Seems the #5410 has made some change that will affect this one. I am
> wondering should I start to rebase this PR based on that ?
It looks like at most there would be one conflict, and it is trivial. You'll
eventually have to merge before
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
Seems the #5410 has made some change that will affect this
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
> I will start reviewing this today.
Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/2261
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
I will start reviewing this today.
-
PR:
On Thu, 28 Jan 2021 07:30:29 GMT, Serguei Spitsyn wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Hi Lin,
> It is also in my memory that you actually did not have 4 arguments.
> The real incompatibility issue was that the order of arguments was swapped.
> It is why it was
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 40 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- fix build issue
- Merge
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 39 commits:
- Merge branch 'master' into par-dump
- fix build issue
- Merge branch 'master' into par-dump
- Merge
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix build issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 37 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- Merge branch 'master' into
On Mon, 7 Jun 2021 07:58:26 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 36 commits:
>
> - Merge branch 'master' into par-dump
> - Merge
On Mon, 7 Jun 2021 07:58:26 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 36 commits:
>
> - Merge branch 'master' into par-dump
> - Merge
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 36 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- fix build issue after rebase
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 35 commits:
- Merge branch 'master' into par-dump
- fix build issue after rebase and fix one issue
- Merge branch
On Wed, 19 May 2021 11:55:12 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 34 commits:
>
> - fix build issue after rebase and fix one issue
On Mon, 10 May 2021 23:29:36 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code refine and typo fix
>
> I think you still need to undo the JMap.java changes since they are now being
> handled by
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 34 commits:
- fix build issue after rebase and fix one issue
- Merge branch 'master'
- Merge branch 'master' into pd
-
On Wed, 12 May 2021 11:10:37 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 32 commits:
>
> - Merge branch 'master' into pd
> - update
On Wed, 12 May 2021 11:10:37 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 32 commits:
>
> - Merge branch 'master' into pd
> - update
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 32 commits:
- Merge branch 'master' into pd
- update copyright info
- Merge branch 'master' into par-dump
- undo
On Tue, 11 May 2021 03:19:05 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 30 commits:
>
> - Merge branch 'master' into par-dump
> - undo
On Mon, 10 May 2021 23:29:36 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code refine and typo fix
>
> I think you still need to undo the JMap.java changes since they are now being
> handled by
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 30 commits:
- Merge branch 'master' into par-dump
- undo JMap.java
- code refine and typo fix
- Merge branch 'master'
On Thu, 6 May 2021 08:45:45 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code refine and typo fix
I think you still need to undo the JMap.java
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
code refine and typo fix
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
On Mon, 26 Apr 2021 12:45:56 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 27 commits:
>
> - Merge branch 'master' into par-dump
> -
On Mon, 26 Apr 2021 12:45:56 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 27 commits:
>
> - Merge branch 'master' into par-dump
> -
On Mon, 26 Apr 2021 12:45:56 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 27 commits:
>
> - Merge branch 'master' into par-dump
> -
On Wed, 21 Apr 2021 18:40:16 GMT, Chris Plummer wrote:
>>> My concerns with your proposed testing is that it always targets the same
>>> application with the same heap, and does not read/process the hprof file to
>>> make sure it is not corrupt.
>>
>> Hmm, I agree, I will do more test and
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master' into par-dump
> - Merge
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 27 commits:
- Merge branch 'master' into par-dump
- refine with several fix
- Merge branch 'master' into par-dump
-
On Tue, 20 Apr 2021 22:20:17 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into par-dump
>> - Merge branch 'master' into par-dump
>> - Typo fix
On Wed, 21 Apr 2021 18:40:16 GMT, Chris Plummer wrote:
> > > My concerns with your proposed testing is that it always targets the same
> > > application with the same heap, and does not read/process the hprof file
> > > to make sure it is not corrupt.
> >
> >
> > Hmm, I agree, I will do more
On Wed, 21 Apr 2021 05:56:21 GMT, Lin Zang wrote:
> > My concerns with your proposed testing is that it always targets the same
> > application with the same heap, and does not read/process the hprof file to
> > make sure it is not corrupt.
>
> Hmm, I agree, I will do more test and update
On Wed, 21 Apr 2021 05:22:26 GMT, Chris Plummer wrote:
> My concerns with your proposed testing is that it always targets the same
> application with the same heap, and does not read/process the hprof file to
> make sure it is not corrupt.
Hmm, I agree, I will do more test and update here.
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master' into par-dump
> - Merge
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master' into par-dump
> - Merge
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master' into par-dump
> - Merge
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master' into par-dump
> - Merge
On Mon, 29 Mar 2021 11:27:49 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 24 commits:
>
> - Merge branch 'master' into par-dump
> - Typo
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 25 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- Typo fix
- remove parallel
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 24 commits:
- Merge branch 'master' into par-dump
- Typo fix
- remove parallel option and dumpheapext command
- Revert
On Tue, 23 Mar 2021 23:33:02 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove parallel option and dumpheapext command
>> - Revert "hide the dumpheapext error message"
>>
>>This
On Mon, 22 Mar 2021 12:35:52 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - remove parallel option and dumpheapext command
> - Revert "hide the
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- remove parallel option and dumpheapext command
- Revert "hide the dumpheapext error message"
This reverts commit
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 20 commits:
- resize large object threshold
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
On Fri, 19 Mar 2021 20:01:01 GMT, Chris Plummer wrote:
>> Dear Ralf and Chris,
>>
>>> to be honest I would prefer if we would not add the parallel option but
>>> instead do it automatically depending on the number of GC threads
>>> available. I doubt that the user has a good idea about number
On Thu, 18 Mar 2021 14:40:57 GMT, Lin Zang wrote:
> * Is it acceptable that `jmap -dump` and `jmap -histo` have different
> behavior about the option of `parallel`, that is, `heapdump` does not use it
> and `heaphisto` does.
And just to further clarify, the parallel support for `jmap -histo`
On Thu, 18 Mar 2021 12:20:25 GMT, Ralf Schmelter wrote:
>> Dear Chris and Ralf,
>> May I ask your help to review the related CSR first? both JDK-8260424 and
>> JDK-8261943?
>> https://bugs.openjdk.java.net/browse/JDK-8260424 is for adding
>> `parallel=` option, which IMO also block the merge
On Thu, 18 Mar 2021 12:09:25 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reduce memory consumption and fix memory leak issue
>
> src/hotspot/share/services/heapDumper.cpp line 1741:
>
>> 1739:
On Thu, 18 Mar 2021 11:07:16 GMT, Lin Zang wrote:
>> Dear Ralf @schmelter-sap,
>> Sorry for late response, I got stuck in other work recently.
>> I have uploaded a new update that could help reduce memory consumption and
>> also fix the assertion issue.
>> I have verified it on my machine,
On Wed, 10 Mar 2021 09:41:21 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reduce memory consumption and fix memory leak issue
On Wed, 10 Mar 2021 11:33:00 GMT, Lin Zang wrote:
>> Hi @linzang
>>
>>
>>> This data are really interest to me, it seems using gzipped dump is faster
>>> than unzipped dump, is the because of disk writing or something else? I
>>> would investigate more about it~
>>
>> I would guess that is
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 18 commits:
- Merge branch 'master' into par-dump
- code clean
- fix trailing white space issue
- reduce memory
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
code clean
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
On Tue, 23 Feb 2021 08:51:15 GMT, Ralf Schmelter wrote:
>> Dear @plummercj,
>>
>> I have reconsidered the solution of “dumpheapext”, IMHO maybe the name is
>> too specific, for example, if in future there is more arguments for
>> `-histo`, we have to made another command called
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix trailing white space issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
reduce memory consumption and fix memory leak issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
Revise jmap help info
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 13 commits:
- Merge master
- fix build fail issue on windows
- hide the dumpheapext error message
- Merge branch
On Thu, 25 Feb 2021 12:18:55 GMT, Lin Zang wrote:
> Do you think it is ok if I change the help message of `parallel` option
> `jmap -histo` in this PR together?
Yes, I think that would be ok.
-
PR: https://git.openjdk.java.net/jdk/pull/2261
On Wed, 24 Feb 2021 04:12:13 GMT, Chris Plummer wrote:
>>> It's too bad that the `dumpheap` command in previous JDKs has a slot for a
>>> 3rd argument, but doesn't look at it. Maybe that was intentional to allow
>>> for a new argument without causing a failure. What it means is if we want a
On Wed, 24 Feb 2021 04:12:13 GMT, Chris Plummer wrote:
>>> It's too bad that the `dumpheap` command in previous JDKs has a slot for a
>>> 3rd argument, but doesn't look at it. Maybe that was intentional to allow
>>> for a new argument without causing a failure. What it means is if we want a
On Wed, 24 Feb 2021 03:46:42 GMT, Lin Zang wrote:
> > But they are far more convenient and easier to understand than jcmd, so
> > will probably stay around. But you are right in that they could still all
> > be converted to use jcmd internally.
>
> Maybe we could consider using `jcmd`
On Wed, 24 Feb 2021 02:48:06 GMT, Chris Plummer wrote:
> It's too bad that the `dumpheap` command in previous JDKs has a slot for a
> 3rd argument, but doesn't look at it. Maybe that was intentional to allow for
> a new argument without causing a failure. What it means is if we want a
>
On Wed, 24 Feb 2021 03:24:46 GMT, Lin Zang wrote:
> > JDK-8251347 does not appear to be the correct bug. Can you find the one you
> > are referring too?
>
> oops, It should be https://bugs.openjdk.java.net/browse/JDK-8251374, sorry.
Ok, but that fix is on the client side, not the target VM
On Wed, 24 Feb 2021 02:48:06 GMT, Chris Plummer wrote:
> JDK-8251347 does not appear to be the correct bug. Can you find the one you
> are referring too?
oops, It should be https://bugs.openjdk.java.net/browse/JDK-8251374, sorry.
-
PR: https://git.openjdk.java.net/jdk/pull/2261
On Wed, 24 Feb 2021 01:08:58 GMT, Lin Zang wrote:
>>> I just realized that my understand is a little different with the
>>> "retrying" - if we already know what is newly added argument, we can assume
>>> old jvm can not accept it. So it seems print error message is enough. This
>>> is
On Wed, 24 Feb 2021 00:40:03 GMT, Chris Plummer wrote:
>>> So in general, I think any solution we come up with will fail with older
>>> JDKs, and need to fallback to retrying with a command we know will work.
>>
>> Dear Chris,
>> I just realized that my understand is a little different with
On Wed, 24 Feb 2021 00:22:16 GMT, Lin Zang wrote:
> I just realized that my understand is a little different with the "retrying"
> - if we already know what is newly added argument, we can assume old jvm can
> not accept it. So it seems print error message is enough. This is consistent
>
On Wed, 24 Feb 2021 00:02:33 GMT, Lin Zang wrote:
> So in general, I think any solution we come up with will fail with older
> JDKs, and need to fallback to retrying with a command we know will work.
Dear Chris,
I just realized that my understand is a little different with the "retrying" -
On Wed, 24 Feb 2021 00:02:33 GMT, Lin Zang wrote:
>>> I have reconsidered the solution of “dumpheapext”, IMHO maybe the name is
>>> too specific, for example, if in future there is more arguments for
>>> `-histo`, we have to made another command called "inspectheapext".
>>>
>>> How about
On Tue, 23 Feb 2021 23:00:30 GMT, Chris Plummer wrote:
>> Dear @plummercj,
>>
>> I have reconsidered the solution of “dumpheapext”, IMHO maybe the name is
>> too specific, for example, if in future there is more arguments for
>> `-histo`, we have to made another command called
On Tue, 23 Feb 2021 08:37:34 GMT, Lin Zang wrote:
> I have reconsidered the solution of “dumpheapext”, IMHO maybe the name is too
> specific, for example, if in future there is more arguments for `-histo`, we
> have to made another command called "inspectheapext".
>
> How about create a new
On Tue, 23 Feb 2021 08:37:34 GMT, Lin Zang wrote:
>> Dear @ralf,
>> Really Thanks for benchmarking it!
>> It is a little surprise to me that "parallel=1" is 10~20 percent slower than
>> before. I believe this can be avoid with some revise in code. And I also
>> found a potential memory leak in
On Tue, 23 Feb 2021 08:23:49 GMT, Lin Zang wrote:
>> Hi @linzang,
>>
>> I've done more benchmarking using different numbers of threads for parallel
>> heap iteration and have found values which give at least a factor of 2
>> speedup (for gzipped dumps) or 1.6 (for unzipped dumps). For my
On Tue, 23 Feb 2021 08:06:14 GMT, Ralf Schmelter wrote:
>> Hi @schmelter-sap,
>> Thanks a lot for reviewing and benchmarking.
>>
>>> I've benchmarked the code on my machine (128GB memory, 56 logical CPUs)
>>> with an example creating a 32 GB heap dump. I only saw a 10 percent
>>> reduction
On Mon, 22 Feb 2021 07:36:55 GMT, Lin Zang wrote:
>> Hi,
>>
>> I've benchmarked the code on my machine (128GB memory, 56 logical CPUs) with
>> an example creating a 32 GB heap dump. I only saw a 10 percent reduction in
>> time, both using uncompressed and compressed dumps. Have you seen
On Mon, 22 Feb 2021 05:53:19 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build fail issue on windows
>
> Hi,
>
> I've benchmarked the code on my machine (128GB memory, 56 logical CPUs)
On Fri, 19 Feb 2021 14:36:00 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build fail issue on windows
Hi,
I've benchmarked the code on my
On Thu, 18 Feb 2021 16:38:04 GMT, Chris Plummer wrote:
> Or the other option would be to eat the exception and produce an error
> message saying that the `parallel` option is not supported by the target VM.
> I don't think the user should be exposed to the "Operation dumpheapext not
>
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
hide the dumpheapext error message
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new:
On Fri, 19 Feb 2021 04:20:14 GMT, Chris Plummer wrote:
> > CSR requests are associated with a JBS issue not a PR. If there exists a
> > CSR request for this JBS issue and you are making further changes then move
> > the CSR back to draft and update it and re-submit it.
> > Thanks,
> > David
>
On 19/02/2021 2:22 pm, Chris Plummer wrote:
On Thu, 18 Feb 2021 16:39:46 GMT, Chris Plummer wrote:
Dear All,
I am going to create a CSR for the new internal command "dumpheapext",
one problem is that seem if a new CSR is created, this PR will depends on 2 CSRs, I am
not sure is this
On Thu, 18 Feb 2021 16:39:46 GMT, Chris Plummer wrote:
>> Dear All,
>> I am going to create a CSR for the new internal command "dumpheapext",
>> one problem is that seem if a new CSR is created, this PR will depends on 2
>> CSRs, I am not sure is this reasonable? Thanks!
>
>> I am
On 19/02/2021 2:42 am, Chris Plummer wrote:
On Thu, 18 Feb 2021 08:58:25 GMT, Lin Zang wrote:
Hi Chris,
I have update the PR to add a new dumpheapext command that could handle more
arguments passed from JMap.java.
And I have tested with "jmap -dump:file=dump.bin,noparallel [pid]", with this
1 - 100 of 129 matches
Mail list logo
