Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-25 Thread Chris Plummer
On Thu, 26 May 2022 02:35:08 GMT, David Holmes wrote: >>> If virtual threads become permanent then the usage message would minimally >>> be updated to drop the sentence that virtual threads are a preview feature. >> >> But that's precisely the commitment to this flag that I want to avoid. I

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-25 Thread David Holmes
On Wed, 25 May 2022 16:11:52 GMT, Chris Plummer wrote: >> If virtual threads become permanent then the usage message would minimally >> be updated to drop the sentence that virtual threads are a preview feature. >> At that point the debugger APIs may have been built out further and it might

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-25 Thread Chris Plummer
On Wed, 25 May 2022 06:23:48 GMT, Alan Bateman wrote: > If virtual threads become permanent then the usage message would minimally be > updated to drop the sentence that virtual threads are a preview feature. But that's precisely the commitment to this flag that I want to avoid. I want

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-25 Thread Alan Bateman
On Tue, 24 May 2022 19:36:02 GMT, Chris Plummer wrote: >> I don't think it is correct to say that this command line option is a >> preview feature. Maybe it can be clarified on a second line: >> >> >> -trackvthreadstrack virtual threads as they are created >>

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-24 Thread Chris Plummer
On Mon, 23 May 2022 18:34:03 GMT, Alan Bateman wrote: >> I agree with @plummercj , this is documenting that the flag is itself a >> "preview feature" and thus subject to change. > > I don't think it is correct to say that this command line option is a preview > feature. Maybe it can be

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 02:52:38 GMT, David Holmes wrote: >> I was really trying to emphasize that the flag is preview, and therefore may >> change or go away. If I change as you suggest, the reader could imply that >> as long as virtual threads support is in place, then the flag will be also

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-22 Thread David Holmes
On Thu, 19 May 2022 15:29:14 GMT, Chris Plummer wrote: >> src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c line 880: >> >>> 878: "onuncaught=y|n debug on any uncaught? >>> n\n" >>> 879: "timeout= for listen/attach in milliseconds >>> n\n" >>> 880:

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-19 Thread Chris Plummer
> As part of the loom integration, jdb added -trackvthreads and the debug agent > added "enumeratevthreads". The help text for these options should call out > that they are Preview Features. Chris Plummer has updated the pull request incrementally with one additional commit since the last