Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

2018-07-11 Thread serguei.spit...@oracle.com
Hi Jc, The fix looks good. I'll sponsor a push once it has been reviewed. Thanks, Serguei On 7/11/18 10:04, JC Beyler wrote: Hi all, Could someone review the small-ish webrev for the bug:

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

2018-07-12 Thread JC Beyler
Thanks Serguei! Anybody motivated to give this a review please? Thanks! Jc On Wed, Jul 11, 2018 at 2:42 PM serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Hi Jc, > > The fix looks good. > I'll sponsor a push once it has been reviewed. > > Thanks, > Serguei > > > On 7/11/18 10:

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

2018-07-12 Thread Alex Menkov
Looks good to me as well. --alex On 07/12/2018 07:25, JC Beyler wrote: Thanks Serguei! Anybody motivated to give this a review please? Thanks! Jc On Wed, Jul 11, 2018 at 2:42 PM serguei.spit...@oracle.com > wrote:

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

2018-07-12 Thread serguei.spit...@oracle.com
Thanks, Alex! Jc, I'll push it if you send me a patch. Thanks, Serguei On 7/12/18 11:30, Alex Menkov wrote: Looks good to me as well. --alex On 07/12/2018 07:25, JC Beyler wrote: Thanks Serguei! Anybody motivated to give this a review please? Thanks! Jc On Wed, Jul 11, 2018 at 2:42 PM

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

2018-07-12 Thread JC Beyler
Hi Serguei, Here you are: http://cr.openjdk.java.net/~jcbeyler/8206960/webrev.01/ Thanks for the push! Jc On Thu, Jul 12, 2018 at 11:33 AM serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Thanks, Alex! > > Jc, > > I'll push it if you send me a patch. > > Thanks, > Serguei > > >

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

2018-07-12 Thread serguei.spit...@oracle.com
Pushed. Thanks, Serguei On 7/12/18 12:02, JC Beyler wrote: Hi Serguei, Here you are: http://cr.openjdk.java.net/~jcbeyler/8206960/webrev.01/ Thanks for the push!