On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote:
> This patch modifies the `getLastErrorString` method to return a `jstring`.
> Thanks to that we can avoid unnecessary back and forth conversions between
> Unicode and other charsets on Windows.
>
> Other changes include:
> - the Windows
On Thu, 9 Mar 2023 18:55:06 GMT, Patricio Chilano Mateo
wrote:
> Please review this small fix. A suspender is a JvmtiVTMSTransitionDisabler
> monopolist, meaning VTMS_transition_disable_for_all() should not return while
> there is any active jvmtiVTMSTransitionDisabler. The code though is chec
On Thu, 9 Mar 2023 18:55:06 GMT, Patricio Chilano Mateo
wrote:
> Please review this small fix. A suspender is a JvmtiVTMSTransitionDisabler
> monopolist, meaning VTMS_transition_disable_for_all() should not return while
> there is any active jvmtiVTMSTransitionDisabler. The code though is chec
On Thu, 9 Mar 2023 21:08:16 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Wed, 8 Mar 2023 18:25:15 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Thu, 9 Mar 2023 21:08:16 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Tue, 7 Mar 2023 22:14:39 GMT, Patricio Chilano Mateo
wrote:
> Please review the following fix. The Method instance representing
> Continuation.enterSpecial() is replaced by a new Method during redefinition
> of the Continuation class. The already existing nmethod for it is not used,
> but
On Thu, 9 Mar 2023 22:24:00 GMT, Serguei Spitsyn wrote:
> Looks good. Thank you for taking care about it! Serguei, Thanks
>
Thanks for the review Serguei!
-
PR: https://git.openjdk.org/jdk/pull/12911
On Tue, 7 Mar 2023 22:14:39 GMT, Patricio Chilano Mateo
wrote:
> Please review the following fix. The Method instance representing
> Continuation.enterSpecial() is replaced by a new Method during redefinition
> of the Continuation class. The already existing nmethod for it is not used,
> but
On Thu, 9 Mar 2023 21:08:16 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Thu, 9 Mar 2023 21:36:32 GMT, Alex Menkov wrote:
> The test fails intermittently on linux-x64-debug and linux-aarch64-debug
This pull request has now been integrated.
Changeset: e930b63a
Author:Alex Menkov
URL:
https://git.openjdk.org/jdk/commit/e930b63a8f166502740bca45e3d022f69f
On Wed, 8 Mar 2023 22:40:56 GMT, Chris Plummer wrote:
> Although it takes both ZGC and -Xcomp to cause the test to fail, we have no
> way to problem list for just that combination, so I'm choosing the problem
> list with just ZGC since it is the main cause of the failure. I've only seen
> this
On Fri, 3 Mar 2023 18:16:25 GMT, Chris Plummer wrote:
> The test failure is caused by the arrival of unexpected ThreadStartEvents,
> which mess up the debugger side. The events are for threads we normally only
> see getting created when using virtual threads, such as carrier threads and
> the
On Wed, 8 Mar 2023 22:39:55 GMT, Chris Plummer wrote:
>> The test failure is caused by the arrival of unexpected ThreadStartEvents,
>> which mess up the debugger side. The events are for threads we normally only
>> see getting created when using virtual threads, such as carrier threads and
>>
On Wed, 8 Mar 2023 22:40:56 GMT, Chris Plummer wrote:
> Although it takes both ZGC and -Xcomp to cause the test to fail, we have no
> way to problem list for just that combination, so I'm choosing the problem
> list with just ZGC since it is the main cause of the failure. I've only seen
> this
The test fails intermittently on linux-x64-debug and linux-aarch64-debug
-
Commit messages:
- problemlist UniqueVtableTest on linux
Changes: https://git.openjdk.org/jdk/pull/12962/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12962&range=00
Issue: https://bugs.openjdk.or
On Thu, 9 Mar 2023 21:36:32 GMT, Alex Menkov wrote:
> The test fails intermittently on linux-x64-debug and linux-aarch64-debug
Thumbs up. This is a trivial fix.
-
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12962
> The current structure used to store the resolution information for
> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
> ambigious fields f1 and f2. This structure can hold information for fields,
> methods, and invokedynamics and each of its fields can hold different
On Wed, 8 Mar 2023 16:05:57 GMT, Coleen Phillimore wrote:
>> Please review this change re-implementing the FieldInfo data structure.
>>
>> The FieldInfo array is an old data structure storing fields metadata. It has
>> poor extension capabilities, a complex management code because of lack of
>
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Wed, 8 Mar 2023 15:50:05 GMT, Coleen Phillimore wrote:
>> Please review this change re-implementing the FieldInfo data structure.
>>
>> The FieldInfo array is an old data structure storing fields metadata. It has
>> poor extension capabilities, a complex management code because of lack of
>
On Wed, 8 Mar 2023 15:46:12 GMT, Coleen Phillimore wrote:
>> Please review this change re-implementing the FieldInfo data structure.
>>
>> The FieldInfo array is an old data structure storing fields metadata. It has
>> poor extension capabilities, a complex management code because of lack of
>
On Thu, 9 Mar 2023 16:44:21 GMT, Richard Reingruber wrote:
>> This looks cool.
>
>> This change should be in a further RFE though (and you can explain it there
>> so we can maybe use it in the other platforms too).
>
> Ok.
>
>> Does it affect performance when generating the template interprete
On Mon, 27 Feb 2023 21:37:34 GMT, Matias Saavedra Silva
wrote:
> The current structure used to store the resolution information for
> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
> ambigious fields f1 and f2. This structure can hold information for fields,
> met
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
Please review this small fix. A suspender is a Jvmti
On Thu, 2 Mar 2023 02:41:12 GMT, Alex Menkov wrote:
> Unique vtables for classes in vmStruct data is a requirement for SA to
> correctly detect hotspot classes.
> The fix adds test to verify this requirement.
>
> The test fails as expected on Windows if VM is built without RTTI (see
> JDK-8302
On Wed, 8 Mar 2023 18:25:15 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Mon, 30 Jan 2023 14:30:41 GMT, Roman Kennke wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 1336:
>>
>>> 1334: // Success! Return inflated monitor.
>>> 1335: if (own) {
>>> 1336: assert(current->is_Java_thread(), "must be: checked in
>>> is_lock_owned()");
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote:
> This patch modifies the `getLastErrorString` method to return a `jstring`.
> Thanks to that we can avoid unnecessary back and forth conversions between
> Unicode and other charsets on Windows.
>
> Other changes include:
> - the Windows
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
On Thu, 9 Mar 2023 16:01:21 GMT, Coleen Phillimore wrote:
>> This change should be in a further RFE though (and you can explain it there
>> so we can maybe use it in the other platforms too). Does it affect
>> performance when generating the template interpreter? Do you need to have
>> hsdis
On Thu, 9 Mar 2023 16:00:53 GMT, Coleen Phillimore wrote:
>> Yes this is really useful when debugging the template interpreter. It
>> annotates the disassembly with the generator source code. It helped tracking
>> down a bug in the ppc part oft this pr. Other platforms have it too.
>>
>> Examp
On Tue, 7 Mar 2023 15:04:29 GMT, Richard Reingruber wrote:
>> src/hotspot/cpu/ppc/templateTable_ppc_64.cpp line 53:
>>
>>> 51:
>>> 52: #undef __
>>> 53: #define __ Disassembler::hook(__FILE__,
>>> __LINE__, _masm)->
>>
>> What is this? Is this something useful for debugging the template
>>
On Tue, 7 Mar 2023 19:25:58 GMT, Matias Saavedra Silva
wrote:
>> src/hotspot/share/oops/cpCache.cpp line 727:
>>
>>> 725: set_reference_map(nullptr);
>>> 726: #if INCLUDE_CDS
>>> 727: if (_initial_entries != nullptr) {
>>
>> @iklam with moving invokedynamic entries out, do you still need t
On Mon, 6 Mar 2023 23:47:09 GMT, Leonid Mesnik wrote:
> Provide a way to start debugee threads as platform or virtual for debugee in
> com/sun/jdi tests.
This pull request has now been integrated.
Changeset: cdcf5c1e
Author:Leonid Mesnik
URL:
https://git.openjdk.org/jdk/commit/cdcf
On Tue, 7 Mar 2023 19:00:25 GMT, Leonid Mesnik wrote:
>> Provide a way to start debugee threads as platform or virtual for debugee in
>> com/sun/jdi tests.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed JdbStopThre
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
On Thu, 9 Mar 2023 09:36:28 GMT, Andrew Dinn wrote:
> Yes, I appreciate that `dynamic` can be derived from `initializationMethod`
> -- and vice versa. However, I was approaching this semantically from the
> opposite end. To me the primary characteristic that the user would be
> interested in i
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Wed, 8 Mar 2023 18:56:55 GMT, Markus Grönlund wr
On Thu, 9 Mar 2023 00:23:39 GMT, David Holmes wrote:
> > No need to load any JFR classes.
>
> I thought JFR was all Java-based these days. But if no Java involved then
> that is good.
Ehh, no. Far from it.
> > No change to startup logic.
>
> I flagged a change in my comment above.
Thanks, p
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Wed, 8 Mar 2023 22:56:31 GMT, David Holmes wrote
On Wed, 8 Mar 2023 23:28:52 GMT, Markus Grönlund wrote:
>> Markus Grönlund has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - remove JVMPI
>> - cleanup
>
> No need to load any JFR classes. No change to startup logic.
> @mgronlun Why mar
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Wed, 8 Mar 2023 23:28:52 GMT, Markus Grönlund wr
On Wed, 8 Mar 2023 23:23:33 GMT, Chris Plummer wrote:
>> This patch modifies the `getLastErrorString` method to return a `jstring`.
>> Thanks to that we can avoid unnecessary back and forth conversions between
>> Unicode and other charsets on Windows.
>>
>> Other changes include:
>> - the Wind
47 matches
Mail list logo
