On Thu, 9 Mar 2023 16:44:21 GMT, Richard Reingruber <rr...@openjdk.org> wrote:
>> This looks cool. > >> This change should be in a further RFE though (and you can explain it there >> so we can maybe use it in the other platforms too). > > Ok. > >> Does it affect performance when generating the template interpreter? > > I didn't think it would affect performance if the interpreter is not printed. > I have not measured it though. > >> Do you need to have hsdis in the LD_LIBRARY_PATH environment variable to use >> this? I see it's already used by default in one place. > > Yes you do. It is not working with the AbstractDisassembler which produces a > hex dump of the machine code. I was searching in the wrong directory, which is why I didn't find this and apparently I reviewed this change in 2018. We can leave this change here. Sorry for the noise. ------------- PR: https://git.openjdk.org/jdk/pull/12778
