Re: RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work [v4]

2023-06-27 Thread Matthias Baesken
On Tue, 27 Jun 2023 13:45:27 GMT, Matthias Baesken wrote: >> Currently, a number of tests fail on macOS because they miss the core file >> (e.g. serviceability/sa/TestJmapCore.java). >> The reason is that configure detects on some setups that codesign does not >> work ("checking if debug mode c

Integrated: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work

2023-06-27 Thread Matthias Baesken
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote: > Currently, a number of tests fail on macOS because they miss the core file > (e.g. serviceability/sa/TestJmapCore.java). > The reason is that configure detects on some setups that codesign does not > work ("checking if debug mode codes

Re: RFR: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit [v4]

2023-06-27 Thread Tom Rodriguez
On Tue, 27 Jun 2023 21:29:53 GMT, Doug Simon wrote: >> The VMSupport class is required for translating an exception between the >> HotSpot and libgraal heaps. >> Loading it lazily can result in a loading exception, obscuring the exception >> being translated. >> To avoid this, VMSupport is load

Re: RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v3]

2023-06-27 Thread Coleen Phillimore
On Tue, 27 Jun 2023 20:48:27 GMT, Coleen Phillimore wrote: >> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but >> I've added a pointer delta function in globalDefinitions.hpp to use for >> these pointer diff calculations that return int everywhere. If the name is >>

Re: RFR: JDK-8310066: Improve test coverage for JVMTI GetThreadState on carrier and mounted vthread [v2]

2023-06-27 Thread Alex Menkov
On Mon, 26 Jun 2023 20:57:44 GMT, Andrey Turbanov wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added spaces in synchronized > > test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadStateMountedTest/GetThreadS

Re: RFR: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit [v3]

2023-06-27 Thread Doug Simon
On Mon, 26 Jun 2023 13:17:25 GMT, Doug Simon wrote: >> The VMSupport class is required for translating an exception between the >> HotSpot and libgraal heaps. >> Loading it lazily can result in a loading exception, obscuring the exception >> being translated. >> To avoid this, VMSupport is load

Re: RFR: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit [v4]

2023-06-27 Thread Doug Simon
> The VMSupport class is required for translating an exception between the > HotSpot and libgraal heaps. > Loading it lazily can result in a loading exception, obscuring the exception > being translated. > To avoid this, VMSupport is loaded eagerly along with the other vmClasses. Doug Simon has

Re: RFR: JDK-8310066: Improve test coverage for JVMTI GetThreadState on carrier and mounted vthread [v2]

2023-06-27 Thread Alex Menkov
> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier > should return STATE_WAITING) > New test tests GetThreadState for different thread states. > The test detected a bug in the implementation, new issue is created: > JDK-8310584 > Corresponding testcases are commented now

Re: RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v3]

2023-06-27 Thread Coleen Phillimore
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but > I've added a pointer delta function in globalDefinitions.hpp to use for these > pointer diff calculations that return int everywhere. If the name is > agreeable, I'll fix the other cases of this like this. It's bet

Integrated: 8310585: GetThreadState spec mentions undefined JVMTI_THREAD_STATE_MONITOR_WAITING

2023-06-27 Thread Alex Menkov
On Fri, 23 Jun 2023 22:59:54 GMT, Alex Menkov wrote: > Trivial fix in JVMTI spec. > As it's just a typo, CSR is not required This pull request has now been integrated. Changeset: a97f98fb Author:Alex Menkov URL: https://git.openjdk.org/jdk/commit/a97f98fb8a933b43cd4485c3791ac8ca016b

Integrated: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x

2023-06-27 Thread Tom Rodriguez
On Tue, 20 Jun 2023 18:05:09 GMT, Tom Rodriguez wrote: > This is a minor fix to core file reading on macos x. I can confirm that > after this fix I can run the problem listed SA core file tests on Ventura. This pull request has now been integrated. Changeset: 269852b9 Author:Tom Rodriguez

Re: RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x [v4]

2023-06-27 Thread Tom Rodriguez
On Mon, 26 Jun 2023 18:09:24 GMT, Tom Rodriguez wrote: >> This is a minor fix to core file reading on macos x. I can confirm that >> after this fix I can run the problem listed SA core file tests on Ventura. > > Tom Rodriguez has updated the pull request incrementally with one additional > com

Re: RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work [v4]

2023-06-27 Thread Chris Plummer
On Tue, 27 Jun 2023 13:45:27 GMT, Matthias Baesken wrote: >> Currently, a number of tests fail on macOS because they miss the core file >> (e.g. serviceability/sa/TestJmapCore.java). >> The reason is that configure detects on some setups that codesign does not >> work ("checking if debug mode c

Re: jdwp virtual threads dump?

2023-06-27 Thread Egor Ushakov
Thanks Alan! for now there's no special support for virtual threads in IDEA, that's why I'm asking :) "Get Thread Dump" action gathers the information from the threads list provided by com.sun.jdi.VirtualMachine#allThreads. -Egor On 27.06.2023 18:24, Alan Bateman wrote: On 27/06/2023 16:5

Re: jdwp virtual threads dump?

2023-06-27 Thread Alan Bateman
On 27/06/2023 16:58, Egor Ushakov wrote: Hi all, is there a way for a debugger to create a virtual threads dump via jdwp? Right now, the only way to do this via JDWP is use the ObjectReference/InvokeMethod command (or JDI invokeMethod at the API level) to invoke HotSpotDiagnosticMXBean dumpT

jdwp virtual threads dump?

2023-06-27 Thread Egor Ushakov
Hi all, is there a way for a debugger to create a virtual threads dump via jdwp? Thanks, Egor

Re: RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v2]

2023-06-27 Thread Coleen Phillimore
On Tue, 27 Jun 2023 14:54:03 GMT, Coleen Phillimore wrote: >> src/hotspot/share/code/codeBlob.inline.hpp line 36: >> >>> 34: inline const ImmutableOopMap* CodeBlob::oop_map_for_slot(int slot, >>> address return_address) const { >>> 35: assert(_oop_maps != nullptr, "nope"); >>> 36: return _o

Re: RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v2]

2023-06-27 Thread Coleen Phillimore
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but > I've added a pointer delta function in globalDefinitions.hpp to use for these > pointer diff calculations that return int everywhere. If the name is > agreeable, I'll fix the other cases of this like this. It's bet

Re: RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files.

2023-06-27 Thread Coleen Phillimore
On Tue, 27 Jun 2023 12:59:59 GMT, Stefan Karlsson wrote: >> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but >> I've added a pointer delta function in globalDefinitions.hpp to use for >> these pointer diff calculations that return int everywhere. If the name is >> a

RFR: 8310948: Fix ignored-qualifiers warning in Hotspot

2023-06-27 Thread Daniel JeliƄski
Please review this attempt to fix ignored-qualifiers warning. Example warnings: src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier on return type has no effect [-Wignored-qualifiers] CompiledMethod* volatile code() const; ^ src/hotspot/sh

Re: RFR: 8309979: BootstrapMethods attribute is missing in class files recreated by SA [v2]

2023-06-27 Thread Ashutosh Mehra
On Fri, 16 Jun 2023 18:10:58 GMT, Chris Plummer wrote: >> Ashutosh Mehra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments by plummercj >> >> Signed-off-by: Ashutosh Mehra > > Yes, it is already problem listed

Re: RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work [v3]

2023-06-27 Thread Matthias Baesken
On Thu, 22 Jun 2023 11:51:15 GMT, Matthias Baesken wrote: >> Currently, a number of tests fail on macOS because they miss the core file >> (e.g. serviceability/sa/TestJmapCore.java). >> The reason is that configure detects on some setups that codesign does not >> work ("checking if debug mode c

Re: RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work [v4]

2023-06-27 Thread Matthias Baesken
> Currently, a number of tests fail on macOS because they miss the core file > (e.g. serviceability/sa/TestJmapCore.java). > The reason is that configure detects on some setups that codesign does not > work ("checking if debug mode codesign is possible... no) . > So adding the needed entitlement

Re: RFR: 8309979: BootstrapMethods attribute is missing in class files recreated by SA [v3]

2023-06-27 Thread Kevin Walls
On Thu, 22 Jun 2023 15:37:11 GMT, Ashutosh Mehra wrote: >> Please review this PR that extends SA to write BootstrapMethods attribute >> when dumping the class files. >> >> Tested it by dumping the class file for java/lang/String and comparing the >> BootstrapMethods attribute shown by javap fo

Re: RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files.

2023-06-27 Thread Stefan Karlsson
On Tue, 27 Jun 2023 12:41:50 GMT, Coleen Phillimore wrote: > This is another version of PR https://github.com/openjdk/jdk/pull/14659 but > I've added a pointer delta function in globalDefinitions.hpp to use for these > pointer diff calculations that return int everywhere. If the name is > agr

Re: RFR: 8309979: BootstrapMethods attribute is missing in class files recreated by SA [v2]

2023-06-27 Thread Ashutosh Mehra
On Thu, 22 Jun 2023 16:10:13 GMT, Ashutosh Mehra wrote: > I am thinking of a comprehensive test that creates a classfile with specific > attribute, load it in the VM, dump that class file using SA, then disassemble > the generated class file to check for the presence of the attribute. We would

RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files.

2023-06-27 Thread Coleen Phillimore
This is another version of PR https://github.com/openjdk/jdk/pull/14659 but I've added a pointer delta function in globalDefinitions.hpp to use for these pointer diff calculations that return int everywhere. If the name is agreeable, I'll fix the other cases of this like this. It's better than