On Thu, 11 Jul 2024 18:06:34 GMT, Albert Mingkun Yang wrote:
>> Similar cleanup as https://github.com/openjdk/jdk/pull/19056 but in
>> Parallel. As a result, the corresponding code in `SerialHeap` and
>> `ParallelScavengeHeap` share much similarity.
>>
>> The easiest way to review is to start
On Thu, 11 Jul 2024 15:40:01 GMT, Guoxiong Li wrote:
>> Albert Mingkun Yang has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains th
On Thu, 11 Jul 2024 18:09:24 GMT, Albert Mingkun Yang wrote:
>> src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp line 478:
>>
>>> 476:
>>> 477: const bool clear_all_soft_refs = true;
>>> 478: do_full_collection_no_gc_locker(clear_all_soft_refs);
>>
>> If the young collection succ
On Thu, 11 Jul 2024 14:39:47 GMT, Guoxiong Li wrote:
>> Albert Mingkun Yang has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains th
On Wed, 10 Jul 2024 20:29:37 GMT, Albert Mingkun Yang wrote:
>> Similar cleanup as https://github.com/openjdk/jdk/pull/19056 but in
>> Parallel. As a result, the corresponding code in `SerialHeap` and
>> `ParallelScavengeHeap` share much similarity.
>>
>> The easiest way to review is to start
On Wed, 8 May 2024 10:04:15 GMT, Albert Mingkun Yang wrote:
>> It's probably easier to read the new code directly. The two classes in
>> `serialVMOperations` serve as entrance points to invoke young/full GCs. Some
>> previously hidden decisions are made more obvious, e.g. if a young-gc fails
>
On Mon, 6 May 2024 09:12:47 GMT, Albert Mingkun Yang wrote:
>> src/hotspot/share/gc/serial/serialHeap.cpp line 461:
>>
>>> 459: if (should_verify && VerifyBeforeGC) {
>>> 460: prepare_for_verify();
>>> 461: Universe::verify("Before GC");
>>
>> May the prefix of the verification log be
On Fri, 3 May 2024 12:49:03 GMT, Albert Mingkun Yang wrote:
>> It's probably easier to read the new code directly. The two classes in
>> `serialVMOperations` serve as entrance points to invoke young/full GCs. Some
>> previously hidden decisions are made more obvious, e.g. if a young-gc fails
>
On Thu, 2 May 2024 14:40:35 GMT, Aleksey Shipilev wrote:
> `CollectedHeap::is_gc_active()` is confusing, since its name implies _any_ GC
> phase is running, while it actually only covers the STW GCs. It would be good
> to rename it for clarity. The freed-up name, `is_gc_active` could then be
>
On Tue, 23 Apr 2024 17:22:41 GMT, Guoxiong Li wrote:
>> Hi all,
>>
>> This patch removes the class `TenuredSpace` and adjusts its usages. After
>> removing `TenuredSpace`, the file `space.inline.hpp` is empty, so I remove
>> this file and change the incl
On Mon, 22 Apr 2024 16:24:06 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch removes the class `TenuredSpace` and adjusts its usages. After
> removing `TenuredSpace`, the file `space.inline.hpp` is empty, so I remove
> this file and change the included header file to `space
On Tue, 23 Apr 2024 17:22:41 GMT, Guoxiong Li wrote:
>> Hi all,
>>
>> This patch removes the class `TenuredSpace` and adjusts its usages. After
>> removing `TenuredSpace`, the file `space.inline.hpp` is empty, so I remove
>> this file and change the incl
d locally. Thanks for taking the time to
> review.
>
> Best Regards,
> -- Guoxiong
Guoxiong Li has updated the pull request incrementally with one additional
commit since the last revision:
Fix included header file error after merging master.
-
Changes:
- all: https
d locally. Thanks for taking the time to
> review.
>
> Best Regards,
> -- Guoxiong
Guoxiong Li has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- Remove file.
- Merge branch 'master' into REMOVE_TE
Hi all,
This patch removes the class `TenuredSpace` and adjusts its usages. After
removing `TenuredSpace`, the file `space.inline.hpp` is empty, so I remove this
file and change the included header file to `space.hpp`.
The test `make test-tier1_gc` passed locally. Thanks for taking the time to
On Fri, 8 Mar 2024 02:54:49 GMT, Alex Menkov wrote:
> RecordComponent class has _attributes_count field.
> The only user of the field is JvmtiClassFileReconstituter. Incorrect value of
> the field causes producing incorrect data for Record attribute.
> Parsing Record attribute ClassFileParser sk
On Thu, 7 Mar 2024 07:20:15 GMT, David Holmes wrote:
> Oracle requests/requires that the Oracle copyright always be updated when a
> file is modified.
Got it. Thanks for your explanation.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1515672685
On Wed, 6 Mar 2024 16:30:23 GMT, Matthias Baesken wrote:
>> We define the RESTARTABLE macro again and again at a lot of places in the
>> JDK native codebase. This could be centralized to avoid repeating it again
>> and again !
>
> Matthias Baesken has updated the pull request incrementally with
On Wed, 6 Mar 2024 09:26:25 GMT, Matthias Baesken wrote:
> We define the RESTARTABLE macro again and again at a lot of places in the JDK
> native codebase. This could be centralized to avoid repeating it again and
> again !
Looks good. Nice refactor.
-
Marked as reviewed by gli (
On Thu, 29 Feb 2024 00:16:28 GMT, Kim Barrett wrote:
>> Please review this change that renames some test .h files to .hpp. These
>> files contain C++ code and should be named accordingly. Some of them contain
>> uses of NULL, which we change to nullptr.
>>
>> The renamed files are:
>>
>> test
On Wed, 28 Feb 2024 01:18:50 GMT, Kim Barrett wrote:
> Please review this change that renames some test .h files to .hpp. These
> files contain C++ code and should be named accordingly. Some of them contain
> uses of NULL, which we change to nullptr.
>
> The renamed files are:
>
> test/hotspo
On Thu, 11 May 2023 18:32:36 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch revises the code of `ps_proc.c::process_get_lwp_regs`
> to use `PTRACE_GETREGSET` first instead of `PTRACE_GETREGS`.
> The `PTRACE_GETREGS` is not present on all architectures as the man page
> st
On Tue, 16 May 2023 05:39:05 GMT, Chris Plummer wrote:
>> Hi all,
>>
>> This patch revises the code of `ps_proc.c::process_get_lwp_regs`
>> to use `PTRACE_GETREGSET` first instead of `PTRACE_GETREGS`.
>> The `PTRACE_GETREGS` is not present on all architectures as the man page
>> states [1].
>>
On Tue, 16 May 2023 05:39:05 GMT, Chris Plummer wrote:
>> Hi all,
>>
>> This patch revises the code of `ps_proc.c::process_get_lwp_regs`
>> to use `PTRACE_GETREGSET` first instead of `PTRACE_GETREGS`.
>> The `PTRACE_GETREGS` is not present on all architectures as the man page
>> states [1].
>>
Hi all,
This patch revises the code of `ps_proc.c::process_get_lwp_regs`
to use `PTRACE_GETREGSET` first instead of `PTRACE_GETREGS`.
The `PTRACE_GETREGS` is not present on all architectures as the man page states
[1].
And if we use `PTRACE_GETREGS` first, several tests will fail at the special
25 matches
Mail list logo
