On Tue, 14 Mar 2023 01:25:01 GMT, Chris Plummer wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes includes and style
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Field.java line 75:
>
>> 73:
On Tue, 14 Mar 2023 15:10:04 GMT, Doug Simon wrote:
>> Access to internal modifiers is needed in
>> `HotSpotResolvedJavaFieldTest.testEquivalenceForInternalFields()`. I moved
>> the declaration of the method to `HotSpotResolvedJavaField`. Does this
>> change work for you?
>
> Just use reflecti
On Tue, 14 Mar 2023 15:11:36 GMT, Doug Simon wrote:
>> Without this declaration, builds fail on Windows with this error:
>> `error C2375: 'c2v_getDeclaredFieldsInfo': redefinition; different linkage`
>
> Strange - thats not needed for other `JVMCIEnv` methods called from
> `jvmciCompilerToVM.cpp
On Tue, 14 Mar 2023 13:37:23 GMT, Frederic Parain wrote:
>> src/hotspot/share/jvmci/jvmciEnv.hpp line 149:
>>
>>> 147: };
>>> 148:
>>> 149: extern JNIEXPORT jobjectArray c2v_getDeclaredFieldsInfo(JNIEnv* env,
>>> jobject, jobject, jlong);
>>
>> What's the purpose of this declaration? I don't
On Tue, 14 Mar 2023 13:12:31 GMT, Frederic Parain wrote:
>> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaField.java
>> line 48:
>>
>>> 46: * Returns VM internal flags associated with this field
>>> 47: */
>>> 48: int getInternalModifiers();
>>
>> We've never ex
On Mon, 13 Mar 2023 21:35:17 GMT, Doug Simon wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes includes and style
>
> src/hotspot/share/jvmci/jvmciEnv.hpp line 149:
>
>> 147: };
>> 148:
>> 149: extern JNIE
On Mon, 13 Mar 2023 21:44:59 GMT, Doug Simon wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes includes and style
>
> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 416:
>
>> 414: declare_constant(Field
On Mon, 13 Mar 2023 21:53:37 GMT, Doug Simon wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes includes and style
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaField.java
> line 48:
>
On Mon, 13 Mar 2023 18:51:17 GMT, Frederic Parain wrote:
>> Please review this change re-implementing the FieldInfo data structure.
>>
>> The FieldInfo array is an old data structure storing fields metadata. It has
>> poor extension capabilities, a complex management code because of lack of
>>
On Mon, 13 Mar 2023 18:51:17 GMT, Frederic Parain wrote:
>> Please review this change re-implementing the FieldInfo data structure.
>>
>> The FieldInfo array is an old data structure storing fields metadata. It has
>> poor extension capabilities, a complex management code because of lack of
>>
On Mon, 13 Mar 2023 18:51:17 GMT, Frederic Parain wrote:
>> Please review this change re-implementing the FieldInfo data structure.
>>
>> The FieldInfo array is an old data structure storing fields metadata. It has
>> poor extension capabilities, a complex management code because of lack of
>>
On Mon, 13 Mar 2023 18:51:17 GMT, Frederic Parain wrote:
>> Please review this change re-implementing the FieldInfo data structure.
>>
>> The FieldInfo array is an old data structure storing fields metadata. It has
>> poor extension capabilities, a complex management code because of lack of
>>
> Please review this change re-implementing the FieldInfo data structure.
>
> The FieldInfo array is an old data structure storing fields metadata. It has
> poor extension capabilities, a complex management code because of lack of
> strong typing and semantic overloading, and a poor memory effic
13 matches
Mail list logo