On Tue, 14 Mar 2023 13:37:23 GMT, Frederic Parain <fpar...@openjdk.org> wrote:

>> src/hotspot/share/jvmci/jvmciEnv.hpp line 149:
>> 
>>> 147: };
>>> 148: 
>>> 149: extern JNIEXPORT jobjectArray c2v_getDeclaredFieldsInfo(JNIEnv* env, 
>>> jobject, jobject, jlong);
>> 
>> What's the purpose of this declaration? I don't think you need it or the 
>> `friend` declaration below since `new_FieldInfo(FieldInfo* fieldinfo, 
>> JVMCI_TRAPS)` is public.
>
> Without this declaration, builds fail on Windows with this error:
> `error C2375: 'c2v_getDeclaredFieldsInfo': redefinition; different linkage`

Strange - thats not needed for other `JVMCIEnv` methods called from 
`jvmciCompilerToVM.cpp`. There must be some way to avoid this.

-------------

PR: https://git.openjdk.org/jdk/pull/12855

Reply via email to