On Mon, 13 Mar 2023 21:35:17 GMT, Doug Simon <dnsi...@openjdk.org> wrote:
>> Frederic Parain has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixes includes and style > > src/hotspot/share/jvmci/jvmciEnv.hpp line 149: > >> 147: }; >> 148: >> 149: extern JNIEXPORT jobjectArray c2v_getDeclaredFieldsInfo(JNIEnv* env, >> jobject, jobject, jlong); > > What's the purpose of this declaration? I don't think you need it or the > `friend` declaration below since `new_FieldInfo(FieldInfo* fieldinfo, > JVMCI_TRAPS)` is public. Without this declaration, builds fail on Windows with this error: `error C2375: 'c2v_getDeclaredFieldsInfo': redefinition; different linkage` ------------- PR: https://git.openjdk.org/jdk/pull/12855
