On Thu, 1 Feb 2024 05:42:07 GMT, David Holmes wrote:
>> Hello David, I had actually first put it in that line you noted, but that
>> then lead to a compilation error:
>>
>>
>> In file included from
>> /jdk/src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:33:
>> /jdk/src/jdk.jdwp.agent/share/n
On Wed, 31 Jan 2024 07:52:18 GMT, Jaikiran Pai wrote:
>> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 35:
>>
>>> 33: #include "sys.h"
>>> 34: #include "util.h"
>>> 35: #include "error_messages.h"
>>
>> Nit: to maintain include sort order this should have gone where
>> `log_messages.h`
On Wed, 31 Jan 2024 08:01:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Wed, 31 Jan 2024 08:01:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Wed, 31 Jan 2024 08:01:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iterates over an extremely large
> number of file descripto
On Wed, 31 Jan 2024 06:28:05 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Chris' review suggestion - replace LOG_MISC with ERROR_MESSAGE
>
> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c lin
On Wed, 31 Jan 2024 06:27:33 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Chris' review suggestion - replace LOG_MISC with ERROR_MESSAGE
>
> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c lin
On Wed, 31 Jan 2024 01:46:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Wed, 31 Jan 2024 01:46:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Wed, 31 Jan 2024 01:46:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Tue, 30 Jan 2024 19:41:48 GMT, Chris Plummer wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> assert that we don't pass values higher than INT_MAX to close()
>
> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c l
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iterates over an extremely large
> number of file descripto
On Tue, 30 Jan 2024 16:17:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Tue, 30 Jan 2024 16:17:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Tue, 30 Jan 2024 16:15:17 GMT, Jaikiran Pai wrote:
>>> If we are going to check close for errors then we will have to know for
>>> certain we are only trying to close open fd's, and we will have to deal
>>> with EINTR. I would think this is a "best effort" to close open FD's and
>>> not som
On Tue, 30 Jan 2024 16:17:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Tue, 30 Jan 2024 06:52:49 GMT, David Holmes wrote:
>> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 129:
>>
>>> 127: /* Find max allowed file descriptors for a process
>>> 128: * and assume all were opened for the parent process and
>>> 129: * copied over to
On Mon, 29 Jan 2024 17:45:34 GMT, Gerard Ziemski wrote:
>> Hello Gerard, my understanding is that the limit value configured may exceed
>> the int range. I wanted to avoid the overflow by casting it to int in such
>> cases. I had noticed close() takes an int, but I couldn't think of any other
On Tue, 30 Jan 2024 07:14:45 GMT, Alan Bateman wrote:
>> If we are going to check close for errors then we will have to know for
>> certain we are only trying to close open fd's, and we will have to deal with
>> EINTR. I would think this is a "best effort" to close open FD's and not
>> somethi
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iterates over an extremely large
> number of file descripto
On Tue, 30 Jan 2024 06:47:38 GMT, David Holmes wrote:
> If we are going to check close for errors then we will have to know for
> certain we are only trying to close open fd's, and we will have to deal with
> EINTR. I would think this is a "best effort" to close open FD's and not
> something w
On Mon, 29 Jan 2024 10:00:37 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Mon, 29 Jan 2024 19:25:35 GMT, Chris Plummer wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - add a log message to help debuggability
>> - improve code comments
>> - David's review - use standard isdigit in
On Mon, 29 Jan 2024 19:21:05 GMT, Chris Plummer wrote:
>> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 108:
>>
>>> 106: if (isdigit(dirp->d_name[0]) &&
>>> 107: (fd = strtol(dirp->d_name, NULL, 10)) >= from_fd) {
>>> 108: (void)close(fd);
>>
>> I'd reall
On Mon, 29 Jan 2024 10:00:37 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Mon, 29 Jan 2024 17:51:36 GMT, Gerard Ziemski wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - add a log message to help debuggability
>> - improve code comments
>> - David's review - use standard isdigit i
On Sat, 27 Jan 2024 01:18:09 GMT, Jaikiran Pai wrote:
>> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 129:
>>
>>> 127: * and assume all were opened for the parent process and
>>> 128: * copied over to this child process. we close them all */
>>> 129: const rlim
On Mon, 29 Jan 2024 10:00:37 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Mon, 29 Jan 2024 04:36:35 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - log a warning message if we fallback to slower logic of closing file
>> descriptors
>> - ignore return values, cast
On Sat, 27 Jan 2024 13:09:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iterates over an extremely large
> number of file descripto
On Sat, 27 Jan 2024 13:09:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Sat, 27 Jan 2024 13:06:59 GMT, Jaikiran Pai wrote:
>> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 112:
>>
>>> 110: }
>>> 111:
>>> 112: closedir(dp);
>>
>> Should this be:
>>
>> `(void)close(fd);`
>>
>> and
>>
>> `(void)closedir(dp);`
>>
>> to show that we're ignoring
On Fri, 26 Jan 2024 17:33:39 GMT, Gerard Ziemski wrote:
> Have you considered using `fcntl(d, F_SETFD, 1)` instead of the fancy
> `closeDescriptors()`?
>
> I haven't tested it myself, but per the `man close` page:
>
> ```
> Most of the descriptors can be rearranged with dup2(2) or deleted with
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iterates over an extremely large
> number of file descripto
On Fri, 26 Jan 2024 17:29:10 GMT, Gerard Ziemski wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use the right include for rlim_t -
>
> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 129:
>
>> 127:
On Fri, 26 Jan 2024 15:57:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Fri, 26 Jan 2024 15:57:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Fri, 26 Jan 2024 15:57:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Fri, 26 Jan 2024 15:57:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iterates over an extremely large
> number of file descripto
On Fri, 26 Jan 2024 14:52:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iter
On Fri, 26 Jan 2024 14:52:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iter
On Fri, 26 Jan 2024 14:52:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> The JVM can be launched with the `jdwp` agent, like
> `-agentlib:jdwp=transport=xxx,server=y`. Among other options to th
Can I please get a review of this change which proposes to address
https://bugs.openjdk.org/browse/JDK-8324668?
The JVM can be launched with the `jdwp` agent, like
`-agentlib:jdwp=transport=xxx,server=y`. Among other options to the `jdwp`
agentlib, one option is the `launch` option, which is of
46 matches
Mail list logo
