Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v4]

2024-07-22 Thread duke
On Sat, 20 Jul 2024 06:33:09 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v4]

2024-07-22 Thread Daniel Lundén
On Sat, 20 Jul 2024 06:33:09 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v4]

2024-07-20 Thread Chris Plummer
On Sat, 20 Jul 2024 06:33:09 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v4]

2024-07-19 Thread Daniel Lundén
> We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDumpheap.java` with -Xcomp, at least for now. > > ### Change

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v3]

2024-07-19 Thread Daniel Lundén
On Fri, 19 Jul 2024 16:49:56 GMT, Chris Plummer wrote: > Copyright needs updating. Thanks, done. - PR Comment: https://git.openjdk.org/jdk/pull/20237#issuecomment-2240950444

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v3]

2024-07-19 Thread Chris Plummer
On Fri, 19 Jul 2024 11:50:03 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v3]

2024-07-19 Thread Vladimir Kozlov
On Fri, 19 Jul 2024 11:50:03 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v3]

2024-07-19 Thread Tobias Hartmann
On Fri, 19 Jul 2024 11:50:03 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Daniel Lundén
On Fri, 19 Jul 2024 10:42:00 GMT, Tobias Hartmann wrote: >> Can/should I include the bug number in some other way (perhaps directly in >> the comment)? I'm thinking if someone reads the comment in the future and >> would like more details. > > I don't think that's necessary, one can always find

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v3]

2024-07-19 Thread Daniel Lundén
> We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDumpheap.java` with -Xcomp, at least for now. > > ### Change

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Tobias Hartmann
On Fri, 19 Jul 2024 09:50:43 GMT, Daniel Lundén wrote: >> test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 40: >> >>> 38: /** >>> 39: * @test >>> 40: * @bug 8240989 8336753 >> >> I don't think that change makes sense because the test is not a regression >> test for JDK-8336753.

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Daniel Lundén
On Fri, 19 Jul 2024 09:45:19 GMT, Tobias Hartmann wrote: >> Daniel Lundén has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add comment and bug number > > test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 40: > >> 38: /** >> 3

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Tobias Hartmann
On Fri, 19 Jul 2024 09:31:01 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-19 Thread Daniel Lundén
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDump

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Daniel Lundén
> We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDumpheap.java` with -Xcomp, at least for now. > > ### Change

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-19 Thread Tobias Hartmann
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDump

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Vladimir Kozlov
On Thu, 18 Jul 2024 21:16:12 GMT, Chris Plummer wrote: > Given that there is no inherent incompatibility with `-Xcomp` and the test is > capable of running with `-Xcomp`, I suggest that you add an `@comment` before > the `@require` stating why it shouldn't be run with `-Xcomp`. Agree. ---

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Chris Plummer
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDump

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Vladimir Kozlov
On Thu, 18 Jul 2024 20:22:47 GMT, Chris Plummer wrote: > Does not running with `-Xcomp` mean not running it with graal? `-Xcomp` is not related to graal at all. It triggers all JIT compilers compilation for each called Java method. And Java thread waits until compilation is finished. It is ver

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Chris Plummer
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDump

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Vladimir Kozlov
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDump

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Vladimir Kozlov
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDump

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Chris Plummer
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDump

RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Daniel Lundén
We are seeing quite a few timeouts for `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, possibly related to [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable running `ClhsdbDumpheap.java` with -Xcomp, at least for now. ### Changeset - Add `@re