Running indidivual integration tests quickly (was: Running tests in eclipse?)

2009-04-24 Thread Bertrand Delacretaz
On Fri, Apr 24, 2009 at 9:11 PM, Aaron Zeckoski wrote: > ...mvn clean install -fbase/pom.xml > mvndebug install -ftesting/pom.xml > > Perhaps not an ideal solution but for developing the launchpad and > debugging it works well enough Note that you can run the launchpad/testing and launchpad/c

Re: Adding non-integration tests for the launchpad code

2009-04-24 Thread Bertrand Delacretaz
On Fri, Apr 24, 2009 at 9:18 PM, Aaron Zeckoski wrote: > ...I am pretty sure the code is being exercised by the > integration tests since they are all working but I would be more > comfortable if there were unit tests in place as well. Agree 100%, go for it! > ... It would make > the patch much

Re: Adding non-integration tests for the launchpad code

2009-04-24 Thread Aaron Zeckoski
> Are you referring to SLING-922 ? In this case, I would assume, the unit > tests go into the launchpad/base module ? Yeah, this is what I was thinking. I don't want to mix them with the integration tests. :-) -AZ On Fri, Apr 24, 2009 at 8:28 PM, Felix Meschberger wrote: > Hi Aaron, > > Are you

Re: Mixed line endings.

2009-04-24 Thread Ian Boston
On 24 Apr 2009, at 20:36, Jukka Zitting wrote: I just added svn:eol-style settings to quite a few files in Sling. I'm not sure how well those settings are reflected in Git, but you may want to try rebasing your local changes to the latest changes from svn. yes, looks like everything came thro

[jira] Closed: (SLING-942) Have JSONArray.getJSONObject(int) construct JSONObject if value is String

2009-04-24 Thread Carl Hall (JIRA)
[ https://issues.apache.org/jira/browse/SLING-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Hall closed SLING-942. --- > Have JSONArray.getJSONObject(int) construct JSONObject if value is String >

[jira] Resolved: (SLING-942) Have JSONArray.getJSONObject(int) construct JSONObject if value is String

2009-04-24 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-942. - Resolution: Fixed Fix Version/s: Commons JSON 2.0.4 Thanks for providing the initia

[jira] Commented: (SLING-942) Have JSONArray.getJSONObject(int) construct JSONObject if value is String

2009-04-24 Thread Carl Hall (JIRA)
[ https://issues.apache.org/jira/browse/SLING-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702508#action_12702508 ] Carl Hall commented on SLING-942: - Looks good to me. Thanks for extending the patch to getJ

[jira] Updated: (SLING-942) Have JSONArray.getJSONObject(int) construct JSONObject if value is String

2009-04-24 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated SLING-942: Attachment: SLING-942-fmeschbe.patch Modified patch, which applies the same logic to the get

[jira] Assigned: (SLING-942) Have JSONArray.getJSONObject(int) construct JSONObject if value is String

2009-04-24 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reassigned SLING-942: --- Assignee: Felix Meschberger > Have JSONArray.getJSONObject(int) construct JSONObject i

Re: Mixed line endings.

2009-04-24 Thread Jukka Zitting
Hi, On Thu, Apr 23, 2009 at 5:08 PM, Ian Boston wrote: > Isn't that normally put in ~/.subversion/config > or does its presence there add it to the file of first commit ? Yes, all committers should have settings like http://www.apache.org/dev/svn-eol-style.txt in their Subversion config file. Th

Re: Adding non-integration tests for the launchpad code

2009-04-24 Thread Felix Meschberger
Hi Aaron, Are you referring to SLING-922 ? In this case, I would assume, the unit tests go into the launchpad/base module ? So putting them into src/test/java would be just fine. Im am not sure, whether we should include unit tests for the launchpad/base module in the launchpad/testing module. T

[jira] Commented: (SLING-939) Adapt the Http Authenticator to the refined authentication process

2009-04-24 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702487#action_12702487 ] Felix Meschberger commented on SLING-939: - Adapted LoginServlet to new NoAuthenticat

[jira] Commented: (SLING-938) Refine initiaition of the authentication process

2009-04-24 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702486#action_12702486 ] Felix Meschberger commented on SLING-938: - Added the NoAuthenticationHandlerExceptio

Re: Running tests in eclipse?

2009-04-24 Thread Felix Meschberger
Hi, Aaron Zeckoski schrieb: > I meant any tests but it is possible that the ones I tried were > integration tests only. I was trying to run the launchpad tests to Yes, the tests in launchpad/testing are all integration tests. > figure out what silly thing I had done wrong. I ended up resorting t

Re: Running tests in eclipse?

2009-04-24 Thread Aaron Zeckoski
I meant any tests but it is possible that the ones I tried were integration tests only. I was trying to run the launchpad tests to figure out what silly thing I had done wrong. I ended up resorting to simply building and running the tests like so: cd launchpad mvn clean install -fbase/pom.xml mvnde

Adding non-integration tests for the launchpad code

2009-04-24 Thread Aaron Zeckoski
I would like to add a few unit tests to the launchpad code which I am updating with a patch. It seems like I would need to create a new test folder and package structure so before I do it I wanted to see if this was ok. I am pretty sure the code is being exercised by the integration tests since the

[jira] Reopened: (SLING-938) Refine initiaition of the authentication process

2009-04-24 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reopened SLING-938: - Need a slight extension to the login method: There may be the situation that no Authenticatio

Re: Running tests in eclipse?

2009-04-24 Thread Felix Meschberger
Hi Aaron, Aaron Zeckoski schrieb: > I am having trouble getting the tests to run while in eclipse. Does > anyone else have this working and if so, can you post the process you > might have used for getting the project imported into eclipse. Do you mean the integration tests ? You should be able

Running tests in eclipse?

2009-04-24 Thread Aaron Zeckoski
I am having trouble getting the tests to run while in eclipse. Does anyone else have this working and if so, can you post the process you might have used for getting the project imported into eclipse. Apologies if this is documented somewhere, RTFM is appropriate if so. :-) -AZ -- Aaron Zeckoski

Re: Unified system for tags

2009-04-24 Thread Juan José Vázquez Delgado
Interesting approach. Good enough from my pont of view. BR, Juanjo. On Fri, Apr 24, 2009 at 7:26 PM, Alexander Klimetschek wrote: > On Fri, Apr 24, 2009 at 6:32 PM, Bertrand Delacretaz > wrote: >> 2009/4/24 Juan José Vázquez Delgado : ...See also rule 5 of David's model [2]. >>> >>> Right

Re: Unified system for tags

2009-04-24 Thread Alexander Klimetschek
On Fri, Apr 24, 2009 at 6:32 PM, Bertrand Delacretaz wrote: > 2009/4/24 Juan José Vázquez Delgado : >>> ...See also rule 5 of David's model [2]. >> >> Right, but if tags are deleted or their names modified you´re forced >> to search the path tag properties over all the repository and fix the >> af

Re: Unified system for tags

2009-04-24 Thread Alexander Klimetschek
2009/4/24 Juan José Vázquez Delgado : >> Sounds good, and as Felix says I just wrote a blog entry about this >> yesterday [2]. From that you can see that in Day's cq5 the tags are a >> hierarchy of nodes under /etc/tags, with a specific node type, so a >> tag is indeed a separate resource. > > Bert

Re: Unified system for tags

2009-04-24 Thread Juan José Vázquez Delgado
> It's a drawback, but we feel the advantages (content agility) outweigh > the drawbacks (need to handle some rare stuff at the application > level). Pros vs cons. Ok, good!. Juanjo.

Re: Unified system for tags

2009-04-24 Thread Bertrand Delacretaz
2009/4/24 Juan José Vázquez Delgado : >> ...See also rule 5 of David's model [2]. > > Right, but if tags are deleted or their names modified you´re forced > to search the path tag properties over all the repository and fix the > affected nodes. It seems an important drawback. WDYT?... It's a drawb

Re: Unified system for tags

2009-04-24 Thread Juan José Vázquez Delgado
> Because references a) don't scale at the moment with Jackrabbit Is this a core design constraint or intended to be improved in future Jackrabbit releases?. > and b) hard references make your content very unflexible regarding partial > copying etc. As Bertrand explains it in his post [1]: > > >

Re: Unified system for tags

2009-04-24 Thread Juan José Vázquez Delgado
> Sounds good, and as Felix says I just wrote a blog entry about this > yesterday [2]. From that you can see that in Day's cq5 the tags are a > hierarchy of nodes under /etc/tags, with a specific node type, so a > tag is indeed a separate resource. Bertrand, just a question. You decided not to use

Re: Unified system for tags

2009-04-24 Thread Juan José Vázquez Delgado
>> ...That is a nice feature but IMHO is more suitable for specific use >> cases, such as CMS systems, than for Sling itself > > IMHO that shouldn't prevent implementing it under contrib - not all > Sling users will need it, but using Sling for CMSish apps is certainly > a common use case. Yep

[jira] Updated: (SLING-942) Have JSONArray.getJSONObject(int) construct JSONObject if value is String

2009-04-24 Thread Carl Hall (JIRA)
[ https://issues.apache.org/jira/browse/SLING-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Hall updated SLING-942: Attachment: sling-942.diff Attaching a patch that performs the requested feature change. > Have JSONArray.g

[jira] Created: (SLING-942) Have JSONArray.getJSONObject(int) construct JSONObject if value is String

2009-04-24 Thread Carl Hall (JIRA)
Have JSONArray.getJSONObject(int) construct JSONObject if value is String - Key: SLING-942 URL: https://issues.apache.org/jira/browse/SLING-942 Project: Sling Issue Type

[jira] Resolved: (SLING-941) Lots of svn:eol-style settings missing

2009-04-24 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/SLING-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting resolved SLING-941. - Resolution: Fixed Assignee: Jukka Zitting I fixed all the missing svn:eol-styles I could fin

Re: Unified system for tags

2009-04-24 Thread Alexander Klimetschek
On Fri, Apr 24, 2009 at 3:03 PM, Vidar Ramdal wrote: > For a start, the bundle could contain this: > > - Script/servlet for retrieving a tag's meta-info (/tags/tagname) > (at least as an example - users would want to create their own script) > > - Script/servlet for retrieving content tagged with

Re: Unified system for tags

2009-04-24 Thread Vidar Ramdal
2009/4/23 Vidar Ramdal : > These are just some loose thoughts that have been brewing in my mind > lately, after reading Richardson/Ruby: RESTful Web Services [1]. > > In order to make Sling (even) more buzzword compliant, I have been > thinking about a system for tags. > 2009/4/24 Juan José Vázque

[jira] Created: (SLING-941) Lots of svn:eol-style settings missing

2009-04-24 Thread Jukka Zitting (JIRA)
Lots of svn:eol-style settings missing -- Key: SLING-941 URL: https://issues.apache.org/jira/browse/SLING-941 Project: Sling Issue Type: Improvement Components: General Reporter: Jukk

Re: Unified system for tags

2009-04-24 Thread Alexander Klimetschek
On Fri, Apr 24, 2009 at 9:37 AM, Vidar Ramdal wrote: > There's one thing: It might be useful to let a tag (or a set of tags) > only be available for a certain branch of the resource tree. > Especially if a repository is hosting content for several independent > websites, you'd want each website to

Re: Getting the sling home?

2009-04-24 Thread Carsten Ziegeler
Aaron Zeckoski wrote: > In fact, I only need it as part of the lauchpad (the > BootstrapInstaller) so maybe it is still fine. It is for this issue: > https://issues.apache.org/jira/browse/SLING-922 Ah, ok, it should be fine then :) Carsten -- Carsten Ziegeler cziege...@apache.org

[jira] Commented: (SLING-922) Load modules on startup from an external directory

2009-04-24 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702324#action_12702324 ] Felix Meschberger commented on SLING-922: - ad 1) To the contrary: I would check befo

[jira] Commented: (SLING-922) Load modules on startup from an external directory

2009-04-24 Thread Aaron Zeckoski (JIRA)
[ https://issues.apache.org/jira/browse/SLING-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702321#action_12702321 ] Aaron Zeckoski commented on SLING-922: -- 1) OK, so no checking before copying then? 2) S

[jira] Commented: (SLING-922) Load modules on startup from an external directory

2009-04-24 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702317#action_12702317 ] Felix Meschberger commented on SLING-922: - ad 1): With respect to copying bundles ou

Re: Getting the sling home?

2009-04-24 Thread Aaron Zeckoski
In fact, I only need it as part of the lauchpad (the BootstrapInstaller) so maybe it is still fine. It is for this issue: https://issues.apache.org/jira/browse/SLING-922 -AZ On Fri, Apr 24, 2009 at 11:16 AM, Carsten Ziegeler wrote: > Aaron Zeckoski wrote: >> String home = bundleContext.getProper

[jira] Commented: (SLING-922) Load modules on startup from an external directory

2009-04-24 Thread Aaron Zeckoski (JIRA)
[ https://issues.apache.org/jira/browse/SLING-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702314#action_12702314 ] Aaron Zeckoski commented on SLING-922: -- A few notes as I am going through this: 1) It i

Re: Getting the sling home?

2009-04-24 Thread Carsten Ziegeler
Aaron Zeckoski wrote: > String home = bundleContext.getProperty("sling.home"); > This property is only available when you're using the Sling launchpad. Once you deploy Sling into another OSGi container or use a different startup method for the container, it's not availabel! So, maybe there is a b

Re: AccessControlManager question.

2009-04-24 Thread Vidar Ramdal
2009/4/24 Ian Boston : > Excellent :), > Thank you, > I should be able to refactor our JR 14 access manager onto this quite > easily. > > One question, > I see its all or nothing, if the plugin is there isGranted doesnt look at > the default. > I was wondering if there was a way of checking the def

Re: Getting the sling home?

2009-04-24 Thread Aaron Zeckoski
String home = bundleContext.getProperty("sling.home"); Excellent! Thanks! :-) -AZ On Fri, Apr 24, 2009 at 10:48 AM, Bertrand Delacretaz wrote: > Hi Aaron, > > On Fri, Apr 24, 2009 at 11:37 AM, Aaron Zeckoski wrote: >> I have been searching through the code to try to find a way to get the >> sli

Re: Getting the sling home?

2009-04-24 Thread Bertrand Delacretaz
Hi Aaron, On Fri, Apr 24, 2009 at 11:37 AM, Aaron Zeckoski wrote: > I have been searching through the code to try to find a way to get the > sling home but not having much luck See this thread: http://markmail.org/thread/jmxqjwqq5od65qvr -Bertrand

Getting the sling home?

2009-04-24 Thread Aaron Zeckoski
I have been searching through the code to try to find a way to get the sling home but not having much luck. It seems to be stored in the config properties and loaded via methods like loadConfigProperties but I can't seem to locate a non-private method that loads these. I was hoping to find somethin

Re: AccessControlManager question.

2009-04-24 Thread Ian Boston
Excellent :), Thank you, I should be able to refactor our JR 14 access manager onto this quite easily. One question, I see its all or nothing, if the plugin is there isGranted doesnt look at the default. I was wondering if there was a way of checking the default, and then checkin the plugi

Re: AccessControlManager question.

2009-04-24 Thread Vidar Ramdal
>>> -- snip -- >>> Is there a better way of implementing Owner and a Dynamic membership >>> which wont generate huge load at session initiation ? >> [...] >> To be able to plugin an access manager, I had to make some minor >> changes in the Jackrabbit Server bundle. These changes are waiting in >>

Re: Unified system for tags

2009-04-24 Thread Vidar Ramdal
> On Thu, Apr 23, 2009 at 10:16 PM, Vidar Ramdal wrote: >>... In order to make Sling (even) more buzzword compliant, I have been >> thinking about a system for tags. [...] 2009/4/24 Bertrand Delacretaz : > Sounds good, and as Felix says I just wrote a blog entry about this > yesterday [2]. [...]

Re: AccessControlManager question.

2009-04-24 Thread Ian Boston
-- snip -- Is there a better way of implementing Owner and a Dynamic membership which wont generate huge load at session initiation ? I have been doing some stuff with dynamic policies myself, and ended up with writing a PluggableAccessManager. This way you can supply your access control logi

Re: ModifyAceServlet.

2009-04-24 Thread Ian Boston
Interesting, thank you, I will ask the same on jackrabbit users. Thanks. Ian On 23 Apr 2009, at 17:54, Eric Norman wrote: Yes, the jackrabbit implementation does not allow denying privileges on a group. The ModifyAcesServlet mirrors that behavior. I don't know the exact reasoning behind

Re: Unified system for tags

2009-04-24 Thread Bertrand Delacretaz
Hi Vidar, On Thu, Apr 23, 2009 at 10:16 PM, Vidar Ramdal wrote: > These are just some loose thoughts that have been brewing in my mind > lately, after reading Richardson/Ruby: RESTful Web Services [1]. Good choice ;-) >... In order to make Sling (even) more buzzword compliant, I have been > thi

Re: Unified system for tags

2009-04-24 Thread Bertrand Delacretaz
2009/4/24 Juan José Vázquez Delgado : > ...That is a nice feature but IMHO is more suitable for specific use > cases, such as CMS systems, than for Sling itself IMHO that shouldn't prevent implementing it under contrib - not all Sling users will need it, but using Sling for CMSish apps is cert