multiple cores w/same name in solr.xml ???

2010-03-16 Thread Chris Hostetter
I'm reviewing SOLR-1817 and noticing that when CoreContainer parses solr.xml, it asserts that at most one core has a "name" matching the "defaultCoreName" ... but there is currently no assertion that every core have a name, or that the names be unique before the SolrCore is constructed ... it

Re: multiple cores w/same name in solr.xml ???

2010-03-18 Thread Ryan McKinley
> > Is there any reason why CoreContainer shouldn't throw an exception if > solr.xml declares a core w/o a name, or two cores with the same name? This makes sense. I think WAY WAY back (in a patch), cores could be initialized by index, but that became moot with the CoreContainer stuff. ryan

Re: multiple cores w/same name in solr.xml ???

2010-03-18 Thread Yonik Seeley
On Thu, Mar 18, 2010 at 10:11 AM, Ryan McKinley wrote: >> >> Is there any reason why CoreContainer shouldn't throw an exception if >> solr.xml declares a core w/o a name, or two cores with the same name? > > This makes sense.  I think WAY WAY back (in a patch), cores could be > initialized by inde

Re: multiple cores w/same name in solr.xml ???

2010-03-18 Thread Chris Hostetter
: In the two cores with one name scenario, presumably you meant to name : one something different. You try to access the core under that : different name, get a core-not-found and go look at the solr.xml to : see why. Same scenario. : : So while I don't see extra code as necessary for that case