CVS commit: src/sys/dev/pci

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:24:46 UTC 2020 Modified Files: src/sys/dev/pci: if_alc.c if_alcreg.h Log Message: constify To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/dev/pci/if_alc.c cvs rdiff -u -r1.8 -r1.9

CVS commit: src/sys/dev/pci

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:20:41 UTC 2020 Modified Files: src/sys/dev/pci: if_jme.c Log Message: localify To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/dev/pci/if_jme.c Please note that diffs are not public domain;

CVS commit: src/sys/dev/pci

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:20:41 UTC 2020 Modified Files: src/sys/dev/pci: if_jme.c Log Message: localify To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/dev/pci/if_jme.c Please note that diffs are not public domain;

CVS commit: src/sys/dev/pci

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:19:09 UTC 2020 Modified Files: src/sys/dev/pci: if_aq.c Log Message: constify To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/pci/if_aq.c Please note that diffs are not public domain; they

CVS commit: src/sys/dev/pci

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:19:09 UTC 2020 Modified Files: src/sys/dev/pci: if_aq.c Log Message: constify To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/pci/if_aq.c Please note that diffs are not public domain; they

CVS commit: src

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:07:07 UTC 2020 Modified Files: src/share/man/man4: options.4 src/share/mk: bsd.sys.mk src/sys/arch/amd64/conf: ALL GENERIC src/sys/arch/amd64/include: param.h src/sys/conf: files ssp.mk

CVS commit: src

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:07:07 UTC 2020 Modified Files: src/share/man/man4: options.4 src/share/mk: bsd.sys.mk src/sys/arch/amd64/conf: ALL GENERIC src/sys/arch/amd64/include: param.h src/sys/conf: files ssp.mk

CVS commit: src/sys/arch/aarch64

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:23:58 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: trap.c src/sys/arch/aarch64/include: armreg.h pte.h Log Message: BTI definitions. To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25

CVS commit: src/sys/arch/aarch64

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:23:58 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: trap.c src/sys/arch/aarch64/include: armreg.h pte.h Log Message: BTI definitions. To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25

CVS commit: src/sys/arch/aarch64/aarch64

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:08:57 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: netbsd32_machdep.c Log Message: D means E here (aarch32), so don't check it. A-I-F are checked below already, so drop the whole line. To generate a diff

CVS commit: src/sys/arch/aarch64/aarch64

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:08:57 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: netbsd32_machdep.c Log Message: D means E here (aarch32), so don't check it. A-I-F are checked below already, so drop the whole line. To generate a diff

CVS commit: src/sys/compat

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:01:23 UTC 2020 Modified Files: src/sys/compat/common: vfs_syscalls_30.c src/sys/compat/netbsd32: netbsd32_compat_30.c netbsd32_fs.c Log Message: Fix copyout overflows in fhstat, found by the LGTM bot. Not a

CVS commit: src/sys/compat

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:01:23 UTC 2020 Modified Files: src/sys/compat/common: vfs_syscalls_30.c src/sys/compat/netbsd32: netbsd32_compat_30.c netbsd32_fs.c Log Message: Fix copyout overflows in fhstat, found by the LGTM bot. Not a

CVS commit: src/sys/arch/x86/x86

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:55:38 UTC 2020 Modified Files: src/sys/arch/x86/x86: dbregs.c fpu.c spectre.c svs.c Log Message: 'oldlwp' is never NULL now, so remove the NULL checks. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15

CVS commit: src/sys/arch/x86/x86

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:55:38 UTC 2020 Modified Files: src/sys/arch/x86/x86: dbregs.c fpu.c spectre.c svs.c Log Message: 'oldlwp' is never NULL now, so remove the NULL checks. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15

CVS commit: src/sys/kern

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:26:11 UTC 2020 Modified Files: src/sys/kern: subr_msan.c Log Message: Be more informative. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/kern/subr_msan.c Please note that diffs are not public

CVS commit: src/sys/kern

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:26:11 UTC 2020 Modified Files: src/sys/kern: subr_msan.c Log Message: Be more informative. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/kern/subr_msan.c Please note that diffs are not public

CVS commit: src/sys/arch

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:21:11 UTC 2020 Modified Files: src/sys/arch/amd64/amd64: machdep.c src/sys/arch/i386/i386: machdep.c mtrr_k6.c src/sys/arch/x86/include: mtrr.h src/sys/arch/x86/x86: mtrr_i686.c Log Message:

CVS commit: src/sys/arch

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:21:11 UTC 2020 Modified Files: src/sys/arch/amd64/amd64: machdep.c src/sys/arch/i386/i386: machdep.c mtrr_k6.c src/sys/arch/x86/include: mtrr.h src/sys/arch/x86/x86: mtrr_i686.c Log Message:

Re: CVS commit: src/sys/arch/aarch64

2020-01-30 Thread Maxime Villard
Le 28/01/2020 à 19:39, Nick Hudson a écrit : > On 28/01/2020 17:47, Maxime Villard wrote: >> @@ -460,8 +460,7 @@ cpu_setup_id(struct cpu_info *ci) >> >>   id->ac_aa64mmfr0 = reg_id_aa64mmfr0_el1_read(); >>   id->ac_aa64mmfr1 = reg_id_aa64mmfr1_el1_r

CVS commit: src/sys/arch/aarch64/include

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 18:02:30 UTC 2020 Modified Files: src/sys/arch/aarch64/include: armreg.h Log Message: More SCTLR. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/arch/aarch64/include/armreg.h Please note that

CVS commit: src/sys/arch/aarch64/include

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 18:02:30 UTC 2020 Modified Files: src/sys/arch/aarch64/include: armreg.h Log Message: More SCTLR. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/arch/aarch64/include/armreg.h Please note that

CVS commit: src/sys/arch/aarch64

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:47:51 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: cpu.c src/sys/arch/aarch64/include: armreg.h Log Message: Fetch ID_AA64MMFR2_EL1. Okayed by Nick the other day. To generate a diff of this commit:

CVS commit: src/sys/arch/aarch64

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:47:51 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: cpu.c src/sys/arch/aarch64/include: armreg.h Log Message: Fetch ID_AA64MMFR2_EL1. Okayed by Nick the other day. To generate a diff of this commit:

CVS commit: src/usr.sbin/cpuctl/arch

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:36:42 UTC 2020 Modified Files: src/usr.sbin/cpuctl/arch: aarch64.c Log Message: More identification. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/cpuctl/arch/aarch64.c Please note that

CVS commit: src/usr.sbin/cpuctl/arch

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:36:42 UTC 2020 Modified Files: src/usr.sbin/cpuctl/arch: aarch64.c Log Message: More identification. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/cpuctl/arch/aarch64.c Please note that

CVS commit: src/sys/arch/aarch64

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:33:07 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: genassym.cf locore.S src/sys/arch/aarch64/include: armreg.h Log Message: Jazelle and T32EE are not part of ARMv8, fix the bits to their real

CVS commit: src/sys/arch/aarch64

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:33:07 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: genassym.cf locore.S src/sys/arch/aarch64/include: armreg.h Log Message: Jazelle and T32EE are not part of ARMv8, fix the bits to their real

CVS commit: src/sys/arch/aarch64/include

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:23:30 UTC 2020 Modified Files: src/sys/arch/aarch64/include: armreg.h Log Message: More definitions. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/sys/arch/aarch64/include/armreg.h Please note

CVS commit: src/sys/arch/aarch64/include

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:23:30 UTC 2020 Modified Files: src/sys/arch/aarch64/include: armreg.h Log Message: More definitions. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/sys/arch/aarch64/include/armreg.h Please note

CVS commit: src/sys/dev/videomode

2020-01-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jan 25 15:59:11 UTC 2020 Modified Files: src/sys/dev/videomode: edid.c Log Message: Fix uninitialized variable. There may not be a TYPE_ASCII block. Found by kMSan with nouveau. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/videomode

2020-01-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jan 25 15:59:11 UTC 2020 Modified Files: src/sys/dev/videomode: edid.c Log Message: Fix uninitialized variable. There may not be a TYPE_ASCII block. Found by kMSan with nouveau. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/kern

2020-01-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jan 25 15:55:33 UTC 2020 Modified Files: src/sys/kern: subr_asan.c subr_msan.c Log Message: Actually, uio_vmspace is never NULL, the check should be against pmap_kernel. To generate a diff of this commit: cvs rdiff -u -r1.16

CVS commit: src/sys/kern

2020-01-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jan 25 15:55:33 UTC 2020 Modified Files: src/sys/kern: subr_asan.c subr_msan.c Log Message: Actually, uio_vmspace is never NULL, the check should be against pmap_kernel. To generate a diff of this commit: cvs rdiff -u -r1.16

Re: [x86 pmap changes] CVS commit: src/sys/arch

2020-01-09 Thread Maxime Villard
Le 08/01/2020 à 22:50, Andrew Doran a écrit : On Tue, Jan 07, 2020 at 09:39:22AM +0100, Maxime Villard wrote: Module Name:src Committed By: ad Date: Sat Jan 4 22:49:20 UTC 2020 Modified Files: src/sys/arch/x86/include: pmap.h pmap_pv.h src/sys/arch/x86/x86

CVS commit: src/sys/dev/nvmm/x86

2020-01-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 9 16:27:57 UTC 2020 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Registering the host's CR0 is done outside of the VCPU loop, so it must be cleared because it is also cleared inside the loop. Not

CVS commit: src/sys/dev/nvmm/x86

2020-01-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 9 16:27:57 UTC 2020 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Registering the host's CR0 is done outside of the VCPU loop, so it must be cleared because it is also cleared inside the loop. Not

CVS commit: src/sys/dev/nvmm/x86

2020-01-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 9 16:20:12 UTC 2020 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Mmh, as noted in PR/54847, this should be uint64_t, not uint16_t. Harmless because we use only the two lowest bits anyway. I believe

CVS commit: src/sys/dev/nvmm/x86

2020-01-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 9 16:20:12 UTC 2020 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Mmh, as noted in PR/54847, this should be uint64_t, not uint16_t. Harmless because we use only the two lowest bits anyway. I believe

Re: [x86 pmap changes] CVS commit: src/sys/arch

2020-01-07 Thread Maxime Villard
Le 07/01/2020 à 09:39, Maxime Villard a écrit : Module Name:    src Committed By:   ad Date:   Sat Jan  4 22:49:20 UTC 2020 Modified Files:     src/sys/arch/x86/include: pmap.h pmap_pv.h     src/sys/arch/x86/x86: pmap.c     src/sys/arch/xen/x86: xen_pmap.c Log Message: x86

[x86 pmap changes] CVS commit: src/sys/arch

2020-01-07 Thread Maxime Villard
Module Name:src Committed By: ad Date: Sat Jan 4 22:49:20 UTC 2020 Modified Files: src/sys/arch/x86/include: pmap.h pmap_pv.h src/sys/arch/x86/x86: pmap.c src/sys/arch/xen/x86: xen_pmap.c Log Message: x86 pmap improvements, reducing system time during a

CVS commit: src/sys/dev/usb

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:42:26 UTC 2020 Modified Files: src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cdce.c if_cue.c if_kue.c if_mos.c if_mue.c if_smsc.c if_udav.c if_upl.c if_ure.c if_url.c if_urndis.c u3g.c uark.c

CVS commit: src/sys/dev/usb

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:42:26 UTC 2020 Modified Files: src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cdce.c if_cue.c if_kue.c if_mos.c if_mue.c if_smsc.c if_udav.c if_upl.c if_ure.c if_url.c if_urndis.c u3g.c uark.c

CVS commit: src/sys/netsmb

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:14:43 UTC 2020 Modified Files: src/sys/netsmb: smb_smb.c Log Message: Set 'ntencpass' to NULL as part of 'again', to prevent use-after-free. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35

CVS commit: src/sys/netsmb

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:14:43 UTC 2020 Modified Files: src/sys/netsmb: smb_smb.c Log Message: Set 'ntencpass' to NULL as part of 'again', to prevent use-after-free. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35

CVS commit: src/sys/dev/ic

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:12:09 UTC 2020 Modified Files: src/sys/dev/ic: mfi.c Log Message: Set 'ld_sync' to NULL as part of 'again', to prevent use-after-free. To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63

CVS commit: src/sys/dev/ic

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:12:09 UTC 2020 Modified Files: src/sys/dev/ic: mfi.c Log Message: Set 'ld_sync' to NULL as part of 'again', to prevent use-after-free. To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63

CVS commit: src/sys/dev/raidframe

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:10:19 UTC 2020 Modified Files: src/sys/dev/raidframe: rf_compat32.c Log Message: Fix big bugs. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/raidframe/rf_compat32.c Please note that diffs

CVS commit: src/sys/dev/raidframe

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:10:19 UTC 2020 Modified Files: src/sys/dev/raidframe: rf_compat32.c Log Message: Fix big bugs. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/raidframe/rf_compat32.c Please note that diffs

Re: CVS commit: src/sys/arch/amd64

2020-01-05 Thread Maxime Villard
Le 05/01/2020 à 13:56, Maxime Villard a écrit : > Le 05/01/2020 à 02:03, Emmanuel Dreyfus a écrit : >> On Sat, Jan 04, 2020 at 08:43:16AM +0100, Maxime Villard wrote: >>> +.section multiboot,"",@note >>> Why @note? It will be in the .text anyway. Also why n

Re: CVS commit: src/sys/arch/amd64

2020-01-05 Thread Maxime Villard
Le 05/01/2020 à 02:03, Emmanuel Dreyfus a écrit : > On Sat, Jan 04, 2020 at 08:43:16AM +0100, Maxime Villard wrote: >> +.section multiboot,"",@note >> Why @note? It will be in the .text anyway. Also why no dot in the section >> name? That's supposed to be the

Re: CVS commit: src/sys/arch/amd64

2020-01-04 Thread Maxime Villard
Le 04/01/2020 à 03:33, Emmanuel Dreyfus a écrit : On Tue, Dec 31, 2019 at 09:32:05AM +0100, Maxime Villard wrote: I think max-page-size=0x1000 is the right thing to do, but someone needs to verify that the resulting binary is correct and that the resulting in-memory layout is correct too

CVS commit: src/sys/netinet6

2020-01-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 3 08:53:14 UTC 2020 Modified Files: src/sys/netinet6: ip6_mroute.c Log Message: Don't forget to initialize 'sin6_len'. With kASan, from time to time the value will be bigger than the size of the source, and we get a read

CVS commit: src/sys/netinet6

2020-01-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 3 08:53:14 UTC 2020 Modified Files: src/sys/netinet6: ip6_mroute.c Log Message: Don't forget to initialize 'sin6_len'. With kASan, from time to time the value will be bigger than the size of the source, and we get a read

CVS commit: src/sys/dev/usb

2020-01-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 2 08:08:30 UTC 2020 Modified Files: src/sys/dev/usb: umidi.c Log Message: Remove the call to KERNEL_UNLOCK_ONE(), it was forgotten when the biglock was dropped in rev1.63. Found via vHCI. To generate a diff of this

CVS commit: src/sys/dev/usb

2020-01-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 2 08:08:30 UTC 2020 Modified Files: src/sys/dev/usb: umidi.c Log Message: Remove the call to KERNEL_UNLOCK_ONE(), it was forgotten when the biglock was dropped in rev1.63. Found via vHCI. To generate a diff of this

CVS commit: src/sys/compat

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 14:52:38 UTC 2020 Modified Files: src/sys/compat/common: kern_sig_43.c src/sys/compat/netbsd32: netbsd32_compat_20.c netbsd32_compat_50.c Log Message: Fix three stack info leaks, found by kMSan when just invoking

CVS commit: src/sys/compat

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 14:52:38 UTC 2020 Modified Files: src/sys/compat/common: kern_sig_43.c src/sys/compat/netbsd32: netbsd32_compat_20.c netbsd32_compat_50.c Log Message: Fix three stack info leaks, found by kMSan when just invoking

CVS commit: src/sys/dev/hid

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:40:17 UTC 2020 Modified Files: src/sys/dev/hid: hid.c Log Message: Fix small read overflows when parsing HID tables. Noticed by kASan the other day while I was playing with vHCI. To generate a diff of this commit:

CVS commit: src/sys/dev/hid

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:40:17 UTC 2020 Modified Files: src/sys/dev/hid: hid.c Log Message: Fix small read overflows when parsing HID tables. Noticed by kASan the other day while I was playing with vHCI. To generate a diff of this commit:

CVS commit: src/sys/compat/netbsd32

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:17:45 UTC 2020 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_43.c Log Message: Fix sizeof mismatch in copyin. This leads to a user-triggerable stack overflow. On my test build at least, by luck, the

CVS commit: src/sys/compat/netbsd32

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:17:45 UTC 2020 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_43.c Log Message: Fix sizeof mismatch in copyin. This leads to a user-triggerable stack overflow. On my test build at least, by luck, the

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:08:28 UTC 2020 Modified Files: src/sys/dev/usb: ucycom.c Log Message: Fix buffer overflows: validate the lengths at attach time, given that they are apparently not supposed to be variable. Drop sc_ilen since it is

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:08:28 UTC 2020 Modified Files: src/sys/dev/usb: ucycom.c Log Message: Fix buffer overflows: validate the lengths at attach time, given that they are apparently not supposed to be variable. Drop sc_ilen since it is

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:05:03 UTC 2020 Modified Files: src/sys/dev/usb: uhid.c Log Message: Fix buffer overflows. Also add missing mutex_exit. To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111 src/sys/dev/usb/uhid.c Please

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:05:03 UTC 2020 Modified Files: src/sys/dev/usb: uhid.c Log Message: Fix buffer overflows. Also add missing mutex_exit. To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111 src/sys/dev/usb/uhid.c Please

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:03:00 UTC 2020 Modified Files: src/sys/dev/usb: uthum.c Log Message: Fix buffer overflows. sc_{o,f}len are controlled by the USB device. By crafting the former the device can leak stack data. By crafting the latter

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:03:00 UTC 2020 Modified Files: src/sys/dev/usb: uthum.c Log Message: Fix buffer overflows. sc_{o,f}len are controlled by the USB device. By crafting the former the device can leak stack data. By crafting the latter

Re: CVS commit: src/sys/arch/amd64

2019-12-31 Thread Maxime Villard
Le 30/12/2019 à 16:15, Emmanuel Dreyfus a écrit : > On Sat, Dec 28, 2019 at 02:22:21AM +, Emmanuel Dreyfus wrote: >>> Regardless of whether it is needed in this specific case, cutting the 2MBs >>> of zero in the binary is wanted. Unfortunately last I looked at this (two >>> years ago) there

Re: CVS commit: src/sys/arch/amd64

2019-12-27 Thread Maxime Villard
Le 27/12/2019 à 17:45, Emmanuel Dreyfus a écrit : > On Fri, Dec 27, 2019 at 09:02:17AM +0100, Maxime Villard wrote: >> Please stop with the nonsense... In this patch you are making the multiboot >> header executable, and putting it in a section shared with userland under >>

CVS commit: src/sys/kern

2019-12-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 27 15:49:20 UTC 2019 Modified Files: src/sys/kern: subr_pool.c Log Message: Switch to panic, and make the message more useful. To generate a diff of this commit: cvs rdiff -u -r1.263 -r1.264 src/sys/kern/subr_pool.c

CVS commit: src/sys/kern

2019-12-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 27 15:49:20 UTC 2019 Modified Files: src/sys/kern: subr_pool.c Log Message: Switch to panic, and make the message more useful. To generate a diff of this commit: cvs rdiff -u -r1.263 -r1.264 src/sys/kern/subr_pool.c

Re: CVS commit: src/sys/arch/amd64

2019-12-27 Thread Maxime Villard
Le 26/12/2019 à 17:55, Emmanuel Dreyfus a écrit : > On Wed, Dec 25, 2019 at 05:05:11PM +0900, Masanobu SAITOH wrote: After this change, amd64 kernel does not boot on my HP Spectre x360 13-inch ae019TU laptop with pure UEFI boot mode. >> I have a UEFI boot machine and it also doesn't

Re: CVS commit: src

2019-12-23 Thread Maxime Villard
Le 23/12/2019 à 04:18, Taylor R Campbell a écrit : Date: Sun, 22 Dec 2019 10:24:01 +0100 From: Maxime Villard You, Martin Christos and Taylor, are trying to change subject, find excuses, and are sending me irrelevant responses vaguely insinuating that I should revert my change only without

CVS commit: src

2019-12-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Dec 23 06:45:38 UTC 2019 Modified Files: src/distrib/sets/lists/base: mi src/distrib/sets/lists/comp: mi src/distrib/sets/lists/man: mi src/etc: MAKEDEV.tmpl src/etc/mtree: NetBSD.dist.base

CVS commit: src

2019-12-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Dec 23 06:45:38 UTC 2019 Modified Files: src/distrib/sets/lists/base: mi src/distrib/sets/lists/comp: mi src/distrib/sets/lists/man: mi src/etc: MAKEDEV.tmpl src/etc/mtree: NetBSD.dist.base

Re: CVS commit: src

2019-12-22 Thread Maxime Villard
Le 21/12/2019 à 23:48, Christos Zoulas a écrit : In article <15520611-7273-9567-33a4-ff2490b2e...@m00nbsd.net>, Maxime Villard wrote: Le 21/12/2019 à 00:05, Taylor R Campbell a écrit : Security-team is not perfect. We're happy to discuss a better way to disable filemon provisi

Re: CVS commit: src

2019-12-21 Thread Maxime Villard
Le 21/12/2019 à 00:05, Taylor R Campbell a écrit : Security-team is not perfect. We're happy to discuss a better way to disable filemon provisionally, and/or how to better address the existing users if we are to delete it -- after you do as core asked you to do to resolve the interim dispute by

Re: CVS commit: src

2019-12-21 Thread Maxime Villard
End of excerpt from Maxime Villard The first proposed change was to create a .plist file. I liked it because it didn't require running postinstall to get the fix. It provoked a bit of disgruntled voices, a continuation tech-kern bikeshed about the correct way to disable module auto-loading in a per-mod

Re: CVS commit: src

2019-12-20 Thread Maxime Villard
Le 20/12/2019 à 20:52, Martin Husemann a écrit : On Fri, Dec 20, 2019 at 07:54:36PM +0100, Maxime Villard wrote: Alright, fair enough. I will revert my removal over the week-end, because it hasn't received sufficient public discussion. Thank you! As well, I will revert secteam's killing

Re: CVS commit: src

2019-12-20 Thread Maxime Villard
Le 19/12/2019 à 17:57, Taylor R Campbell a écrit : Date: Thu, 19 Dec 2019 08:19:07 +0100 From: Maxime Villard I think you meant to say "REMOVING things you don't like". Correct, I made an editing error. Sorry for the confusion. In the meantime, I have absolutely no intent to

Re: CVS commit: src

2019-12-18 Thread Maxime Villard
Answering quickly: Le 18/12/2019 à 21:24, Taylor R Campbell a écrit : Module Name:src Committed By: maxv Date: Wed Dec 18 07:37:19 UTC 2019 Log Message: Retire filemon, discussed on tech-kern@. Please refrain from taking unilateral actions such as things you don't like

CVS commit: src/usr.bin/make

2019-12-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Dec 19 07:14:07 UTC 2019 Modified Files: src/usr.bin/make: Makefile compat.c make.1 meta.c Log Message: Revert the filemon removal in bmake, as pointed out by maya we do care about not introducing divergence with FreeBSD, and

CVS commit: src/usr.bin/make

2019-12-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Dec 19 07:14:07 UTC 2019 Modified Files: src/usr.bin/make: Makefile compat.c make.1 meta.c Log Message: Revert the filemon removal in bmake, as pointed out by maya we do care about not introducing divergence with FreeBSD, and

CVS commit: src

2019-12-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Dec 18 07:37:19 UTC 2019 Modified Files: src/distrib/sets/lists/base: mi src/distrib/sets/lists/comp: mi src/distrib/sets/lists/man: mi src/etc: MAKEDEV.tmpl src/etc/mtree: NetBSD.dist.base

CVS commit: src

2019-12-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Dec 18 07:37:19 UTC 2019 Modified Files: src/distrib/sets/lists/base: mi src/distrib/sets/lists/comp: mi src/distrib/sets/lists/man: mi src/etc: MAKEDEV.tmpl src/etc/mtree: NetBSD.dist.base

Re: CVS commit: src/sys/arch

2019-12-13 Thread Maxime Villard
Le 12/12/2019 à 10:20, Maxime Villard a écrit : Le 10/12/2019 à 03:06, Emmanuel Dreyfus a écrit : Module Name:    src Committed By:    manu Date:    Tue Dec 10 02:06:07 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: locore.S machdep.c src/sys/arch/amd64/conf: GENERIC

CVS commit: src/sys/arch/amd64/conf

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Dec 14 07:45:20 UTC 2019 Modified Files: src/sys/arch/amd64/conf: GENERIC Log Message: Disable multiboot for now, too much breakage. To generate a diff of this commit: cvs rdiff -u -r1.550 -r1.551

CVS commit: src/sys/arch/amd64/conf

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Dec 14 07:45:20 UTC 2019 Modified Files: src/sys/arch/amd64/conf: GENERIC Log Message: Disable multiboot for now, too much breakage. To generate a diff of this commit: cvs rdiff -u -r1.550 -r1.551

CVS commit: src/sys/net

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 13 14:13:55 UTC 2019 Modified Files: src/sys/net: if_tun.c Log Message: Read the len before pushing the packet, otherwise possible use-after-free. Found by a custom query on LGTM. To generate a diff of this commit: cvs

CVS commit: src/sys/net

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 13 14:13:55 UTC 2019 Modified Files: src/sys/net: if_tun.c Log Message: Read the len before pushing the packet, otherwise possible use-after-free. Found by a custom query on LGTM. To generate a diff of this commit: cvs

CVS commit: src/sys/dev/usb

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 13 14:10:32 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Fix gross use-after-free. Found by a custom query on LGTM. To generate a diff of this commit: cvs rdiff -u -r1.77 -r1.78

CVS commit: src/sys/dev/usb

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 13 14:10:32 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Fix gross use-after-free. Found by a custom query on LGTM. To generate a diff of this commit: cvs rdiff -u -r1.77 -r1.78

CVS commit: src/sys/arch/x86/x86

2019-12-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Dec 12 16:49:20 UTC 2019 Modified Files: src/sys/arch/x86/x86: spectre.c Log Message: Check CPUID.IBRS in addition to ARCH_CAP.IBRS_ALL. For clarity, and also because VirtualBox clears the former but forgets to clear the latter

CVS commit: src/sys/arch/x86/x86

2019-12-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Dec 12 16:49:20 UTC 2019 Modified Files: src/sys/arch/x86/x86: spectre.c Log Message: Check CPUID.IBRS in addition to ARCH_CAP.IBRS_ALL. For clarity, and also because VirtualBox clears the former but forgets to clear the latter

Re: CVS commit: src/sys/arch

2019-12-12 Thread Maxime Villard
Le 10/12/2019 à 03:06, Emmanuel Dreyfus a écrit : Module Name:src Committed By: manu Date: Tue Dec 10 02:06:07 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: locore.S machdep.c src/sys/arch/amd64/conf: GENERIC files.amd64 kern.ldscript

Re: CVS commit: src/sys/kern

2019-12-12 Thread Maxime Villard
Le 08/12/2019 à 14:22, Martin Husemann a écrit : On Sun, Dec 08, 2019 at 12:58:20PM +0100, Maxime Villard wrote: kMSan has special constraints which, in this specific case, come down to: each function called from a KCOV instrumentation callback must be a static inline tagged with __nomsan

Re: CVS commit: src/sys/kern

2019-12-08 Thread Maxime Villard
Le 08/12/2019 à 00:51, Kamil Rytarowski a écrit : On 08.12.2019 00:35, matthew green wrote: Module Name:src Committed By: kamil Date: Sat Dec 7 19:50:34 UTC 2019 Modified Files: src/sys/kern: subr_kcov.c Log Message: Revert the in_interrupt() change to use again the

CVS commit: src/sys

2019-12-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 8 11:53:54 UTC 2019 Modified Files: src/sys/arch/amd64/include: cpu.h src/sys/kern: subr_msan.c Log Message: Use the inlines; it is actually fine, since the compiler drops the inlines if the caller is

CVS commit: src/sys

2019-12-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 8 11:53:54 UTC 2019 Modified Files: src/sys/arch/amd64/include: cpu.h src/sys/kern: subr_msan.c Log Message: Use the inlines; it is actually fine, since the compiler drops the inlines if the caller is

<    1   2   3   4   5   6   7   8   9   10   >