CVS: cvs.openbsd.org: src

2018-08-08 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/08 13:35:47 Modified files: usr.bin/mixerctl: mixerctl.c Log message: add unveil(2) to mixerctl(1) after we know what is the mixer device to be used, either through MIXERDEVICE env var, the

Re: CVS: cvs.openbsd.org: src

2018-08-07 Thread Ricardo Mestre
On 00:27 Mon 06 Aug , Ricardo Mestre wrote: > CVSROOT: /cvs > Module name: src > Changes by: mes...@cvs.openbsd.org 2018/08/06 00:27:32 > > Modified files: > games/worms: worms.c > > Log message: > Drop "rpath" from pledge(2) after n

CVS: cvs.openbsd.org: src

2018-08-06 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/06 11:26:31 Modified files: etc/examples : ldpd.conf Log message: Correct example file since reserved words cannot be used as macros. Not only that, the macro used was password and if we changed

CVS: cvs.openbsd.org: src

2018-08-06 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/06 11:25:11 Modified files: usr.sbin/ldpd : ldpd.conf.5 Log message: Change manpage example for reserved words since the macro used is to replace a password and that way it would log it when the

CVS: cvs.openbsd.org: src

2018-08-06 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/06 00:30:06 Modified files: sbin/iked : control.c iked.h proc.c Log message: Remove cpath pledge(2) promise. We decided that not deleting the unix control sockets cause no harm and this way we

CVS: cvs.openbsd.org: src

2018-08-06 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/06 00:27:32 Modified files: games/worms: worms.c Log message: Drop "rpath" from pledge(2) after ncurses initialization. Discussed with and OK tb@ OK cheloha@ on previous version

CVS: cvs.openbsd.org: src

2018-08-05 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/05 03:37:52 Modified files: sbin/slaacd: slaacd.c Log message: Since -s argument is no longer checked, during reexec, the argv size then must be shortened by 1. OK florian@

CVS: cvs.openbsd.org: src

2018-08-05 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/05 03:37:05 Modified files: usr.sbin/rad : rad.c Log message: Since -s argument is no longer checked, during reexec, the argv size then must be shortened by 1. OK florian@

CVS: cvs.openbsd.org: src

2018-08-05 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/05 03:33:13 Modified files: usr.sbin/snmpd : control.c proc.c snmpd.c snmpd.h Log message: Remove cpath pledge(2) promise. We decided that not deleting the unix control sockets cause no harm and

CVS: cvs.openbsd.org: src

2018-08-05 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/05 02:41:28 Modified files: usr.sbin/eigrpd: eigrpd.c Log message: Remove now unused header which I forgot to commit on previous.

CVS: cvs.openbsd.org: src

2018-08-05 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/05 02:20:54 Modified files: usr.sbin/vmd : control.c proc.c proc.h Log message: Remove cpath pledge(2) promise. We decided that not deleting the unix control sockets cause no harm and this way we

CVS: cvs.openbsd.org: src

2018-08-05 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/05 02:16:25 Modified files: usr.sbin/switchd: control.c proc.c proc.h Log message: Remove cpath pledge(2) promise. We decided that not deleting the unix control sockets cause no harm and this way we

CVS: cvs.openbsd.org: src

2018-08-05 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/05 02:10:35 Modified files: usr.sbin/eigrpd: control.c control.h eigrpd.c eigrpd.h eigrpe.c Log message: Revert back previous and remove cpath pledge(2) promise entirely. We decided that not

CVS: cvs.openbsd.org: src

2018-08-04 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/04 05:07:14 Modified files: usr.sbin/ntpd : control.c ntpd.c ntpd.h Log message: Revert back previous commit, we have decided that socket files don't cause any harm if not deleted after the daemon

CVS: cvs.openbsd.org: src

2018-08-02 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/02 07:05:34 Modified files: usr.sbin/ntpd : ntpd.c Log message: ntpd(8) has logic in place to delete its control socket on shutdown, but it currently doesn't call the function control_cleanup to do

CVS: cvs.openbsd.org: src

2018-08-02 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/02 00:43:31 Modified files: usr.sbin/eigrpd: eigrpd.c Log message: Actually order the promises in their canonical form, missed that in my previous commit. heads up and OK tb@

CVS: cvs.openbsd.org: src

2018-08-02 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/02 00:28:35 Modified files: usr.sbin/eigrpd: eigrpd.c eigrpe.c Log message: Currently when eigrpd(8) shuts down then its unix control socket is being unlink(2)ed from eigrpe engine process, the

CVS: cvs.openbsd.org: src

2018-08-01 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/08/01 11:17:42 Modified files: usr.sbin/radiusd: radiusd.c Log message: Fix segmentation fault on radiusd(8) when exiting. If one of the configured modules doesn't have a secret setup then

CVS: cvs.openbsd.org: src

2018-07-26 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/07/26 13:33:20 Modified files: usr.sbin/spamdb: spamdb.c Log message: zap whitespaces

CVS: cvs.openbsd.org: src

2018-07-26 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/07/26 13:32:52 Modified files: usr.sbin/spamdb: spamdb.c Log message: reduce pledge(2) to the bare minimum: after dbopen(3) occurs then all operations are on fds which don't need rpath/wpath and

CVS: cvs.openbsd.org: src

2018-07-26 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/07/26 07:37:40 Modified files: usr.sbin/quot : quot.c Log message: add pledge(2) to quot(8): - rpath to traverse the filesystem(s) - getpw to figure out who owns what OK tb@ deraadt@

CVS: cvs.openbsd.org: src

2018-07-20 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/07/20 15:47:07 Modified files: usr.bin/midiplay: midiplay.c Log message: add pledge(2), it only needs rpath if reading from a file hint from tb@ and OK ratchov@

CVS: cvs.openbsd.org: src

2018-07-20 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/07/20 15:44:41 Modified files: usr.bin/midiplay: midiplay.c Log message: zap whitespaces

Re: CVS: cvs.openbsd.org: src

2018-07-13 Thread Ricardo Mestre
also OK tb@ in his own peculiar way! :D On 11:18 Fri 13 Jul , Ricardo Mestre wrote: > CVSROOT: /cvs > Module name: src > Changes by: mes...@cvs.openbsd.org 2018/07/13 11:18:34 > > Modified files: > lib/libc/sys : unveil.2 > > Log message: > Corr

CVS: cvs.openbsd.org: src

2018-07-13 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2018/07/13 11:18:34 Modified files: lib/libc/sys : unveil.2 Log message: Correct some typos and also ran it through mandoc -Tlint OK millert@ deraadt@ and jmc@ who also gave me a cluebat stick

CVS: cvs.openbsd.org: src

2017-11-26 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/11/26 02:59:41 Modified files: usr.bin/vi/common: delete.c Log message: Fix segfault which could be triggered by deleting a backwards sentence if cursor's current line was blank: echo "\nfoo" > a &&

CVS: cvs.openbsd.org: src

2017-11-01 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/11/01 18:31:49 Modified files: usr.bin/openssl: s_time.c Log message: openssl s_time -connect host:port needs dns promise for pledge(2) otherwise it will SIGABRT Bug found by Scott Cheloha OK

CVS: cvs.openbsd.org: src

2017-08-31 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/08/31 00:50:56 Modified files: sbin/nfsd : nfsd.c Log message: Unbreak DEBUG on nfsd(8) by changing the syslog macro. With this change a few of the syslog calls also needed to change since

CVS: cvs.openbsd.org: src

2017-08-22 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/08/22 10:32:37 Modified files: usr.bin/cu : cu.c Log message: Call isatty(3) prior to ioctl(TIOCEXCL) to check if cu(1) was invoked on a non-TTY and if that's the case then close the application.

CVS: cvs.openbsd.org: src

2017-08-22 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/08/22 04:41:59 Modified files: sys/dev/ic : ac97.c Log message: Fix negative array index read. Coverity CID 1453243 and 1453334. Check if cp->dev value is invalid prior to using it as an array

CVS: cvs.openbsd.org: src

2017-08-22 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/08/22 02:49:23 Modified files: sys/dev/ic : ar5xxx.c Log message: Fix off by one overwrite. Covery CID 1452938. ee->ee_ctls evaluates to either 16 or 32 depending on the card's EEPROM version and

CVS: cvs.openbsd.org: src

2017-08-11 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/08/11 14:56:15 Modified files: sys/net: pipex.c Log message: During MPPE key reduction on the 40 bits case the first 3 octets need to be changed with known constants (RFC3079). Current code

CVS: cvs.openbsd.org: src

2017-08-11 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/08/11 14:44:25 Modified files: sys/dev/ic : ar5xxx.c Log message: Fix copy pasto (Coverity CID 1452996), with this it matches the code in FreeBSD OK phessler@ and stsp@

CVS: cvs.openbsd.org: src

2017-08-11 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/08/11 08:59:43 Modified files: sys/dev/atapiscsi: atapiscsi.c Log message: Missing break/return statement on switch case Coverity CID 1453394 OK deraadt@

CVS: cvs.openbsd.org: src

2017-08-10 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/08/10 08:36:34 Modified files: sys/miscfs/fuse: fuse_device.c Log message: Avoid possible NULL pointer dereference on fuseioctl() Found by Coverity Scan (CID 1453387) OK mpi@

CVS: cvs.openbsd.org: src

2017-07-04 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/07/04 17:13:09 Modified files: sbin/pflogd: privsep.c Log message: Revert back previous, pledge cannot be enabled on the privsep'd proc yet, at least not as is Reported by tim@, OK deraadt@ to

Re: CVS: cvs.openbsd.org: src

2017-07-04 Thread Ricardo Mestre
Molen wrote: > Ricardo Mestre (2017-07-04 18:22 +0200): > > What about applying the pledge early on only if snaplen is not being > > defined, > > but if it is then call pledge as well but only after the filter is applied > > (this is where the offending ioctl is called)?

Re: CVS: cvs.openbsd.org: src

2017-07-04 Thread Ricardo Mestre
What about applying the pledge early on only if snaplen is not being defined, but if it is then call pledge as well but only after the filter is applied (this is where the offending ioctl is called)? A better strategy probably would involve something similar to tcpdump to check if PRIV_INIT_DONE

Re: CVS: cvs.openbsd.org: src

2017-07-04 Thread Ricardo Mestre
ead(socks[0], , sizeof(int))) On 15:49 Tue 04 Jul , Tim van der Molen wrote: > Ricardo Mestre (2017-06-13 01:37 +0200): > > CVSROOT:/cvs > > Module name:src > > Changes by: mes...@cvs.openbsd.org 2017/06/12 17:37:44 > > > > Modified files: > >

CVS: cvs.openbsd.org: src

2017-06-30 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/06/30 02:39:16 Modified files: games/fortune/fortune: fortune.c Log message: Add missing rot13 function prototype

CVS: cvs.openbsd.org: src

2017-06-23 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/06/23 01:24:48 Modified files: usr.bin/ssh: clientloop.c Log message: When using the escape sequence &~ the code path is client_loop() -> client_simple_escape_filter() -> process_escapes() ->

CVS: cvs.openbsd.org: src

2017-06-12 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/06/12 17:37:44 Modified files: sbin/pflogd: privsep.c Log message: pledge(2) bpf has been in use for some time now on tcpdump(8), this will enable it also for pflogd(8)'s priv proc. OK deraadt@

Re: CVS: cvs.openbsd.org: src

2017-05-24 Thread Ricardo Mestre
and OK deraadt@ On 03:19 Wed 24 May , Ricardo Mestre wrote: > CVSROOT: /cvs > Module name: src > Changes by: mes...@cvs.openbsd.org 2017/05/24 03:19:55 > > Modified files: > usr.bin/encrypt: encrypt.c > > Log message: > Use freezero instead of explicit_bzero+free > > OK tb@ >

CVS: cvs.openbsd.org: src

2017-05-24 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/05/24 03:19:55 Modified files: usr.bin/encrypt: encrypt.c Log message: Use freezero instead of explicit_bzero+free OK tb@

CVS: cvs.openbsd.org: src

2017-05-24 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/05/24 03:18:15 Modified files: usr.sbin/user : user.c Log message: Remove 2 unused parameters from copydotfiles function While here sort headers and add missing prototypes OK tb@

CVS: cvs.openbsd.org: src

2017-05-12 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/05/12 12:03:00 Modified files: usr.sbin/user : user.c Log message: Replace memset(3) with explicit_bzero(3) on user(8) on sensitive data (passwords) as soon as they are not needed on memory anymore.

CVS: cvs.openbsd.org: src

2017-05-09 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/05/09 07:52:45 Modified files: lib/libkeynote : signature.c Log message: Prevent memory leak on sbuf by freeing it unconditionally and ensure finalbuf is also free'd if kn_encode_base64 somehow fails

CVS: cvs.openbsd.org: src

2017-05-08 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/05/08 12:19:02 Modified files: sys/dev/ic : rtwn.c Log message: 8192C is the only MIMO chip supported by this driver, all others are 1T1R. This diff corrects dmesg to properly show that all others

CVS: cvs.openbsd.org: src

2017-05-03 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/05/03 03:51:39 Modified files: sbin/init : init.c usr.bin/encrypt: encrypt.c usr.bin/lock : lock.c usr.bin/skey : skey.c usr.bin/x99token: x99token.c

CVS: cvs.openbsd.org: src

2017-01-17 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2017/01/17 16:28:04 Modified files: libexec/spamd : spamd.c Log message: - spamd(8)'s -l accepts an IP address as argument to bind(2) and it calls inet_pton(3) to check if it's valid and since that

CVS: cvs.openbsd.org: src

2016-12-14 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/12/14 01:22:39 Modified files: usr.sbin/unbound/services: listen_dnsport.c Log message: Remove a resource leak by closing the socket in all error cases. The patch was already committed upstream. OK

CVS: cvs.openbsd.org: src

2016-12-01 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/12/01 09:24:48 Modified files: usr.sbin/ntpd : ntpd.c Log message: Remove unused variable which was leaking memory, and while here remove 2 other variables that were also never used OK otto@

CVS: cvs.openbsd.org: src

2016-11-30 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/30 16:58:07 Modified files: usr.sbin/user : user.c Log message: Since pwp->pw_gid is equal to pwp->pw_uid then use the former instead in creategid() function and in the failure message since it

CVS: cvs.openbsd.org: src

2016-11-30 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/30 15:44:19 Modified files: usr.sbin/user : user.c Log message: Mitigate some fd leaks on user(8) OK millert@

CVS: cvs.openbsd.org: src

2016-11-30 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/30 03:42:38 Modified files: usr.sbin/user : user.c Log message: According to usermod(8) manpage if -g =uid is used it should create a new group with an unique UID, if it's not already created (not

CVS: cvs.openbsd.org: src

2016-11-30 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/30 00:59:04 Modified files: usr.sbin/syslogd: syslogd.c Log message: Wrap lines earlier on tls_config_set_protocols(3) Feedback and OK jsing@

CVS: cvs.openbsd.org: src

2016-11-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/30 00:57:21 Modified files: usr.sbin/ldapd : parse.y Log message: Check return value of tls_config_set_protocols(3) and bail out in case of failure Feedback and OK jsing@

CVS: cvs.openbsd.org: src

2016-11-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/30 00:56:23 Modified files: usr.bin/nc : netcat.c Log message: Check return value of tls_config_set_protocols(3) and tls_config_set_ciphers(3) and bail out in case of failure Feedback and OK

CVS: cvs.openbsd.org: src

2016-11-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/30 00:55:24 Modified files: usr.bin/ftp: main.c Log message: Check return value of tls_config_set_protocols(3) and bail out in case of failure Feedback and OK jsing@

CVS: cvs.openbsd.org: src

2016-11-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/30 00:54:36 Modified files: libexec/spamd : spamd.c Log message: Check return value of tls_config_set_protocols(3) and bail out in case of failure Feedback and OK jsing@

CVS: cvs.openbsd.org: src

2016-11-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/29 10:21:52 Modified files: usr.sbin/spamdb: spamdb.c Log message: When action == 0 (spamdb(8) without arguments) it only reads the DB so it only needs to pledge for "rpath" and for all other cases

CVS: cvs.openbsd.org: src

2016-11-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/29 10:15:27 Modified files: usr.sbin/ypldap: ldapclient.c yp.c ypldap.c ypldap_dns.c Log message: Use memset(3) instead of bzero(3) OK deraadt@

CVS: cvs.openbsd.org: src

2016-11-21 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/21 09:36:10 Modified files: usr.sbin/syslogd: syslogd.c Log message: Check return value of tls_config_set_protocols(3) and log if it fails OK bluhm@

CVS: cvs.openbsd.org: src

2016-11-15 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/15 03:49:37 Modified files: usr.sbin/dhcpd : dispatch.c icmp.c options.c pfutils.c Log message: Replace bzero(3) with memset(3) "Looks good" to deraadt@

CVS: cvs.openbsd.org: src

2016-11-08 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/08 07:37:20 Modified files: sbin/ifconfig : ifconfig.c Log message: - Declare usage() as __dead void (remaining prototypes are not declared as static, so keep it that way for consistency) -

CVS: cvs.openbsd.org: src

2016-11-08 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/08 02:43:59 Modified files: usr.sbin/makefs: makefs.c Log message: pledge for "stdio rpath wpath cpath" promises since it only needs to read/write/create files OK natano@ and tb@, thank you both

CVS: cvs.openbsd.org: src

2016-11-08 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/08 02:31:55 Modified files: libexec/spamd : spamd.c Log message: Remove redundant & when clearing hostname variable, as per otto@'s request

CVS: cvs.openbsd.org: src

2016-11-07 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/07 16:04:55 Modified files: usr.sbin/vipw : vipw.c Log message: - Remove -? since parameters don't make sense for this command (but still keep default case to have usage() explaining that) -

CVS: cvs.openbsd.org: src

2016-11-07 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/11/07 15:18:22 Modified files: libexec/spamd : spamd.c Log message: Replace bzero(3) with memset(3) OK deraadt@

CVS: cvs.openbsd.org: src

2016-10-21 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/10/21 05:34:48 Modified files: usr.sbin/dhcpd : sync.c Log message: - Use memset(*b, 0, len) instead of bzero(*b, len) - Use explicit_bzero(3) instead of bzero(3) to clean temporary HMAC OK krw@

CVS: cvs.openbsd.org: src

2016-10-20 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/10/20 15:09:46 Modified files: libexec/spamd : grey.c sync.c Log message: - Remove useless var assignment - Use memset(*b, 0, len) instead of bzero(*b, len) - Use memcpy(*dst, *src, len) instead of

CVS: cvs.openbsd.org: src

2016-05-16 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/05/16 09:51:56 src/lib/libforbid Update of /cvs/src/lib/libforbid In directory cvs.openbsd.org:/tmp/cvs-serv23071/libforbid Log Message: Directory /cvs/src/lib/libforbid added to the repository

CVS: cvs.openbsd.org: src

2016-05-03 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/05/03 15:05:14 Modified files: usr.sbin/user : user.c Log message: Fix regression on usermod/userdel by calling getpwnam_shadow(3) and saving passwd hash early, instead of getpwnam(3), then close fds

CVS: cvs.openbsd.org: src

2016-04-27 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/04/27 04:24:50 Modified files: libexec/spamd : spamd.c Log message: Remove pledge(2)'s that are called before chroot(2) since in the near future this will be forbidden. The remaining pledge(2) calls

CVS: cvs.openbsd.org: src

2016-04-27 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/04/27 04:16:11 Modified files: usr.sbin/dhcpd : dhcpd.c udpsock.c Log message: Remove pledge(2)'s that are called before chroot(2) since in the near future this will be forbidden. The remaining

CVS: cvs.openbsd.org: src

2016-04-26 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/04/26 14:30:00 Modified files: libexec/login_reject: login_reject.c Log message: Add missing "tty" promise to the pledge(2) call This is needed since getpass(3) calls readpassphrase(3) which in turn

CVS: cvs.openbsd.org: src

2016-04-26 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/04/26 07:30:12 Modified files: usr.sbin/user : user.c Log message: Add pledge(2) promises independently on each user(8)'s functions as follows: useradd:stdio rpath wpath cpath fattr flock

CVS: cvs.openbsd.org: src

2016-04-05 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/04/05 09:12:11 Modified files: share/man/man4 : ath.4 Log message: Remove mention of Turbo Mode from ath(4) since the driver doesn't support it Discussed with and OK from sthen@ stsp@ kettenis@ jsg@

CVS: cvs.openbsd.org: src

2016-04-04 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/04/04 08:00:42 Modified files: usr.sbin/dhcpd : udpsock.c Log message: In udpsockmode codepath dhcpd.c had the promise route for pledge(2) but it was missing from udpsock_startup() (udpsock.c) which

CVS: cvs.openbsd.org: src

2016-03-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/29 11:21:50 Modified files: usr.sbin/user : user.c Log message: If program cannot reserve memory then the user doesn't need to know exactly how many bytes it couldn't allocate Suggested and OK

CVS: cvs.openbsd.org: src

2016-03-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/29 08:53:27 Modified files: usr.sbin/authpf: authpf.c Log message: - Add missing goto in order to avoid a dereference of a null object - While here remove lint comment OK millert@

CVS: cvs.openbsd.org: src

2016-03-29 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/29 07:32:54 Modified files: usr.sbin/user : main.c user.c Removed files: usr.sbin/user : defs.h Log message: -Remove function #defines from defs.h and use the actual code accordingly in

CVS: cvs.openbsd.org: src

2016-03-28 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/28 13:42:51 Modified files: usr.sbin/user : user.c Log message: Remove cast from free(3) OK gsoares@

CVS: cvs.openbsd.org: src

2016-03-28 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/28 13:09:08 Modified files: usr.sbin/user : defs.h user.c Log message: Remove handrolled #define FREE and use free(3) directly without wrapping if (ptr!=NULL) around them since they are not needed.

CVS: cvs.openbsd.org: src

2016-03-28 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/28 10:55:09 Modified files: sbin/fdisk : fdisk.c gpt.c Log message: Remove unused variables OK krw@

CVS: cvs.openbsd.org: src

2016-03-25 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/25 10:31:32 Modified files: libexec/spamd : grey.c spamd.c Log message: - Both checks for pw are not needed since it was already done at the start of the program - Add error message to syslog if

CVS: cvs.openbsd.org: src

2016-03-20 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/16 14:16:39 Modified files: usr.sbin/inetd : inetd.c Log message: Remove a (now) obsolete comment about shortened IPv4 syntax OK deraadt@ jca@

CVS: cvs.openbsd.org: src

2016-03-20 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/16 14:15:15 Modified files: usr.sbin/inetd : inetd.c Log message: Replace strncpy(3) calls for safer strlcpy(3) OK deraadt@ jca@

CVS: cvs.openbsd.org: src

2016-03-19 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/16 08:47:04 Modified files: libexec/spamlogd: spamlogd.c Log message: - Check if user running spamlogd(8) has root privileges and if not then stop program early - #define SPAMD_USER "_spamd" and use

CVS: cvs.openbsd.org: src

2016-03-19 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/16 09:00:35 Modified files: games/atc : log.c games/hack : hack.rumors.c games/sail : misc.c games/snake: snake.c games/tetris : scores.c Log

CVS: cvs.openbsd.org: src

2016-03-18 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/18 18:21:28 Modified files: usr.bin/vi/ex : ex.c Log message: By issuing :e +something in vi(1) this uncovers a backwards memcpy with the code because the 2 buffers overlap and in order to solve it

CVS: cvs.openbsd.org: src

2016-03-15 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/15 13:56:20 Modified files: games/hack : hack.pager.c hack.unix.c Log message: execl(3) calls must have the last argument casted to (char *)NULL At the time when this was commited me and tb@

CVS: cvs.openbsd.org: src

2016-03-14 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/14 09:26:52 Modified files: lib/libc/time : localtime.c Log message: Remove doaccess variable and access(2) call since this interfers with applications like zdump(8) because pledge(2) doesn't allow

CVS: cvs.openbsd.org: src

2016-03-14 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/14 09:29:29 Modified files: usr.sbin/zdump : zdump.c Log message: zdump(8) needs to read files so it needs pledge(2) rpath promise After discussion with tb@, deraadt@ and millert@, this was also

CVS: cvs.openbsd.org: src

2016-03-08 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/08 13:07:46 Modified files: usr.bin/talk : talk.c Log message: Actually enforce what was done on rev 1.11: if one of the parties is remote it needs to pledge for inet

CVS: cvs.openbsd.org: src

2016-03-08 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/08 03:48:39 Modified files: games/adventure: done.c extern.h hdr.h init.c io.c main.c save.c subr.c vocab.c wizard.c Log message: Headers cleanup with and OK tb@ This was

CVS: cvs.openbsd.org: src

2016-03-07 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/07 05:07:57 Modified files: games/atc : atc.6 main.c games/banner : banner.c games/bcd : bcd.c games/boggle/boggle: bog.c games/bs : bs.c

CVS: cvs.openbsd.org: src

2016-03-04 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/03/04 07:37:28 Modified files: games/worms: worms.c Log message: - Convert atoi(3) to strtonum(3) - Replace hardcoded program string by getprogname(3) - Remove '?' from getopt(3)'s switch default

CVS: cvs.openbsd.org: src

2016-02-26 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/02/26 14:27:07 Modified files: games/hangman : main.c Log message: - Remove -h and -? from getopt(3), they weren't documented on manpage anyway - Replace hardcoded string "hangman" by getprogname(3)

CVS: cvs.openbsd.org: src

2016-02-26 Thread Ricardo Mestre
CVSROOT:/cvs Module name:src Changes by: mes...@cvs.openbsd.org 2016/02/26 05:10:49 Modified files: games/caesar : caesar.c Log message: - Convert atoi(3) to strtonum(3) - Remove lint-style comment - Remove usage() since errors are now more informative (the usage is

<    1   2   3   >