agnostic.
8k sectors, 8k fragments and 64k blocks should work for FFSv1 and FFSv2.
David
--
David Laight: da...@l8s.co.uk
that you couldn't avoid a lock, and algorithms
that claimed to do so were broken.
The so-called atomic ops effectively use the data item itself
as the lock.
For a single access this might be a gain because 'unlock' often
needs another synchronising bus cycle.
David
--
David Laight: da
On Mon, Aug 01, 2011 at 12:28:55PM +, Marc Balmer wrote:
According to the Oxford Dictionary of Etymology, a wether is a male sheep
or ram.
I always thought it was a ram without its 'bits'...
David
--
David Laight: da...@l8s.co.uk
and change the kernel config/build
to build modules then link the required ones into a partially
linked kernel with 'ld -r' before doing a final link to a fully
fixed up kernel.
This should also make it possible for a user to include an
extra module.
David
--
David Laight: da...@l8s.co.uk
when playing 'hunt the label'.
After all disks get moved between machines.
David
--
David Laight: da...@l8s.co.uk
to a
library.
However it is also reasonable to 'ride' another recent minor version
change.
I'd have thought that these functions could be added 'hidded' to allow
other developers (etc) to do further testing, then the version
bumped when they are made visible by default.
David
--
David Laight
as the asm output from gcc for
a compilation that is known to get it wrong.
David
--
David Laight: da...@l8s.co.uk
problem.
David
--
David Laight: da...@l8s.co.uk
problem, especially
since (char *)0 isn't a useful definition!
This is where 'lint' comes in handy, since it (effectively) checked
that args matched the inferred prototype ...
David
--
David Laight: da...@l8s.co.uk
.
Mostly make will look for files in SRCDIR before OBJDIR.
David
--
David Laight: da...@l8s.co.uk
--
David Laight: da...@l8s.co.uk
()
checking the result from ferror/fprintf will only give a false
sense of security - and make the code unreadable.
David
--
David Laight: da...@l8s.co.uk
.
David
--
David Laight: da...@l8s.co.uk
with the missing prototype being a compile error,
and remove the cast.
David
--
David Laight: da...@l8s.co.uk
for 256 sectors is probably a good idea!
David
--
David Laight: da...@l8s.co.uk
)
fcntl(fd, F_SETFD, 0);
return fd;
}
#endif
and the use open_clowxec() in the code.
David
--
David Laight: da...@l8s.co.uk
value, and the highest
value is probably useful.
David
[1] The 'memory' limits are based on the amount of physical memory,
the relevant system limit would actually include the amount of swap.
--
David Laight: da...@l8s.co.uk
of using FP registers for memory copy?
(Or some other integer-only action)
Or is that only a problem with specific architectures due to the
way the instruction set has been defined to gcc.
David
--
David Laight: da...@l8s.co.uk
that can be reordered
before/after one that matters - so need greater control than
enforcing specific membars.
David
--
David Laight: da...@l8s.co.uk
for examples.
David
--
David Laight: da...@l8s.co.uk
.
This is also true of the plethora of names for 'better' strcpy()
and sprintf() functions available on some platforms.
David
--
David Laight: da...@l8s.co.uk
the compat code loadable
- in which case this would need to be a real function call
(possibly an indirect one).
David
--
David Laight: da...@l8s.co.uk
be a nice trick...
I was thinking is something horrid that would make the source clean(ish).
Avoiding the function call is only necessary for very space-constrained
kernels. Which could be done by using a #define instead of the weak alias.
David
--
David Laight: da...@l8s.co.uk
On Thu, Dec 01, 2011 at 04:48:34PM -0500, Christos Zoulas wrote:
On Dec 1, 5:50pm, da...@l8s.co.uk (David Laight) wrote:
-- Subject: Re: CVS commit: src/sys/dev
| I'd rather the .c file wasn't polluted with #ifdefs.
| Probably better to #define fss_compat_ioctl(...) EINVAL somewhere
Hmmm... I wonder if it would (have been) better to #define 'variables'
used as pre-processor predicates to themselves (ie #define alpha alpha)
to avoid these issues?
Probably a bit late to change things though!
David
--
David Laight: da...@l8s.co.uk
out changing the LED for caps-lock (and other
locks) is pressed should change the LEDs on all keyboards, and
the inter-device cross call could also cause problems.
David
--
David Laight: da...@l8s.co.uk
printf into a separate function, so
that it doesn't stack up when called recursively. (One
just needs to make sure that the compiler doesn't
inline it again.)
Recursion in the kernel?
Isn't that really frowned upon itself?
David
--
David Laight: da...@l8s.co.uk
--
David Laight: da...@l8s.co.uk
than needed.
The advantage of Joerg's is that you don't have to 'know' the type of
the member.
Sudden barin explosion - how about (untested):
#define sizeof_var_struct(s, m, c) \
offsetof(s, m[0]) + (c) * (offsetof(s, m[1]) - offsetof(s, m[0]))
David
--
David Laight: da
think this will work:
offsetof(s, m) + n * sizeof((s*)NULL-m[0]).
I don't believe there is a problem using m[0], just m[non-constant-expr].
OTOH 'sizeof (s *)0-m[0]' might be deemed invalid (because it has
an inferred dereference of NULL.
David
--
David Laight: da...@l8s.co.uk
On Fri, Feb 24, 2012 at 09:27:09AM +0100, Joerg Sonnenberger wrote:
On Fri, Feb 24, 2012 at 08:11:19AM +, David Laight wrote:
On Thu, Feb 23, 2012 at 11:39:19PM +, Joerg Sonnenberger wrote:
Module Name: src
Committed By: joerg
Date: Thu Feb 23 23:39:19 UTC
function not 'secure' versions.
Microsoft's exception-throwing functions are even worse!
(Mind you Microsoft's _snprintf() is particulary borked.)
David
--
David Laight: da...@l8s.co.uk
in a 32bit kernel?
David
--
David Laight: da...@l8s.co.uk
a function that is like gets,
but takes a buffer length (ie discards the \n - and maybe the rest of the
line).
That could be used as a compile-time substitute when the buffer
size is known - ie when 'sizeof buffer != sizeof (char *)'
David
--
David Laight: da...@l8s.co.uk
On Sun, Mar 04, 2012 at 10:38:19PM +0200, Alan Barrett wrote:
On Sun, 04 Mar 2012, David Laight wrote:
I wonder it it would be worth adding a function that is like
gets, but takes a buffer length (ie discards the \n - and maybe
the rest of the line).
C2011 has char *gets_s(char *s
On Sun, Mar 04, 2012 at 09:42:21PM +0100, Joerg Sonnenberger wrote:
On Sun, Mar 04, 2012 at 08:20:20PM +, David Laight wrote:
I wonder it it would be worth adding a function that is like gets,
but takes a buffer length (ie discards the \n - and maybe the rest of the
line
fclose(), anything
else is mostly pointless.)
David
--
David Laight: da...@l8s.co.uk
...
David
--
David Laight: da...@l8s.co.uk
brings the value inside valid
range.
The cast is really in the wrong place as well.
I am 100% against adding casts of numeric values to appease a tool that
isn't tracking the domains of the expressions.
David
--
David Laight: da...@l8s.co.uk
On Wed, May 30, 2012 at 05:11:09PM -0700, John Nemeth wrote:
On Oct 11, 4:10pm, David Laight wrote:
}
} Module Name:src
} Committed By: dsl
} Date: Mon May 21 21:34:16 UTC 2012
}
} Modified Files:
} src/sys/arch/i386/stand/lib: exec.c
} src/sys/arch
On Thu, May 31, 2012 at 10:06:28AM +0200, Martin Husemann wrote:
On Thu, May 31, 2012 at 07:38:53AM +0100, David Laight wrote:
IIRC you can explicitly request (from boot.cfg) that any module be
loaded. There is no need for boot itself to always try to load
such a module.
Yes
On Thu, May 31, 2012 at 08:32:42PM +0200, Martin Husemann wrote:
On Thu, May 31, 2012 at 06:30:38PM +0100, David Laight wrote:
But you don't want /boot to try to load the module if the ffs code is
present in the kernel. Since /boot has no way of knowing what is in the
loaded kernel
,
like console settings configurable via installboot?
You can request it from the boot.cfg file,
there is no need for a second way - it only confuses things.
David
--
David Laight: da...@l8s.co.uk
a few more of those).
The acpi ones won't matter because acpi is LE only.
Unfortunately I don't think a cvs patch will apply ...
On Jun 3, 2012, at 09:23, David Laight wrote:
Module Name:src
Committed By: dsl
Date: Sun Jun 3 16:23:44 UTC 2012
Modified Files
+ \
- $(linecount $(sh $0.local $opts -s all)) ))
+ $(linecount $($HOST_SH $0.local $opts -s
all)) ))
Are \\s really not needed here?
Not needed for line continuations inside shell constructs.
David
--
David Laight: da...@l8s.co.uk
of the classic
device names. Fall back to classic device names when the label has an
empty name or the default name 'fictitious'.
You probably also want to detect duplicate names...
David
--
David Laight: da...@l8s.co.uk
that has (emulated?) disks where the disk
controller doesn't return the actual disk geometry/size - requiring it
be stored in the label?
David
--
David Laight: da...@l8s.co.uk
On Thu, Jul 05, 2012 at 10:34:00AM -0700, Matt Thomas wrote:
On Jul 5, 2012, at 10:25 AM, David Laight wrote:
On Thu, Jul 05, 2012 at 05:24:54PM +, Matt Thomas wrote:
Module Name: src
Committed By: matt
Date: Thu Jul 5 17:24:54 UTC 2012
Modified Files
together,
there are clearly some code paths that only want to remove one of them.
I'm almost tempted to revert the entire patch, so that it can be
applied as several separate patches.
David
--
David Laight: da...@l8s.co.uk
of adding -fno-common is to remove issues with common
data, then it is really doing the wrong thing.
You really need to error 'common' data items, not convert them to bss.
That might need a check later on the generated files.
David
--
David Laight: da...@l8s.co.uk
of constructors is basically irrelevant to matter.
So yes, this just reduces the number of semi-statically linked programs.
The size of the elf symbol and string tables may well affect
run-time performance.
(reduced pages of them, and better symbol hashing)
David
--
David Laight: da...@l8s.co.uk
(with gcc):
asm volatile ( ::: memory);
after the memset().
David
--
David Laight: da...@l8s.co.uk
/chmod the
tty device nodes.
I thought (without checking) that they would be owned by root, group tty
with at most user read and user/group write until they are actually used.
Once used they get a chown (etc) and might not get reset again.
David
--
David Laight: da...@l8s.co.uk
.
Conditionalize the test on _UC_TLSBASE being defined.
Why not just define it to be zero if it isn't needed ?
David
--
David Laight: da...@l8s.co.uk
to be convinced that the patches are correct.
David
--
David Laight: da...@l8s.co.uk
How long have they been present for?
Wouldn't it be best to leave them as valid parameters??
David
--
David Laight: da...@l8s.co.uk
On Mon, Oct 01, 2012 at 12:48:24AM +, David Holland wrote:
On Sun, Sep 30, 2012 at 08:19:52PM +, David Laight wrote:
Unfortunately apmbios.h is used by the world !
How much of it, and what would happen if we removed it entirely?
(Also, what's the recommended usermode API
codes?
David
--
David Laight: da...@l8s.co.uk
to the wrong place.
How long was it there? and was it ever in a build?
If not built it can be deleted from the repository.
David
--
David Laight: da...@l8s.co.uk
optimisations that are absent from the 'and %sp,~7' needed
to realign it.
David
--
David Laight: da...@l8s.co.uk
it can't do DMA updates of the rxsts for mbufs with addresses
= 256MB. It can't also seem to properly read from the descriptor rings
if they are 256MB. And I have no idea why either should matter.
The combination seems even more obscure.
David
--
David Laight: da...@l8s.co.uk
--
David Laight: da...@l8s.co.uk
On Sat, Oct 20, 2012 at 04:06:13AM +, David Holland wrote:
On Fri, Oct 19, 2012 at 07:58:34AM +0100, David Laight wrote:
Module Name: src
Committed By:riastradh
Date:Fri Oct 19 02:07:23 UTC 2012
Modified Files:
src/sys/kern: vfs_syscalls.c
, the
correct default public keyring will not be found. If the default
public keyring is not found, the verification will fail.
Silent truncation seems a bad thing to do in security code.
David
--
David Laight: da...@l8s.co.uk
to move the realloc() below the cond_depth+++
I'm then not sure that 128+n*32 is a sane sequence.
Possibly just n*32 - since I suspect 32 is plenty for most makefiles.
David
--
David Laight: da...@l8s.co.uk
in the headers file matches - which is
partitularly pointless since the called object code isn't required
to avoid modifying the argument memory/register (which might sometimes
be a useful optimistation).
David
--
David Laight: da...@l8s.co.uk
size we use. This allows us to cat -B 1000 /proc/pid/maps
for example which cannot handle seeking.
Isn't that what dd is for ?
David
--
David Laight: da...@l8s.co.uk
.
David
--
David Laight: da...@l8s.co.uk
list?
So it will kill something that keeps using fork() to change its pid.
David
--
David Laight: da...@l8s.co.uk
this into the kernel
so you could do all the comparisons while keeping all forks from happening?
You probably can't ...
Even in the kernel it might be 'interesting'.
David
--
David Laight: da...@l8s.co.uk
/mail: head.c
Log Message:
Fix misspelling: accommodate is a long enough word to have room for two 'c's
and two 'm's.
Two of everything except the 'd' and 't' - and there isn't room for two
of either of those.
David
--
David Laight: da...@l8s.co.uk
anyway.
David
--
David Laight: da...@l8s.co.uk
be a security risk,
and complicates the other code paths.
Which is, more or less, why i386 support was removed.
There is probably other 'support' for systems that no one has any more,
and really aren't of enough historical interest to keep supporting.
David
--
David Laight: da...@l8s.co.uk
' statements, you might
want to use the __attribute__((always_inline)).
I've seen (older) gcc fail to inline some one line functions
unless they are marked that way.
Also worth checking they need to be volatile.
If they only change memory/registers that isn't ususally true.
David
--
David Laight
) the kernel public bits, used by normal drivers
3) the bits that are private to the process handling code scheduler.
David
--
David Laight: da...@l8s.co.uk
like the fix you should look for here.
what is this EXTERNAL_TOOLCHAIN you're using? i'm totally at a loss
what this change is useful for besides re-adding a host dependancy
on sed.
It would be better to use make conditionals to fix the strings.
David
--
David Laight: da
are
run as shell builtins - and that will always be a small subset of
programs.
David
--
David Laight: da...@l8s.co.uk
On Sun, Dec 16, 2012 at 11:15:21AM +, David Laight wrote:
Module Name: src
Committed By: dsl
Date: Sun Dec 16 11:15:21 UTC 2012
Modified Files:
src/libexec/ld.elf_so: rtld.c
Log Message:
You need to pass 0 (not -1) to lwp_park() if you don't also
want to do
.
branch to unlikely cases instead of conditionally skipping them.
Or more for 'ldm' and 'stm' - esp. I think on strongarm!
Conditional execution might also be a full pipeline stall, rather
than a branch which is likely (hopefully) to be predicted correctly.
David
--
David Laight: da
On Mon, Dec 31, 2012 at 03:00:42AM +0100, Joerg Sonnenberger wrote:
On Sun, Dec 30, 2012 at 08:16:59PM +, David Laight wrote:
Module Name:src
Committed By: dsl
Date: Sun Dec 30 20:16:59 UTC 2012
Modified Files:
src/external/gpl3/gcc/dist/gcc/config
simple range checks will avoid that in most cases.
David
--
David Laight: da...@l8s.co.uk
TARGET_64BIT and ix86_preferred_stack_boundary = 64,
if the former is true the latter is also true.
can this not be overriden with cli options? the old
test seems safer.
No - for amd64 the ix86_preferred_stack_boundary is always = 64.
David
--
David Laight: da...@l8s.co.uk
of ioctl(2) which fixes the build.
That code (and zfs) seems to be built with rather generous compiler options.
David
--
David Laight: da...@l8s.co.uk
ix86_preferred_stack_boundary = 64.
The fact that it also implies SSE support is relevant.
Only as default value, not if explicitly overriden?
It won't let you override to a lower value.
David
--
David Laight: da...@l8s.co.uk
On Thu, Jan 03, 2013 at 04:42:55PM +, David Laight wrote:
Module Name: src
Committed By: dsl
Date: Thu Jan 3 16:42:55 UTC 2013
Modified Files:
src/external/cddl/osnet/sys/sys: random.h
Log Message:
Use cprgn_fast() not rnd_extract_data().
The latter isn't in any
for ARM.
If you use 'preindex with writeback' you can remove an instruction
from the loop (in strchr at least).
I'm also intrigued that these are the very simple/small versions
whereas the memcpy() (I think) was one that did all the alignment
and double-word copies!
David
--
David Laight
file' suffix rules.
Doing that would make it much easier for some sub-architectures to
fall back on the .c version even when a .S one exists (but, for example,
uses unavailable instructions).
David
--
David Laight: da...@l8s.co.uk
and set errno to ENOTSUPP.
Could the 'char *' pointers be replaced with indexes into an array?
David
--
David Laight: da...@l8s.co.uk
On Fri, Jan 25, 2013 at 04:06:09PM -0700, Warner Losh wrote:
On Jan 25, 2013, at 4:05 PM, David Laight wrote:
Log Message:
For platforms where we cannot fit a char * into a long, return NULL
and set errno to ENOTSUPP.
Could the 'char *' pointers be replaced with indexes
is a bogus fix.
Not much point writing an error is you'vejust failed to write to stderr!
David
--
David Laight: da...@l8s.co.uk
sysctllog **);
+typedef void sysctl_setup_func(struct sysctllog **);
IIRC you are only supposed to be able to typedef pointers to functions.
The extra level of indirection (that caused the horrid casting)
is elsewhere.
(I wasn't at all sure the previous 'fix' was right.)
David
--
David
for make to parse :-)
David
--
David Laight: da...@l8s.co.uk
; export y=$x; echo $y; (echo $b))
outputs a and fubar (on two lines).
David
--
David Laight: da...@l8s.co.uk
On Mon, Feb 25, 2013 at 08:43:51PM +, David Laight wrote:
On Mon, Feb 25, 2013 at 06:54:13PM +, David Holland wrote:
On Mon, Feb 25, 2013 at 06:49:51PM +, Julio Merino wrote:
Log Message:
Cherry-pick upstream change d0daf9983f5a0e635f1127dbc827aa114daa90d8:
Fix
tick?
David
--
David Laight: da...@l8s.co.uk
On Sat, Mar 09, 2013 at 12:19:08AM +0100, Martin Husemann wrote:
On Fri, Mar 08, 2013 at 11:03:23PM +, David Laight wrote:
Should the 'no timeout' case (try to) check that the elapsed time is
less than one tick?
I gave the (partly virtual) test platforms a bit more slope and made
is interpreted
as EPERM.
Hmmm... NetBSD usually uses +ve errno values.
David
--
David Laight: da...@l8s.co.uk
to retry if curlwp took a context switch during the call.
I didn't think mutex_enter() blocked - isn't it a spinlock.
Which means that if things are going wrong they can go wrong
even if the mutex is available immediately.
David
--
David Laight: da...@l8s.co.uk
to decide what to do.
David
--
David Laight: da...@l8s.co.uk
!
David
--
David Laight: da...@l8s.co.uk
101 - 200 of 291 matches
Mail list logo
