Re: [PATCH V2 01/12] spi/mxs: Always set LOCK_CS

2013-07-10 Thread Lothar Waßmann
experience the HW deasserts CS whenever the output fifo runs empty. Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen

Re: [06/10,V2] spi: Add SPI driver for mx233/mx28

2012-08-01 Thread Lothar Waßmann
be paired with an spi_master_put() call to free the resources. The kfree() is taken care of by the spi_master_release() function that is called once the last reference to the underlying struct device has been released. Thus kfree() must not be called after spi_alloc_master(). Lothar Waßmann

Re: [PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data

2011-07-11 Thread Lothar Waßmann
Hi, Shawn Guo writes: On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote: Hi, Shawn Guo writes: spi_imx_devtype_data has already been driver private data. There is really no need to make a copy in spi_imx_data. Instead, a reference pointer works perfectly fine

Re: [PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data

2011-07-11 Thread Lothar Waßmann
needed and discard everything else after initialisation. Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag

Re: [PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data

2011-07-11 Thread Lothar Waßmann
Uwe Kleine-König writes: On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote: Hi, Shawn Guo writes: spi_imx_devtype_data has already been driver private data. There is really no need to make a copy in spi_imx_data. Instead, a reference pointer works perfectly fine

Re: [PATCH 04/16] spi/imx: save the spi chip select in config struct, not the gpio to use

2010-09-17 Thread Lothar Waßmann
SPI_CS_HIGH) reg |= MX31_CSPICTRL_SSPOL; - if (config-cs 0) { - reg |= (config-cs + 32) MX31_CSPICTRL_CS_SHIFT; - } + if (cs 0) This can never be true, since an 'int' promoted from 'u8' will always be positive! Lothar Waßmann

Re: [PATCH 2/6] i.MX5/clock: add eCSPI and CSPI clock definitions

2010-09-10 Thread Lothar Waßmann
is wrong here, no? Sascha used spba_clk here, too. I didn't found out yet how to read that out of the reference manual. The Freescale BSP used aips_tz2_clk (and spba for cspi1). They should know what's right. Maybe a copy/paste error from Sascha? Lothar Waßmann

Re: [PATCH 1/6] spi-imx: add CSPI and eCSPI support for i.MX51 MCU

2010-09-03 Thread Lothar Waßmann
Hi, On Thu, Sep 02, 2010 at 05:11:56PM +0200, Lothar Waßmann wrote: - if (cpu_is_mx25() || cpu_is_mx31() || cpu_is_mx35()) { + /* i.MX51 has two eCSPI and one CSPI controllers, eCSPI controllers are +* not compatible with existing SPI controllers on other

Re: [PATCH 1/6] spi-imx: add CSPI and eCSPI support for i.MX51 MCU

2010-09-02 Thread Lothar Waßmann
it belongs (in the arch specific code). Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht