On Tue, Apr 02, 2013 at 05:19:44AM -0700, Trent Piepho wrote:
> There are two bits which control the CS line in the CTRL0 register:
> LOCK_CS and IGNORE_CRC. The latter would be better named DEASSERT_CS
> in SPI mode.
>
> LOCK_CS keeps CS asserted though the entire transfer. This should
> always
.
Signed-off-by: Shawn Guo
Cc: Grant Likely
Cc: spi-devel-general@lists.sourceforge.net
---
Documentation/devicetree/bindings/spi/mxs-spi.txt | 12 +++--
drivers/spi/spi-mxs.c | 60 -
include/linux/spi/mxs-spi.h |4
On Wed, Oct 31, 2012 at 11:30:10AM +0100, Maxime Ripard wrote:
> There is no driver for it yet, so it will use spidev.
>
> Signed-off-by: Maxime Ripard
Applied, thanks.
--
LogMeIn Central: Instant, anywhere, Remote PC
Mark is maintaining spi subsystem recently as Grant has been off line
for a while.
Shawn
On Thu, Oct 18, 2012 at 03:59:27PM +0200, Maxime Ripard wrote:
> This will allow to probe spidev from device tree
>
> Signed-off-by: Maxime Ripard
> ---
> drivers/spi/spidev.c | 10 ++
> 1 file c
to the clock polarity ECSPIx_CONFIGREG:SCLK POL:
>
> DT without "spi-cpol" = 0 = clock active high polarity = inactive state low
> DT with"spi-cpol" = 1 = clock active low polarity = inactive state high
>
Copy Uwe ...
On Fri, Aug 31, 2012 at 10:55:11AM +0200, Dirk Behme wrote:
> From: Knut Wohlrab
>
> There are SPI devices which need a SPI clock with active low polarity and
> high inactive state.
>
> Add the setting of the inactive state ECSPIx_CONFIGREG:SCLK CTL
> according to the clock polarit
LRADC, USB. Also, remove bogus AUART3.
>
> Signed-off-by: Marek Vasut
> Cc: Chris Ball
> Cc: Fabio Estevam
> Cc: Mark Brown
> Cc: Shawn Guo
> ---
> arch/arm/boot/dts/imx28-m28evk.dts | 98
> +---
> arch/arm/mach-mxs/mach-mxs.c |
Cc: Mark Brown
> Cc: Shawn Guo
> ---
> arch/arm/boot/dts/imx28.dtsi | 61
> ++
> 1 file changed, 61 insertions(+)
>
> NOTE: Shawn, I'd like to add this altogether. I have a board scheduled in my
> queue that uses ot
gt; way.
For mxs-mmc part:
Reviewed-by: Shawn Guo
Chris,
Can you take a look at the series and give your ACK to bless it go via
SPI tree?
--
Regards,
Shawn
--
Live Security Virtual Conference
Exclusive live event w
On Fri, Aug 03, 2012 at 05:26:15PM +0200, Marek Vasut wrote:
> Signed-off-by: Marek Vasut
> Cc: Attila Kinali
> Cc: Chris Ball
> CC: Dong Aisheng
> Cc: Fabio Estevam
> Cc: Grant Likely
> Cc: Linux ARM kernel
> Cc: Mark Brown
> CC: Shawn Guo
> ---
> ar
On Fri, Aug 03, 2012 at 04:30:39PM +0200, Maxime Ripard wrote:
> If you don't do it, the bus number will be a bogus value, possibly used
> for device file names in drivers like spidev.
>
Do you see any problem with that? Here is the take from Grant.
http://thread.gmane.org/gmane.linux.kernel.spi
On Thu, Aug 02, 2012 at 04:58:38PM +0200, Marek Vasut wrote:
> Hm, this is spread across mxs. Shawn, is there any plan for PM implementation
> for MXS ?
>
Near term, no. Long term, yes.
--
Regards,
Shawn
--
Live Secu
On Wed, Aug 01, 2012 at 09:38:07AM +0200, Lothar Waßmann wrote:
> Shawn Guo writes:
> > On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
> > > > I must be missing something. Why do almost all spi drivers call it in
> > > > the
> > >
On Tue, Jul 31, 2012 at 11:56:50PM -0700, Guenter Roeck wrote:
> Guess we are in violent agreement. The sequence would then either be
> master = spi_alloc_device();
The discussion is around spi_alloc_master rather than spi_alloc_device,
isn't it?
Regards,
Shawn
> ...
> spi_mast
On Wed, Aug 01, 2012 at 03:40:53PM +0800, Shawn Guo wrote:
> On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
> > > I must be missing something. Why do almost all spi drivers call it in the
> > > error path, even if there is no call to spi_master_get ?
> >
On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
> > I must be missing something. Why do almost all spi drivers call it in the
> > error path, even if there is no call to spi_master_get ?
>
> To push the refcounting to 0, to deallocate the device, I'd say ...
>
It's not going to work
On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
> On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
> > On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> > > Anyone up for writing some patches ? If not, I'll do it.
> > >
>
On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
> Anyone up for writing some patches ? If not, I'll do it.
>
Go ahead.
Regards,
Shawn
--
Live Security Virtual Conference
Exclusive live event will cover al
On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:
> I think the call to spi_master_put() triggers the call to
> spi_master_release().
> If so, kfree() would not be needed at all, and the documentation is wrong.
>
Also those drivers calling kfree in probe.
Regards,
Shawn
--
On Wed, Aug 01, 2012 at 04:31:04AM +0200, Marek Vasut wrote:
> > Couple of reasons for asking: No other SPI master driver calls it in the
> > remove function (unless I missed it), most drivers don't call it in the
> > probe function error path, and if I call it in the remove function in a
> > SPI m
On Tue, Jul 31, 2012 at 01:53:00PM -0700, Guenter Roeck wrote:
> > + spi_master_put(host);
> > + kfree(host);
> > +
>
> Is the kfree() here and in the probe function really necessary ?
>
The following is how the kerneldoc of spi_alloc_master says.
* The caller is responsible for assigning
On Tue, Jul 24, 2012 at 09:43:48PM +0200, Marek Vasut wrote:
> This is actually not the first place I was curious about in the imx28 DTS ...
> yes, the size is 0x2000, but "2000" as is is used in multiple places across
> imx28. Shawn?
>
It seems that I overlooked the problem when it got introduc
On 5 July 2012 13:39, Marek Vasut wrote:
>> So SPI_MXS may need to select STMP_DEVICE.
>
> Ok, fixed in my tree. But, where's the meteor shower of nitpicks and such
> stuff?
I do not take this as a nitpick at all. Removing those drivers
selecting STMP_DEVICE from mxs_defconfig, your driver does
On 5 July 2012 13:46, Marek Vasut wrote:
> Correct, this I fixed in my tree and will repost the series. I also fixed the
> documentation issue. But ... what about the rest of the series, are you OK
> with
> it as is ?
>
Yes, it looks okay to me.
Regards,
Shawn
--
On Fri, Jun 29, 2012 at 10:22:58AM +0200, Marek Vasut wrote:
> +config SPI_MXS
> + tristate "Freescale MXS SPI controller"
> + depends on ARCH_MXS
> + help
> + SPI driver for Freescale MXS devices.
> +
...
> + stmp_reset_block(ssp->base);
> +
So SPI_MXS may need to select ST
On Tue, Jun 26, 2012 at 02:22:54PM +0200, Marek Vasut wrote:
> > > +static int __devexit mxs_spi_remove(struct platform_device *pdev)
> > > +{
> > > + struct spi_master *host;
> > > + struct mxs_ssp *ssp;
> > > +
> > > + host = platform_get_drvdata(pdev);
> > > + if (host)
> > > + return 0;
On Tue, Jun 26, 2012 at 02:16:11PM +0200, Marek Vasut wrote:
> So why are those imx28-mmc there ? Shall these not be removed then ?
>
They are still needed by those non-DT board files. Once we have those
board files removed, these imx28-mmc lookups will not be needed any
longer.
--
Regards,
Sha
tevam
> Signed-off-by: Marek Vasut
> Cc: Chris Ball
> Cc: Detlev Zundel
> CC: Dong Aisheng
> Cc: Grant Likely
> Cc: Linux ARM kernel
> Cc: Rob Herring
> CC: Shawn Guo
> Cc: Stefano Babic
> Cc: Wolfgang Denk
> ---
> drivers/spi/Kconfig |6 +
On Sat, Jun 23, 2012 at 08:43:50PM +0200, Marek Vasut wrote:
> Signed-off-by: Marek Vasut
> Cc: Chris Ball
> Cc: Detlev Zundel
> CC: Dong Aisheng
> Cc: Fabio Estevam
> Cc: Grant Likely
> Cc: Linux ARM kernel
> Cc: Rob Herring
> CC: Shawn Guo
> Cc: Stef
isheng
> Cc: Grant Likely
> Cc: Linux ARM kernel
> Cc: Rob Herring
> CC: Shawn Guo
> Cc: Stefano Babic
> Cc: Wolfgang Denk
> ---
> drivers/mmc/host/mxs-mmc.c | 87 ++
> include/linux/spi/mxs-spi.h | 109
> ++
On Sat, May 19, 2012 at 10:40:30PM -0600, Grant Likely wrote:
> Can I assume all the patches in this series will be merged via the
> same branch?
>
Yes, we will have them all go via arm-soc.
--
Regards,
Shawn
--
Live S
On Mon, May 07, 2012 at 02:50:02PM +0800, Dong Aisheng wrote:
> Shouldn't we add the pinctrl states in dts file at the same time
> with this patch series or using another separate patch to add them
> before this series to avoid breaking the exist mx6q platforms?
>
Ah, I just noticed that your patc
Cc: spi-devel-general@lists.sourceforge.net
Cc: Grant Likely
Signed-off-by: Shawn Guo
---
drivers/spi/spi-imx.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 570f220..69c9a66 100644
--- a/drivers/spi/spi-imx.c
would expect to ask Arnd and Olof to pull pinctrl tree into arm-soc
as a dependency and then have series [1] and this patch set go through
arm-soc tree to ease the merge process.
Resend to have subsystem lists Cc-ed.
Regards,
Shawn
[1] http://thread.gmane.org/gmane.linux.kernel.mmc/14180
Shawn
On 25 April 2012 09:52, Fabio Estevam wrote:
> int spi_register_master(struct spi_master *master)
> {
> - static atomic_t dyn_bus_id = ATOMIC_INIT((1<<15) - 1);
> struct device *dev = master->dev.parent;
> struct boardinfo *bi;
> int
On Wed, Apr 18, 2012 at 09:30:34PM -0300, Fabio Estevam wrote:
...
> #define HW_SSP_VERSION (cpu_is_mx23() ? 0x110
> : 0x130)
This is something needs a bit work (as well as mxs-mmc). The VERSION
register sits on different address between imx23 and imx28, so it lose
On 20 April 2012 11:07, Fabio Estevam wrote:
> On Thu, Apr 19, 2012 at 11:59 PM, Shawn Guo wrote:
>
>> We are trying to remove from drivers. And this patch moves
>> to the opposite direction.
>
> Where would be a good location for ssp-regs.h then?
>
include
On Wed, Apr 18, 2012 at 09:30:33PM -0300, Fabio Estevam wrote:
> On mxs SoCs the SSP controller can act as MMC or SPI controller.
>
> Remove the SSP related definitions from the mxs-mmc driver and put it on a
> common header file.
>
> This will facilitate the introduction of the spi-mxs driver.
On Tue, Apr 10, 2012 at 09:47:02AM +0100, Russell King - ARM Linux wrote:
...
> In any case, what would really help is if people would discard patches
> they no longer want applying.
Ok, I did not know it before. Just marked my patch "discarded".
--
Regards,
Shawn
ll be active and
> cause AMBA to hold the supply on anyway.
>
> Signed-off-by: Mark Brown
Tested-by: Shawn Guo
Russell,
I believe this patch fixes the amba probe failure that impacts any
AMBA platform build with CONFIG_REGULATOR enabled. Could you consider
to send the fix for -r
Forgot to mention in my last reply that I recently added device tree
probe support for mc13xxx-core which has hit the mainline, so you may
need to rebase this series, or you will be asked by Samuel to anyway,
I guess :)
One nit on the subject of this patch: you may want to have prefix
"mfd: mc13xx
Hi Marc,
On Thu, Jan 19, 2012 at 12:01:31PM +1100, Marc Reilly wrote:
> Hi,
>
> This series (based on 3.2) adds I2C support for the mc13xxx family PMICs.
> The patches are similar, but not identical to my previous patches for this
> [1], the
> main difference being the way the config items are d
On Mon, Dec 05, 2011 at 03:47:08PM +0800, Axel Lin wrote:
> Simplify the error handling by moving the code to free gpios in one place.
>
> Signed-off-by: Axel Lin
Acked-by: Shawn Guo
Regards,
Shawn
--
All
On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote:
> Hi,
>
> Shawn Guo writes:
> > spi_imx_devtype_data has already been driver private data. There is
> > really no need to make a copy in spi_imx_data. Instead, a reference
> > pointer works perfectly
SPI_IMX_VER_0_4.
It also renames function spi_imx0_4_reset to mx31_reset to keep
consistency with other function naming.
A couple of redundant macros, MX3_CSPISTAT and MX3_CSPISTAT_RR,
together with the useless type SPI_IMX_VER_0_5 also get cleaned up.
Signed-off-by: Shawn Guo
Cc: Uwe Kleine-König
Cc
spi_imx_devtype_data has already been driver private data. There is
really no need to make a copy in spi_imx_data. Instead, a reference
pointer works perfectly fine.
Signed-off-by: Shawn Guo
Cc: Uwe Kleine-König
Cc: Sascha Hauer
Cc: Grant Likely
---
drivers/spi/spi-imx.c | 24
SPI_IMX_VER_0_0 covers i.mx21 and i.mx27. It makes more sense to
use mx21 rather than mx27 to name SPI_IMX_VER_0_0 function and
macro, since i.mx21 comes out ealier than i.mx27.
Signed-off-by: Shawn Guo
Cc: Uwe Kleine-König
Cc: Sascha Hauer
Cc: Grant Likely
---
drivers/spi/spi-imx.c | 67
mx51_ecspi might be a good choice.
Signed-off-by: Shawn Guo
Cc: Uwe Kleine-König
Cc: Sascha Hauer
Cc: Grant Likely
---
drivers/spi/spi-imx.c | 107 +
1 files changed, 54 insertions(+), 53 deletions(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi
It adds device tree probe support for spi-imx driver.
Signed-off-by: Shawn Guo
Cc: Grant Likely
---
.../devicetree/bindings/spi/fsl-imx-cspi.txt | 22 +++
drivers/spi/spi-imx.c | 38
2 files changed, 53 insertions(+), 7
It copies gpio number passed via platform data embedded pointer into
driver private data, so that we do not need to refer to this embedded
pointer passed by platform data after probe function exits.
Signed-off-by: Shawn Guo
Cc: Uwe Kleine-König
Cc: Sascha Hauer
Cc: Grant Likely
---
drivers
spi_imx_data and adds devtype there, so that
fifosize can be set in an inline function according to devtype.
Also, cpu_is_mx can be replaced by inline functions checking devtype.
Signed-off-by: Shawn Guo
Cc: Uwe Kleine-König
Cc: Sascha Hauer
Cc: Grant Likely
---
arch/arm/mach-imx/clock-imx25.c
later.
* Drop dt helper patches, as they are on Grant's tree
Shawn Guo (7):
spi/imx: do not make copy of spi_imx_devtype_data
spi/imx: use mx21 to name SPI_IMX_VER_0_0 function and macro
spi/imx: do not use spi_imx2_3 to name SPI_IMX_VER_2_3 function and macro
spi/imx:
On Fri, Jul 08, 2011 at 01:01:42PM -0600, Grant Likely wrote:
> On Fri, Jul 08, 2011 at 04:27:28PM +0800, Shawn Guo wrote:
> > The patch set makes some cleanups on imx spi driver to get it ready
> > for adding device tree probe and then add the support.
> >
> > T
On Fri, Jul 08, 2011 at 12:58:51PM +0200, Sascha Hauer wrote:
> On Fri, Jul 08, 2011 at 04:27:30PM +0800, Shawn Guo wrote:
> > Software defined version number is not stable enough to be used
> > in device type naming scheme. The patch changes it to use implicit
> > soc nam
included in mach/gpio.h.
The patch cleans the unnecessary header file from mach/gpio.h,
and includes headers explicitly where needed.
Signed-off-by: Shawn Guo
Cc: Grant Likely
Cc: Sascha Hauer
---
arch/arm/plat-mxc/include/mach/gpio.h |2 --
drivers/spi/spi-imx.c |1 +
2
ng (1):
dt: add helper function to read u32 arrays
Shawn Guo (5):
ARM: mxc: remove unnecessary header file inclusion from gpio.h
spi/imx: use soc name in spi device type naming scheme
spi/imx: copy gpio number passed by platform data into driver private data
dt: add
The patch adds empty functions of_property_read_u32 and
of_property_read_u32_array for non-dt build, so that drivers
migrating to dt can save some '#ifdef CONFIG_OF'.
Signed-off-by: Shawn Guo
Cc: Rob Herring
Cc: Thomas Abraham
Cc: Grant Likely
---
include/linux/of.h | 15
It adds device tree probe support for spi-imx driver.
Signed-off-by: Shawn Guo
Cc: Grant Likely
---
.../devicetree/bindings/spi/fsl-imx-cspi.txt | 22 +++
drivers/spi/spi-imx.c | 38
2 files changed, 53 insertions(+), 7
From: Rob Herring
Rework of_property_read_u32 to read an array of values. Then
of_property_read_u32 becomes an inline with array size of 1.
Also make struct device_node ptr const.
Signed-off-by: Rob Herring
Cc: Thomas Abraham
Cc: Grant Likely
---
drivers/of/base.c | 19 +-
It copies gpio number passed via platform data embedded pointer into
driver private data, so that we do not need to refer to this embedded
pointer passed by platform data after probe function exits.
Signed-off-by: Shawn Guo
Cc: Uwe Kleine-König
Cc: Sascha Hauer
Cc: Grant Likely
---
drivers
Software defined version number is not stable enough to be used
in device type naming scheme. The patch changes it to use implicit
soc name for spi device type definition. In this way, we can easily
align the naming scheme with device tree binding, which comes later.
Signed-off-by: Shawn Guo
61 matches
Mail list logo
