Re: [Spice-devel] [PATCH 10/12] move WARN and WARN_ONCE to spice_common.h

2011-04-27 Thread Christophe Fergeau
This breaks opengl compilation, I'll send a fixed patch On Fri, Apr 22, 2011 at 06:43:08PM +0200, Christophe Fergeau wrote: > --- > common/glc.c |8 > common/rop3.c |8 ++-- > common/spice_common.h |2 ++ > 3 files changed, 4 insertions(+), 14 deletions(-

Re: [Spice-devel] [PATCH 05/12] common: don't duplicate find_msb implementation

2011-04-27 Thread Christophe Fergeau
On Fri, Apr 22, 2011 at 06:43:03PM +0200, Christophe Fergeau wrote: > --- > common/bitops.h | 89 > + > common/gl_utils.h | 58 ++ > common/quic.c | 14 +--- > 3 files changed, 94 insertions(+), 67

[Spice-devel] [PATCHv2 05/12] common: don't duplicate find_msb implementation

2011-04-27 Thread Christophe Fergeau
--- common/Makefile.am |1 + common/bitops.h| 89 common/gl_utils.h | 58 ++ common/quic.c | 14 +--- 4 files changed, 95 insertions(+), 67 deletions(-) create mode 100644 common/bitops.h

[Spice-devel] [PATCHv2 10/12] move WARN and WARN_ONCE to spice_common.h

2011-04-27 Thread Christophe Fergeau
--- common/glc.c | 11 ++- common/ogl_ctx.c |1 + common/rop3.c |8 ++-- common/spice_common.h |2 ++ 4 files changed, 7 insertions(+), 15 deletions(-) diff --git a/common/glc.c b/common/glc.c index 0396fc9..1c81dd8 100644 --- a/common/glc.c +++ b/c

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote: > Hi, > > I started to see frequent crashes with my guests running windows xp and > windows server 2003 x86. The bsod appears on qxldd.dll. I can give further > info if needed. please. what qxldd.dll are you using? can you run with -

Re: [Spice-devel] [PATCHv2 10/12] move WARN and WARN_ONCE to spice_common.h

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 09:40:12AM +0200, Christophe Fergeau wrote: Not related to the patch, but what do you use to send the v2 patch to reply to this specific message? --in-reply-to? Any chance you already have a script that does the following: given existing patchset (possibly just as a git ra

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Alon Levy
On Tue, Apr 26, 2011 at 08:39:13PM +0200, Attila Sukosd wrote: > Also I've attached the patch which fixes a few things here and there... With > this it builds fine. > Can you clean up the commenting out part of the patch (Makefile.am you comment out a single line, you can probably ifdef it based

Re: [Spice-devel] androidSpice-0.1.4 released

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 10:30:18AM +0800, Shuxiang Lim wrote: > Hi,all! >Thanks for the trying/feedbacking and sorry for the nascent itches of the > project. >As I've mentioned in the wiki page of this proj.,to use the androidSpice, > the server should be modified to force the use of JPEG c

[Spice-devel] spice-gtk 0.6 : Ctrl+W closes the client

2011-04-27 Thread Frédéric Grelot
Hi all, I finally decided to give a try to the gtk version of spice client. First, I have to say that I'm quite impressed (and I understand why it tends to become the baseline client). Still, there is one bug that I would consider blocking (as far as I'm concerned) : I'm pretty used to the "Ct

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-04-27 Thread Emre Erenoglu
On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy wrote: > On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote: > > Hi, > > > > I started to see frequent crashes with my guests running windows xp and > > windows server 2003 x86. The bsod appears on qxldd.dll. I can give > further > > info if

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Tue, Apr 26, 2011 at 08:39:13PM +0200, Attila Sukosd wrote: > Also I've attached the patch which fixes a few things here and there... With > this it builds fine. Ah, so you've already built spice-gtk on macosx? How well did it work? I had some questions about your patch, it would be really hel

Re: [Spice-devel] [PATCHv2 10/12] move WARN and WARN_ONCE to spice_common.h

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 11:14:59AM +0300, Alon Levy wrote: > On Wed, Apr 27, 2011 at 09:40:12AM +0200, Christophe Fergeau wrote: > > Not related to the patch, but what do you use to send the v2 patch to reply > to this specific message? --in-reply-to? Any chance you already have a script > that do

Re: [Spice-devel] androidSpice-0.1.4 released

2011-04-27 Thread Shuxiang Lim
Yep,it's really nasty. But if I want to leverage FULL spice image ability,I have to: 1.Fix the bugs of sigbus in quic.c on Android by rewriting the pointer-type-cast into memcpy.etc.. 2.Then,then,I got the processed image buffer in memory,BUT,HOW can I output it??? AFAIK,android offer no image o

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Mosebach Kai
I finally build it on OSX 10.6.6 successfully :-) >From the patches below I only used : common/lines.c gtk/Makefile.am Then a ./configure --with-audio=gstreamer --without-python --with-coroutine=gthread did the trick, I think --with-coroutine=gthread avoid the _XOPEN_SOURCE patches. Best Ka

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Tue, Apr 26, 2011 at 05:10:43PM +0200, Kai Mosebach wrote: > I just triesbuild the OSX gtk client, my findings : > > 1.) Installed gtk2 and gstreamer via ports Do you get a gtk2 version using x11 or the "native" osx port when you get it from (mac?)ports ? Christophe pgp3ZllVEhXHR.pgp Descri

Re: [Spice-devel] spice-gtk 0.6 : Ctrl+W closes the client

2011-04-27 Thread Christophe Fergeau
Hi Frédéric, On Wed, Apr 27, 2011 at 10:28:04AM +0200, Frédéric Grelot wrote: > I finally decided to give a try to the gtk version of spice client. > First, I have to say that I'm quite impressed (and I understand why it > tends to become the baseline client). Still, there is one bug that I > wou

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Kai Mosebach
- Its the x11 version - sound is not working atm :/ - throughput of a video takes approx. +70% of the bandwidth of the old spicec.exe + wine (incl. sound) The wine+spicec.exe takes <9 MBit/sec for a random news video with a res. of 1280 x 864, the new one is at <14MBit ... Any thoughts? Best Ka

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Kai Mosebach
Regarding the native gtk2 build I think its not possible with macports. You would need to use this I guess : http://gtk-osx.sourceforge.net/ Cheers Kai On 4/27/11 11:18 AM, "Christophe Fergeau" wrote: >On Tue, Apr 26, 2011 at 05:10:43PM +0200, Kai Mosebach wrote: >> I just triesbuild the OSX gt

Re: [Spice-devel] androidSpice-0.1.4 released

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 04:54:55PM +0800, Shuxiang Lim wrote: > Yep,it's really nasty. >But if I want to leverage FULL spice image ability,I have to: > 1.Fix the bugs of sigbus in quic.c on Android by rewriting the > pointer-type-cast into memcpy.etc.. No idea what the problem is, is it a compi

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 12:38:04PM +0400, Emre Erenoglu wrote: > On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy wrote: > > > On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote: > > > Hi, > > > > > > I started to see frequent crashes with my guests running windows xp and > > > windows serv

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 11:27:53AM +0200, Kai Mosebach wrote: > Regarding the native gtk2 build I think its not possible with macports. > You would need to use this I guess : http://gtk-osx.sourceforge.net/ yes, trying out http://sourceforge.net/apps/trac/gtk-osx/wiki/Build is part of my medium te

Re: [Spice-devel] Spice-devel Digest, Vol 15, Issue 78

2011-04-27 Thread Federico Alves
> #include >>+#define NO_IMPORT_PYGOBJECT >> >>This one seems to be here for the same kind of issues as what led to >>https://gitorious.org/rb-lastfm/rb-lastfm/commit/ab102ef5a954eb87354c3467 >>d >>1a35c8fa596242b >>but I must say I don't understand

[Spice-devel] [CIFEX] A file available for download from Kai Mosebach

2011-04-27 Thread Kai Mosebach
Hello spice-devel@lists.freedesktop.org, Kai Mosebach has stored a file on our server for you to download. File information appears below. From: Kai Mosebach Email:kai.moseb...@bsse.ethz.ch The file is (follow link to downlo

Re: [Spice-devel] [CIFEX] A file available for download from Kai Mosebach

2011-04-27 Thread Kai Mosebach
Please note that these are the libs + the client only and they rely on working versions of the depending libs (such as gstreamer etc) To find out where it expects what you can run $ otool -L libspice-client-glib-2.0.2.dylib (ldd equivalent in osx) Cheers Kai On 4/27/11 11:51 AM, "Kai Mosebach"

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-04-27 Thread Gianluca Cecchi
On Wed, Apr 27, 2011 at 10:38 AM, Emre Erenoglu wrote: > On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy wrote: >> >> On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote: >> > Hi, >> > >> > I started to see frequent crashes with my guests running windows xp and >> > windows server 2003 x86.

Re: [Spice-devel] [CIFEX] A file available for download from Kai Mosebach

2011-04-27 Thread Mosebach Kai
For this you should have a working build process and then write some "after processing" script which packs things together automatically (such as the binaries below) + all needed libs and the throw it into a pkg or dmg automatically. It'd be a nice to have but surely takes more than some minutes ..

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-04-27 Thread Emre Erenoglu
On Wed, Apr 27, 2011 at 2:00 PM, Gianluca Cecchi wrote: > On Wed, Apr 27, 2011 at 10:38 AM, Emre Erenoglu > wrote: > > On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy wrote: > >> > >> On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote: > >> > Hi, > >> > > >> > I started to see frequent cr

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 12:00:34PM +0200, Gianluca Cecchi wrote: > On Wed, Apr 27, 2011 at 10:38 AM, Emre Erenoglu wrote: > > On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy wrote: > >> > >> On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote: > >> > Hi, > >> > > >> > I started to see frequ

Re: [Spice-devel] [PATCH 1/9] build: make it silent

2011-04-27 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:20PM +0100, Marc-André Lureau wrote: > This patch make it easier to spot warnings in compilation. It should > work with older versions of automake that don't support silent rules. This one was already applied in 0e64e2d0 in November Christophe pgpJjjGKTG7sS.pgp De

Re: [Spice-devel] [PATCH 2/9] build: require c99

2011-04-27 Thread Christophe Fergeau
Why do you want to require c99? Do the compilers we use on windows have good enough c99 support? Christophe On Tue, Jan 25, 2011 at 07:17:21PM +0100, Marc-André Lureau wrote: > --- > configure.ac |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/con

Re: [Spice-devel] [PATCH 3/9] common: RFC: add windows.h where required, make gdi_handlers static

2011-04-27 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:22PM +0100, Marc-André Lureau wrote: > This patch has not been verified. Somebody with VS should check if it > still compiles and run fine before applying it. Making gdi_handlers makes a lot of sense to me. I couldn't find on google or with git grep anything that woul

Re: [Spice-devel] [PATCH 4/9] common: ring.h should include stddef for NULL usage

2011-04-27 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:23PM +0100, Marc-André Lureau wrote: > diff --git a/common/ring.h b/common/ring.h > index defa1ed..dcd3fbf 100644 > --- a/common/ring.h > +++ b/common/ring.h > @@ -19,6 +19,8 @@ > #ifndef _H_RING2 > #define _H_RING2 > > +#include > + These days ring.h includes sp

Re: [Spice-devel] [PATCH 5/9] common: ring.h: define ASSERT if undefined

2011-04-27 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:24PM +0100, Marc-André Lureau wrote: > diff --git a/common/ring.h b/common/ring.h > index dcd3fbf..cdfe7e1 100644 > --- a/common/ring.h > +++ b/common/ring.h > @@ -21,6 +21,11 @@ > > #include > > +#ifndef ASSERT > +# include > +# define ASSERT(X) assert(X) > +#e

Re: [Spice-devel] [PATCH 6/9] common: spice_memdup could accept NULL

2011-04-27 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:25PM +0100, Marc-André Lureau wrote: > diff --git a/common/mem.c b/common/mem.c > index b0a7eb1..4db8a2c 100644 > --- a/common/mem.c > +++ b/common/mem.c > @@ -71,6 +71,10 @@ void *spice_memdup(const void *mem, size_t n_bytes) > { > void *copy; > > +if (mem

Re: [Spice-devel] [PATCH 2/9] build: require c99

2011-04-27 Thread Marc-André Lureau
- Original Message - > Why do you want to require c99? Do the compilers we use on windows > have > good enough c99 support? Because we use c99: stdbool.h, inttypes.h, bool, variadic macros, // comments, ... Actually, I wonder if 43c5b4f97334f0f4ca61bdd679b68d079575deac is redundant if

Re: [Spice-devel] [PATCH 6/9] common: spice_memdup could accept NULL

2011-04-27 Thread Marc-André Lureau
- Original Message - > On Tue, Jan 25, 2011 at 07:17:25PM +0100, Marc-André Lureau wrote: > > diff --git a/common/mem.c b/common/mem.c > > index b0a7eb1..4db8a2c 100644 > > --- a/common/mem.c > > +++ b/common/mem.c > > @@ -71,6 +71,10 @@ void *spice_memdup(const void *mem, size_t > > n_byt

Re: [Spice-devel] [PATCH 3/9] common: RFC: add windows.h where required, make gdi_handlers static

2011-04-27 Thread Marc-André Lureau
- Original Message - > On Tue, Jan 25, 2011 at 07:17:22PM +0100, Marc-André Lureau wrote: > > This patch has not been verified. Somebody with VS should check if > > it > > still compiles and run fine before applying it. > > Making gdi_handlers makes a lot of sense to me. I couldn't find o

Re: [Spice-devel] [PATCH 2/9] build: require c99

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:22:34AM -0400, Marc-André Lureau wrote: > > - Original Message - > > Why do you want to require c99? Do the compilers we use on windows > > have > > good enough c99 support? > > Because we use c99: stdbool.h, inttypes.h, bool, variadic macros, // > comments, ..

Re: [Spice-devel] [PATCH 6/9] common: spice_memdup could accept NULL

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:27:18AM -0400, Marc-André Lureau wrote: > Sigh.. i would prefer to avoid ASSERT, and instead use return_val_if_fail() > or so. > > That's probably why I didn't add it in the first place. The old code would crash anyway when being passed NULL, that's why I suggested a h

Re: [Spice-devel] [PATCH 3/9] common: RFC: add windows.h where required, make gdi_handlers static

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:34:13AM -0400, Marc-André Lureau wrote: > Because those files use Windows API (and I remember they failed to compile > with spice-gtk/mingw). Ok, ACK from me then, but I'm as clueless as you are about windows :) Christophe pgpeneDKycMMT.pgp Description: PGP signature

Re: [Spice-devel] [PATCH 6/9] common: spice_memdup could accept NULL

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 02:06:48PM +0200, Christophe Fergeau wrote: > On Wed, Apr 27, 2011 at 07:27:18AM -0400, Marc-André Lureau wrote: > > Sigh.. i would prefer to avoid ASSERT, and instead use return_val_if_fail() > > or so. > > > > That's probably why I didn't add it in the first place. > >

Re: [Spice-devel] spice-gtk 0.6 : Ctrl+W closes the client

2011-04-27 Thread Marc-André Lureau
Hi On Wed, Apr 27, 2011 at 11:19 AM, Christophe Fergeau wrote: > > I've sent a merge request, so hopefully it will get upstream soon :) > Merged a few hours ago. thanks -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.

Re: [Spice-devel] [PATCH 7/9] common: add ring_get_length() for debugging purposes

2011-04-27 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 02:33:34PM -0500, Marc-André Lureau wrote: > Hi > > > > +static inline unsigned int ring_get_length(Ring *ring) > > > > This won't compile if no one uses it - so you probably want to make > > it non static (or do a hack by doing (void)ring_get_length somewhere). > > Corre

Re: [Spice-devel] [PATCH 7/9] common: add ring_get_length() for debugging purposes

2011-04-27 Thread Marc-André Lureau
- Original Message - > On Tue, Jan 25, 2011 at 02:33:34PM -0500, Marc-André Lureau wrote: > > Hi > > > > > > +static inline unsigned int ring_get_length(Ring *ring) > > > > > > This won't compile if no one uses it - so you probably want to > > > make > > > it non static (or do a hack by d

Re: [Spice-devel] [PATCH 0/8] Rework autotools build system

2011-04-27 Thread Marc-André Lureau
Hi On Thu, Apr 21, 2011 at 2:00 PM, Christophe Fergeau wrote: > Hi, > > The autotools build system looked a bit convoluted when I looked at it, > and after toying a bit with it when preparing the earlier patchset, it > seemed more fragile than autotools build systems generally are. This > patchse

Re: [Spice-devel] [PATCH 7/9] common: add ring_get_length() for debugging purposes

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 10:24:01AM -0400, Marc-André Lureau wrote: > > Do you mean it should be #ifdef'ed? or that it's better to add the > > equivalent of G_GNUC_UNUSED to the function definition to avoid the > > compiler > > warning? > > Is there such warning? I was expecting unused inline funct

[Spice-devel] [RFC 00/33] xspice using a shortcircuited driver

2011-04-27 Thread Alon Levy
This patchset introduces a second target namely spiceqxl_drv.so that contains a display driver, a keyboard and mouse driver, and they all use a single spice server instance. Effectively this allows a spice server using a config file such as: Section "Device" Identifier "XSPICE" Driver "spiceqxl"

[Spice-devel] [RFC 01/33] qxl.h: double include protection

2011-04-27 Thread Alon Levy
--- src/qxl.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 60a1046..9451d05 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -20,6 +20,9 @@ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ +#ifndef QXL_H +#de

[Spice-devel] [RFC 02/33] qxl_mem.c: fix pointer arithmatic warning (-Wpointer-arith)

2011-04-27 Thread Alon Levy
--- src/qxl_mem.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qxl_mem.c b/src/qxl_mem.c index bce80ad..705eb83 100644 --- a/src/qxl_mem.c +++ b/src/qxl_mem.c @@ -18,7 +18,7 @@ qxl_mem_create (void *base, if (!mem) goto out; -

[Spice-devel] [RFC 03/33] qxl_image.c: fix defined but unused warning

2011-04-27 Thread Alon Levy
--- src/qxl_image.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/qxl_image.c b/src/qxl_image.c index 04074d0..af83bd6 100644 --- a/src/qxl_image.c +++ b/src/qxl_image.c @@ -93,6 +93,7 @@ lookup_image_info (unsigned int hash, return NULL; } +#if 0 static im

[Spice-devel] [RFC 04/33] qxl.h: move spice include right after system includes

2011-04-27 Thread Alon Levy
--- src/qxl.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 9451d05..d086ac7 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -27,6 +27,7 @@ #include +#include #include "compiler.h" #include "xf86.h" #if GET_ABI_MAJOR(ABI_VIDEODRV_VERSION

[Spice-devel] [RFC 05/33] qxl_ring: keep qxl pointer

2011-04-27 Thread Alon Levy
Add a qxl_screen_t* member to qxl_ring to make generelizing outb to ioport_write easier in the next patch. This means we do an extra deref and addition for every outb, but it means the code becomes simpler for doing outb in qxl_drv.so and a function call for spiceqxl_drv.so --- src/qxl.h|

[Spice-devel] [RFC 06/33] partially replace outb with ioport_write

2011-04-27 Thread Alon Levy
replace everywhere it is needed for xspice - places left out are ifdefed out later based on the same define mentioned in qxl.h, XSPICE. note: leave spaces between function name and open paren? note2: ioport_write is added at the end of the file because the xspice implementation will need access

[Spice-devel] [RFC 07/33] use spice-protocol defines for ring sizes

2011-04-27 Thread Alon Levy
--- src/qxl_driver.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index a0aea25..ee6b892 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -908,13 +908,13 @@ qxl_screen_init(int scrnIndex, ScreenPtr pScreen, int argc, char

[Spice-devel] [RFC 08/33] qxl_driver: add setup_slot helper

2011-04-27 Thread Alon Levy
used in qxl_reset. Later ifdefed with XSPICE, which only uses a single slot covering all memory (really it should just avoid calling the translation mechanism, but for now this is simple enough). --- src/qxl_driver.c | 87 ++ 1 files changed, 4

[Spice-devel] [RFC 09/33] qxl_driver: fix initialization from wrong pointer warning

2011-04-27 Thread Alon Levy
--- src/qxl_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 3514360..dced9fb 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -60,7 +60,7 @@ qxl_garbage_collect (qxl_screen_t *qxl) union QX

[Spice-devel] [RFC 10/33] add config options (empty for now)

2011-04-27 Thread Alon Levy
--- src/qxl.h| 10 ++ src/qxl_driver.c |6 ++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 9683966..7c889d3 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -82,6 +82,14 @@ typedef struct typedef struct qxl_surface_t qxl_surface_

[Spice-devel] [RFC 11/33] qxl_driver: fix three incompatible pointer passed warnings

2011-04-27 Thread Alon Levy
--- src/qxl_driver.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ff6fe97..18050fb 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -906,14 +906,14 @@ qxl_screen_init(int scrnIndex, ScreenPtr pScreen, int argc, ch

[Spice-devel] [RFC 12/33] qxl_driver: introduce helpers for memory map and unmap

2011-04-27 Thread Alon Levy
qxl_map_memory_helper and qxl_unmap_memory_helper introduced, here as a simple split, later different implementation if XSPICE defined will be added. Nicer then putting an ifdef inside the map/unmap functions. --- src/qxl_driver.c | 52 1 file

[Spice-devel] [RFC 13/33] qxl_driver: whitespace fixes

2011-04-27 Thread Alon Levy
removing whitespace in lines consisting only of it. most of those areas are touched later, but not all. --- src/qxl_driver.c | 50 +- 1 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ac377ea

[Spice-devel] [RFC 14/33] configure.ac: add check for spice-server (allowed to fail)

2011-04-27 Thread Alon Levy
--- configure.ac |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index ce67b41..99bc517 100644 --- a/configure.ac +++ b/configure.ac @@ -76,6 +76,14 @@ AM_CONDITIONAL(XSERVER_LIBPCIACCESS, test "x$XSERVER_LIBPCIACCESS" = xyes) # Check

[Spice-devel] [RFC 15/33] configure.ac/Makefile.am: add SUPPORT_XSPICE

2011-04-27 Thread Alon Levy
--- configure.ac|2 ++ src/Makefile.am | 23 +++ 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 99bc517..6a183df 100644 --- a/configure.ac +++ b/configure.ac @@ -86,6 +86,8 @@ PKG_CHECK_MODULES([SPICE], [spice-server

[Spice-devel] [RFC 16/33] xspice: use spiceqxl as name of xspice driver

2011-04-27 Thread Alon Levy
Fixes a few places that have hardcoded "qxl" to use the already defined QXL_DRIVER_NAME. --- src/qxl.h|5 + src/qxl_driver.c |6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 7c889d3..ba2b0eb 100644 --- a/src/qxl.h +++ b/src/q

[Spice-devel] [RFC 17/33] xspice: add spiceqxl_io_port, empty

2011-04-27 Thread Alon Levy
--- src/Makefile.am|1 + src/qxl.h |4 +++- src/spiceqxl_io_port.c | 12 src/spiceqxl_io_port.h |9 + 4 files changed, 25 insertions(+), 1 deletions(-) create mode 100644 src/spiceqxl_io_port.c create mode 100644 src/spiceqxl_io_port.h dif

[Spice-devel] [RFC 18/33] xspice: use SPICE_CFLAGS

2011-04-27 Thread Alon Levy
--- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 8f048c8..6f2cb56 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -53,7 +53,7 @@ spiceqxl_drv_la_LTLIBRARIES = spiceqxl_drv.la spiceqxl_drv_la_LDFLAGS = -modu

[Spice-devel] [RFC 19/33] cleanup (add eol between system and non system includes)

2011-04-27 Thread Alon Levy
--- src/qxl.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index e45066c..3fddef3 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -28,6 +28,7 @@ #include #include + #include "compiler.h" #include "xf86.h" #if GET_ABI_MAJOR(ABI_VIDEODRV_VERSION)

[Spice-devel] [RFC 20/33] xspice: stop using pci and vga

2011-04-27 Thread Alon Levy
This ifdefs out all the parts in qxl_driver.c that are pci device specific and are not required by xspice. No functional change. The resulting spiceqxl_drv.so doesn't run. --- src/qxl.h|9 - src/qxl_driver.c | 89 +- 2 files ch

[Spice-devel] [RFC 21/33] qxl_driver.c: whitespace fix

2011-04-27 Thread Alon Levy
--- src/qxl_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ba3170e..198af00 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1115,7 +1115,7 @@ qxl_check_device(ScrnInfoPtr pScrn, qxl_screen_t *qxl) return

[Spice-devel] [RFC 22/33] xspice: allocate a single slot

2011-04-27 Thread Alon Levy
--- src/qxl_driver.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 198af00..548bc15 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -424,6 +424,9 @@ qxl_reset (qxl_screen_t *qxl) qxl->mem_slots = xnfalloc (qxl->

[Spice-devel] [RFC 23/33] xspice: don't load ramdac and vgahw sub modules

2011-04-27 Thread Alon Levy
--- src/qxl_driver.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 548bc15..3834d3a 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1341,9 +1341,12 @@ qxl_pre_init(ScrnInfoPtr pScrn, int flags) xf86PrintMode

[Spice-devel] [RFC 24/33] xspice: use spiceqxlModuleData as entry point

2011-04-27 Thread Alon Levy
--- src/qxl_driver.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 3834d3a..c77a5f1 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1584,7 +1584,13 @@ static XF86ModuleVersionInfo qxl_module_info = { { 0, 0,

[Spice-devel] [RFC 25/33] xspice: implement map_helper, unmap_helper, add init_qxl_rom

2011-04-27 Thread Alon Levy
Memory is taken from malloc instead of from the pci bar. Adds shadow_rom to qxl_screen_t. Introduces init_qxl_rom, which is directly taken from the qxl device in qemu. Plenty of TODO's added in this commit about various constants and about factoring out the code to not do this copy paste from qem

[Spice-devel] [RFC 26/33] xspice: add SpicePort config option

2011-04-27 Thread Alon Levy
--- src/qxl.h|3 +++ src/qxl_driver.c |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 4b78076..2dc4cf9 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -96,6 +96,9 @@ typedef struct qxl_surface_t qxl_surface_t; */ enum { +#ifdef XSPI

[Spice-devel] [RFC 27/33] xspice: init spice server, add main loop

2011-04-27 Thread Alon Levy
Initialize a SpiceServer instance, and implement SpiceCoreInterface, that is fd read, write notification and watchs (timers). The fd implementation is off because Xserver doesn't allow us to be notified on write unblock, only read. Workaround is to poll. --- src/Makefile.am |1 + src

[Spice-devel] [RFC 28/33] xspice: add display interface

2011-04-27 Thread Alon Levy
--- src/Makefile.am|1 + src/qxl.h | 24 src/qxl_driver.c |3 + src/spiceqxl_display.c | 319 src/spiceqxl_display.h | 11 ++ 5 files changed, 358 insertions(+), 0 deletions(-) create mode 100644 src/spi

[Spice-devel] [RFC 29/33] xspice: add init_qxl_ram

2011-04-27 Thread Alon Levy
--- src/qxl_driver.c |2 + src/spiceqxl_io_port.c | 49 src/spiceqxl_io_port.h |4 +++ 3 files changed, 55 insertions(+), 0 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index fe2f532..ef3139b 100644 --- a/src/qxl_dr

[Spice-devel] [RFC 30/33] xspice: implement ioport_write

2011-04-27 Thread Alon Levy
--- src/spiceqxl_io_port.c | 181 1 files changed, 181 insertions(+), 0 deletions(-) diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c index ba6ac4a..89a9657 100644 --- a/src/spiceqxl_io_port.c +++ b/src/spiceqxl_io_port.c @@ -54,8 +54,

[Spice-devel] [RFC 31/33] xspice: add inputs (mouse and keyboard)

2011-04-27 Thread Alon Levy
--- src/Makefile.am |1 + src/qxl_driver.c |2 + src/spiceqxl_inputs.c | 353 + src/spiceqxl_inputs.h |9 ++ 4 files changed, 365 insertions(+), 0 deletions(-) create mode 100644 src/spiceqxl_inputs.c create mode 100644 src/

[Spice-devel] [RFC 32/33] xspice: README, config, launcher script

2011-04-27 Thread Alon Levy
--- README.xspice | 109 TODO.xspice| 27 + spiceqxl.xorg.conf | 15 +++ xspice | 21 ++ 4 files changed, 172 insertions(+), 0 deletions(-) create mode 100644 README.xspice create mode 10

[Spice-devel] [RFC 33/33] xspice/qxl_ring: yield when ring is full

2011-04-27 Thread Alon Levy
--- src/qxl_ring.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/qxl_ring.c b/src/qxl_ring.c index 0870ef1..02c4c35 100644 --- a/src/qxl_ring.c +++ b/src/qxl_ring.c @@ -75,7 +75,11 @@ qxl_ring_push (struct qxl_ring *ring, while (header->prod - header->cons

Re: [Spice-devel] [PATCH 7/9] common: add ring_get_length() for debugging purposes

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 05:53:34PM +0200, Christophe Fergeau wrote: > On Wed, Apr 27, 2011 at 10:24:01AM -0400, Marc-André Lureau wrote: > > > Do you mean it should be #ifdef'ed? or that it's better to add the > > > equivalent of G_GNUC_UNUSED to the function definition to avoid the > > > compiler

Re: [Spice-devel] [PATCH 7/9] common: add ring_get_length() for debugging purposes

2011-04-27 Thread Marc-André Lureau
-Wunused-function Warn whenever a static function is declared but not defined or a non-inline static function is unused. This warning is enabled by -Wall. I don't know if there is a flag to warn about unused static inline function. ring.h contains many inline functions that are not necessarily u

Re: [Spice-devel] [PATCH 00/12] More cleanups

2011-04-27 Thread Marc-André Lureau
Ack (with the corrections you mentioned) On Fri, Apr 22, 2011 at 6:42 PM, Christophe Fergeau wrote: > Here are again some cleanups, the main highlights are the use of > gcc builtin atomic functions to remove some x86 assembly, after > this there should no longer be some mandatory x86 assembly, th

[Spice-devel] OSX spice-gtk and pyparsing

2011-04-27 Thread Cliff Sharp
When building spice-gtk after loading tons of MacPorts dependencies -- I was getting the following error. make all-recursive Making all in common Making all in win Making all in my_getopt-1.5 make[4]: Nothing to be done for `all'. make[4]: Nothing to be done for `all-am'. make[3]: Nothing to be

Re: [Spice-devel] [PATCH 7/9] common: add ring_get_length() for debugging purposes

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 06:00:25PM +0200, Marc-André Lureau wrote: > -Wunused-function > Warn whenever a static function is declared but not defined or a > non-inline static function is unused. This warning is enabled by > -Wall. > > I don't know if there is a flag to warn about unused static inli

[Spice-devel] OSX spice-gtk and pyparsing

2011-04-27 Thread Cliff Sharp
When building spice-gtk after loading tons of MacPorts dependencies -- I was getting the following error. make all-recursive Making all in common Making all in win Making all in my_getopt-1.5 make[4]: Nothing to be done for `all'. make[4]: Nothing to be done for `all-am'. make[3]: Nothing to be

Re: [Spice-devel] OSX spice-gtk and pyparsing

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 11:07:55AM -0500, Cliff Sharp wrote: > When building spice-gtk after loading tons of MacPorts dependencies -- I was > getting the following error. To build from git (not from source tar balls) you need pyparsing. I think it's pure python, so should pose absolutely no prob

Re: [Spice-devel] OSX spice-gtk and pyparsing

2011-04-27 Thread Attila Sukosd
Yea, you can even just take the pyparsing.py from the .tgz and put it in the source base dir. (where you run make from) Best Regards, Attila Sukosd - DTU Computing Center - www.cc.dtu.dk att...@cc.dtu.dk, gba...@student.dtu.dk, s070...@student.dtu.dk O

Re: [Spice-devel] OSX spice-gtk and pyparsing

2011-04-27 Thread Mosebach Kai
As Cliff stated on the very end of the mail, taking pyparsing from the original website and manually installing it resolved the problem… Cheers Kai From: Attila Sukosd mailto:attila.suk...@gmail.com>> Date: Wed, 27 Apr 2011 18:30:58 +0200 To: Cliff Sharp mailto:csh...@vbridges.com>>, mailto:spi

Re: [Spice-devel] OSX spice-gtk and pyparsing

2011-04-27 Thread Kai Mosebach
Do you guys have an idea why sound may not be working (it works with the windows client) and why the bandwidth increases by ~70% compared to the spicec.exe from windows? Cheers Kai On 4/27/11 6:34 PM, "Mosebach Kai" wrote: >As Cliff stated on the very end of the mail, taking pyparsing from the

Re: [Spice-devel] OSX spice-gtk and pyparsing

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 06:36:24PM +0200, Kai Mosebach wrote: > Do you guys have an idea why sound may not be working (it works with the > windows client) > and why the bandwidth increases by ~70% compared to the spicec.exe from > windows? The bandwidth thing is just a result of using a different

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-04-27 Thread Emre Erenoglu
On Wed, Apr 27, 2011 at 4:34 PM, Gianluca Cecchi wrote: > On Wed, Apr 27, 2011 at 12:41 PM, Alon Levy wrote: > >> > >> hello, > >> I could send my self compiled qxldd.dll and qxl.sys as described in > >> thread for w2k3 32bit: > >> > http://lists.freedesktop.org/archives/spice-devel/2011-April/00

Re: [Spice-devel] [PATCH 7/9] common: add ring_get_length() for debugging purposes

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 06:00:25PM +0200, Marc-André Lureau wrote: > -Wunused-function > Warn whenever a static function is declared but not defined or a > non-inline static function is unused. This warning is enabled by > -Wall. > > I don't know if there is a flag to warn about unused static inli

Re: [Spice-devel] windows bsod with spice 0.8.1

2011-04-27 Thread Alon Levy
On Wed, Apr 27, 2011 at 09:00:28PM +0400, Emre Erenoglu wrote: > On Wed, Apr 27, 2011 at 4:34 PM, Gianluca Cecchi > wrote: > > > On Wed, Apr 27, 2011 at 12:41 PM, Alon Levy wrote: > > >> > > >> hello, > > >> I could send my self compiled qxldd.dll and qxl.sys as described in > > >> thread for w2k

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 11:29:37AM +0200, Christophe Fergeau wrote: > On Wed, Apr 27, 2011 at 11:27:53AM +0200, Kai Mosebach wrote: > > Regarding the native gtk2 build I think its not possible with macports. > > You would need to use this I guess : http://gtk-osx.sourceforge.net/ > > yes, trying o

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Kai Mosebach
Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/ Another note, on building the OSX client the symbol _g_get_monotonic_clock is missing. I think this comes from gtk/spice-session.c but does not seem to resolve the glib version correctly. I had to uncomment this pretty ug

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:27:58PM +0200, Kai Mosebach wrote: > Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/ > > Another note, on building the OSX client the symbol _g_get_monotonic_clock > is missing. > I think this comes from gtk/spice-session.c but does not seem t

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 10:47:10AM +0200, Christophe Fergeau wrote: > diff --git a/gtk/continuation.h b/gtk/continuation.h > index 585788e..6822757 100644 > --- a/gtk/continuation.h > +++ b/gtk/continuation.h > @@ -21,7 +21,8 @@ > #ifndef _CONTINUATION_H_ > #define _CONTINUATION_H_ > > -#includ

Re: [Spice-devel] Spice on OS/X

2011-04-27 Thread Kai Mosebach
If I run configure --with-coroutine=gthread I don¹t need those patches below. Are there any disadvantages out of the gthreads? On 4/27/11 7:28 PM, "Christophe Fergeau" wrote: >On Wed, Apr 27, 2011 at 10:47:10AM +0200, Christophe Fergeau wrote: >> diff --git a/gtk/continuation.h b/gtk/continuati

Re: [Spice-devel] OSX spice-gtk and pyparsing

2011-04-27 Thread Kai Mosebach
>On Wed, Apr 27, 2011 at 06:36:24PM +0200, Kai Mosebach wrote: >>and why the bandwidth increases by ~70% compared to the spicec.exe from >> windows? > >The bandwidth thing is just a result of using a different client? that is >very bizzarre, since it's all server->client and there is no negotiati

  1   2   >